Add notion of chain state location to the daemon #17932
Open
+84
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-bypass-changelog |
|
!ci-build-me |
The Chain_state_locations module tracks the locations on disk of the components that are considered part of the "chain state". These chain state component locations are subdirectories of the chain state directory. The chain state directory itself is currently the mina config directory, so the chain state components are all still located at their compatible locations at the top level of the mina config directory. Moving the logic of computing these locations into one module will make it easier to change how the chain state directory is computed in future hard forks.
cjjdespres
force-pushed
the
cjjdespres/chain-state-dir
branch
from
3d318ff to
3f5ffdb
Compare
|
!ci-build-me |
|
I think we can already do some magic by using symlink - organize data however we want underlying, but expose a stable disk interface to daemon? ^ But yes this could be a follow up for sure. |
|
Also, we need to confirm if the places touched in this PR are everywhere we refer to FS. If we want to rename those folders. |
Also when this is fixed, I suggest running nightly because we don't know if there's some other assumption in the codebase on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chain_state_locations module tracks the locations on disk of the components that are considered part of the "chain state". These chain state component locations are subdirectories of the chain state directory.
The chain state directory itself is currently the mina config directory, so the chain state components are all still located at their compatible locations at the top level of the mina config directory. Moving the logic of computing these locations into one module will make it easier to change how the chain state directory is computed in future hard forks.
This should be pure refactoring; no component locations have changed.
For reference, the associated MIP draft is here: MinaProtocol/MIPs#32. The
Chain_state_locationsmodule may need to be adjusted as MIP review proceeds, to reflect what is and is not part of the chain state.Closes: #17762