Skip to content

Commit 399378d

Browse files
JoaoPinhoMinderJoaoPinhoMinder
committed
ALFMOB-162: Improve Wishlist Functionality on PLP & Wishlist
- Created `WishlistProduct` and `BagProduct` inheriting from `SelectedProduct`. - Made `WishlistProduct` unique by **product ID and color ID**. - Made `BagProduct` unique by **product ID and variant SKU**. - Removed size information from `WishlistView` and `ProductListingView`. - Updated **"Add to Bag"** action in `WishlistView` to redirect users to **PDP** for size selection instead of adding directly to the bag. - Disabled **"Add to Bag"** button on **PDP** until both **color** (pre-selected) and **size** have been selected.
1 parent 5522d64 commit 399378d

29 files changed

+236
-95
lines changed

‎Alfie/Alfie/Localization/L10n+Generated.swift‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,10 @@ enum L10n {
192192
enum Size {
193193
/// Size
194194
static let title = L10n.tr("L10n", "product.size.title")
195+
enum NoSelection {
196+
/// Select a size
197+
static let title = L10n.tr("L10n", "product.size.no_selection.title")
198+
}
195199
}
196200
}
197201
enum Search {
@@ -471,6 +475,7 @@ extension L10n {
471475
case productOneSizeTitle = "product.one_size.title"
472476
case productOutOfStockButtonCta = "product.out_of_stock.button.cta"
473477
case productSizeTitle = "product.size.title"
478+
case productSizeNoSelectionTitle = "product.size.no_selection.title"
474479
case searchScreenEmptyViewMessage = "search.screen.empty_view.message"
475480
case searchScreenEmptyViewTitle = "search.screen.empty_view.title"
476481
case searchScreenNoResultsViewLink = "search.screen.no_results_view.link"

‎Alfie/Alfie/Localization/L10n.xcstrings‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,17 @@
409409
}
410410
}
411411
},
412+
"product.size.no_selection.title" : {
413+
"extractionState" : "manual",
414+
"localizations" : {
415+
"en" : {
416+
"stringUnit" : {
417+
"state" : "translated",
418+
"value" : "Select a size"
419+
}
420+
}
421+
}
422+
},
412423
"product.size.title" : {
413424
"extractionState" : "manual",
414425
"localizations" : {

‎Alfie/Alfie/Views/BagView/BagViewModel.swift‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Foundation
22
import Models
33

44
final class BagViewModel: BagViewModelProtocol {
5-
@Published private(set) var products: [SelectedProduct]
5+
@Published private(set) var products: [BagProduct]
66

77
private let dependencies: BagDependencyContainer
88

@@ -17,13 +17,13 @@ final class BagViewModel: BagViewModelProtocol {
1717
products = dependencies.bagService.getBagContent()
1818
}
1919

20-
func didSelectDelete(for selectedProduct: SelectedProduct) {
20+
func didSelectDelete(for selectedProduct: BagProduct) {
2121
dependencies.bagService.removeProduct(selectedProduct)
2222
products = dependencies.bagService.getBagContent()
2323
dependencies.analytics.trackRemoveFromBag(productID: selectedProduct.product.id)
2424
}
2525

26-
func productCardViewModel(for selectedProduct: SelectedProduct) -> HorizontalProductCardViewModel {
26+
func productCardViewModel(for selectedProduct: BagProduct) -> HorizontalProductCardViewModel {
2727
.init(
2828
image: selectedProduct.media.first?.asImage?.url,
2929
designer: selectedProduct.brand.name,

‎Alfie/Alfie/Views/ProductDetails/ProductDetailsView.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ extension ProductDetailsView {
489489
ThemedButton(
490490
text: viewModel.productHasStock ? addToBagText : outOfStockText,
491491
isDisabled: .init(
492-
get: { !viewModel.productHasStock },
492+
get: { !viewModel.isAddToBagEnabled },
493493
set: { _ in }
494494
),
495495
isFullWidth: true

‎Alfie/Alfie/Views/ProductDetails/ProductDetailsViewModel.swift‎

Lines changed: 54 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
2727

2828
private var selectedVariant: Product.Variant? {
2929
guard case .success(let model) = state else {
30-
return initialSelectedProduct?.selectedVariant ?? baseProduct?.defaultVariant
30+
return initialSelectedProduct?.selectedVariant ?? baseProduct?.defaultVariantWithoutSize
3131
}
3232

3333
return model.selectedVariant
@@ -88,6 +88,20 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
8888
product?.priceType
8989
}
9090

91+
var isAddToBagEnabled: Bool {
92+
productHasStock
93+
&& hasColorSelected
94+
&& hasSizeSelected
95+
}
96+
97+
private var hasColorSelected: Bool {
98+
colorSelectionConfiguration.items.count > 1 ? selectedVariant?.colour != nil : true
99+
}
100+
101+
private var hasSizeSelected: Bool {
102+
sizingSelectionConfiguration.items.count > 1 ? selectedVariant?.size != nil : true
103+
}
104+
91105
init(
92106
productId: String,
93107
product: Product?,
@@ -103,7 +117,7 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
103117
case (.some(let product), .none):
104118
buildColorAndSizingSelectionConfigurations(
105119
product: product,
106-
selectedVariant: product.defaultVariant
120+
selectedVariant: product.defaultVariantWithoutSize
107121
)
108122

109123
case (_, .some(let selectedProduct)):
@@ -179,14 +193,16 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
179193

180194
func didTapAddToBag() {
181195
guard let selectedProduct else { return }
182-
dependencies.bagService.addProduct(selectedProduct)
183-
dependencies.analytics.trackAddToBag(productID: selectedProduct.id)
196+
let bagProduct = BagProduct(selectedProduct: selectedProduct)
197+
dependencies.bagService.addProduct(bagProduct)
198+
dependencies.analytics.trackAddToBag(productID: bagProduct.id)
184199
}
185200

186201
func didTapAddToWishlist() {
187202
guard let selectedProduct else { return }
188-
dependencies.wishlistService.addProduct(selectedProduct)
189-
dependencies.analytics.trackAddToWishlist(productID: selectedProduct.id)
203+
let wishlistProduct = WishlistProduct(selectedProduct: selectedProduct)
204+
dependencies.wishlistService.addProduct(wishlistProduct)
205+
dependencies.analytics.trackAddToWishlist(productID: wishlistProduct.id)
190206
}
191207

192208
func colorSwatches(filteredBy searchTerm: String) -> [ColorSwatch] {
@@ -221,7 +237,7 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
221237
return
222238
}
223239

224-
let selectedVariant = initialSelectedProduct?.selectedVariant ?? product.defaultVariant
240+
let selectedVariant = initialSelectedProduct?.selectedVariant ?? product.defaultVariantWithoutSize
225241
buildColorAndSizingSelectionConfigurations(product: product, selectedVariant: selectedVariant)
226242
state = .success(.init(product: product, selectedVariant: selectedVariant))
227243
}
@@ -301,7 +317,8 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
301317
sizingSelectionConfiguration = .init(
302318
selectedTitle: L10n.Product.Size.title + ":",
303319
items: sizingSwatches,
304-
selectedItem: selectedSwatch
320+
selectedItem: selectedSwatch,
321+
noItemSelectedTitle: L10n.Product.Size.NoSelection.title
305322
)
306323
sizingSelectionSubscription = sizingSelectionConfiguration.$selectedItem
307324
.receive(on: DispatchQueue.main)
@@ -354,14 +371,26 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
354371
}
355372

356373
guard let variant = product.variants.first(
357-
where: { $0.colour?.id == colorSwatch.id && $0.size?.id == selectedVariant?.size?.id }
374+
where: {
375+
$0.colour?.id == colorSwatch.id
376+
&& (selectedVariant?.size?.id == nil || $0.size?.id == selectedVariant?.size?.id)
377+
}
358378
)
359379
else {
360380
log.debug("Unexpected data inconsistency: tried to select color \(colorSwatch.id) on product \(productId) but no variant exists with that color, ignoring selection")
361381
return
362382
}
363383

364-
state = .success(.init(product: product, selectedVariant: variant))
384+
let updatedVariant = Product.Variant(
385+
sku: variant.sku,
386+
size: selectedVariant?.size, // Making sure if no size selected, it will not auto select
387+
colour: variant.colour,
388+
attributes: variant.attributes,
389+
stock: variant.stock,
390+
price: variant.price
391+
)
392+
393+
state = .success(.init(product: product, selectedVariant: updatedVariant))
365394
}
366395

367396
private func didSelect(sizingSwatch: SizingSwatch) {
@@ -371,14 +400,26 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
371400
}
372401

373402
guard let variant = product.variants.first(
374-
where: { $0.size?.id == sizingSwatch.id && $0.colour?.id == selectedVariant?.colour?.id }
403+
where: {
404+
$0.size?.id == sizingSwatch.id
405+
&& (selectedVariant?.colour?.id == nil || $0.colour?.id == selectedVariant?.colour?.id)
406+
}
375407
)
376408
else {
377409
log.debug("Unexpected data inconsistency: tried to select size \(sizingSwatch.id) on product \(productId) but no variant exists with that size, ignoring selection")
378410
return
379411
}
380412

381-
state = .success(.init(product: product, selectedVariant: variant))
413+
let updatedVariant = Product.Variant(
414+
sku: variant.sku,
415+
size: variant.size,
416+
colour: selectedVariant?.colour, // Making sure if no color selected, it will not auto select
417+
attributes: variant.attributes,
418+
stock: variant.stock,
419+
price: variant.price
420+
)
421+
422+
state = .success(.init(product: product, selectedVariant: updatedVariant))
382423
}
383424

384425
private var selectedProduct: SelectedProduct? {
@@ -391,4 +432,4 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
391432

392433
return SelectedProduct(product: product, selectedVariant: selectedVariant)
393434
}
394-
}
435+
} // swiftlint:disable:this file_length

‎Alfie/Alfie/Views/ProductListing/ProductListingView.swift‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ struct ProductListingView<ViewModel: ProductListingViewModelProtocol>: View {
7272
viewModel: .init(
7373
configuration: .init(
7474
size: viewModel.style == .list ? .large : .medium,
75+
hideSize: true,
7576
hideAction: !coordinator.isWishlistEnabled
7677
),
7778
product: product

‎Alfie/Alfie/Views/ProductListing/ProductListingViewModel.swift‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,18 @@ final class ProductListingViewModel: ProductListingViewModelProtocol {
7979
func didSelect(_: Product) {}
8080

8181
func isFavoriteState(for product: Product) -> Bool {
82-
wishlistContent.contains { $0.product.defaultVariant.sku == product.defaultVariant.sku }
82+
wishlistContent.contains { $0.product.id == product.id }
8383
}
8484

8585
func didTapAddToWishlist(for product: Product, isFavorite: Bool) {
8686
if !isFavorite {
87-
let selectedProduct = SelectedProduct(product: product)
88-
dependencies.wishlistService.addProduct(selectedProduct)
89-
dependencies.analytics.trackAddToWishlist(productID: product.id)
87+
let wishlistProduct = WishlistProduct(product: product)
88+
dependencies.wishlistService.addProduct(wishlistProduct)
89+
dependencies.analytics.trackAddToWishlist(productID: wishlistProduct.id)
9090
} else {
91-
let selectedProduct = SelectedProduct(product: product)
92-
dependencies.wishlistService.removeProduct(selectedProduct)
93-
dependencies.analytics.trackRemoveFromWishlist(productID: product.id)
91+
let wishlistProduct = WishlistProduct(product: product)
92+
dependencies.wishlistService.removeProduct(wishlistProduct)
93+
dependencies.analytics.trackRemoveFromWishlist(productID: wishlistProduct.id)
9494
}
9595
wishlistContent = dependencies.wishlistService.getWishlistContent()
9696
}

‎Alfie/Alfie/Views/WishlistView/WishlistView.swift‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ struct WishlistView<ViewModel: WishlistViewModelProtocol>: View {
5050
// MARK: - Private Methods
5151

5252
private extension WishlistView {
53-
func handleUserAction(forProduct product: SelectedProduct, actionType: VerticalProductCard.ProductUserActionType) {
53+
func handleUserAction(forProduct product: WishlistProduct, actionType: VerticalProductCard.ProductUserActionType) {
5454
// swiftlint:disable vertical_whitespace_between_cases
5555
switch actionType {
5656
case .remove:
5757
viewModel.didSelectDelete(for: product)
5858
case .addToBag:
59-
viewModel.didTapAddToBag(for: product)
59+
coordinador.openDetails(for: product)
6060
case .wishlist:
6161
return
6262
}

‎Alfie/Alfie/Views/WishlistView/WishlistViewModel.swift‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Foundation
22
import Models
33

44
final class WishlistViewModel: WishlistViewModelProtocol {
5-
@Published private(set) var products: [SelectedProduct]
5+
@Published private(set) var products: [WishlistProduct]
66

77
private let dependencies: WishlistDependencyContainer
88

@@ -17,20 +17,15 @@ final class WishlistViewModel: WishlistViewModelProtocol {
1717
products = dependencies.wishlistService.getWishlistContent()
1818
}
1919

20-
func didSelectDelete(for selectedProduct: SelectedProduct) {
20+
func didSelectDelete(for selectedProduct: WishlistProduct) {
2121
dependencies.wishlistService.removeProduct(selectedProduct)
2222
dependencies.analytics.trackRemoveFromWishlist(productID: selectedProduct.product.id)
2323
products = dependencies.wishlistService.getWishlistContent()
2424
}
2525

26-
func didTapAddToBag(for selectedProduct: SelectedProduct) {
27-
dependencies.bagService.addProduct(selectedProduct)
28-
dependencies.analytics.trackAddToBag(productID: selectedProduct.product.id)
29-
}
30-
31-
func productCardViewModel(for selectedProduct: SelectedProduct) -> VerticalProductCardViewModel {
26+
func productCardViewModel(for selectedProduct: WishlistProduct) -> VerticalProductCardViewModel {
3227
.init(
33-
configuration: .init(size: .medium, hideDetails: false, actionType: .remove),
28+
configuration: .init(size: .medium, hideSize: true, actionType: .remove),
3429
productId: selectedProduct.id,
3530
image: selectedProduct.media.first?.asImage?.url,
3631
designer: selectedProduct.brand.name,

‎Alfie/AlfieKit/Sources/Core/Services/Bag/BagService.swift‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@ import Models
33

44
// TODO: Update with an actual implementation with storage
55
public final class BagService: BagServiceProtocol {
6-
private var products: [SelectedProduct] = []
6+
private var products: [BagProduct] = []
77

88
public init() { }
99

10-
public func addProduct(_ product: SelectedProduct) {
11-
guard !products.contains(where: { $0.id == product.id }) else { return }
10+
public func addProduct(_ bagProduct: BagProduct) {
11+
guard !products.contains(where: { $0.id == bagProduct.id }) else { return }
1212

13-
products.append(product)
13+
products.append(bagProduct)
1414
}
1515

16-
public func removeProduct(_ product: SelectedProduct) {
17-
products = products.filter { $0.id != product.id }
16+
public func removeProduct(_ bagProduct: BagProduct) {
17+
products = products.filter { $0.id != bagProduct.id }
1818
}
1919

20-
public func getBagContent() -> [SelectedProduct] {
20+
public func getBagContent() -> [BagProduct] {
2121
products
2222
}
2323
}

0 commit comments

Comments
 (0)