Skip to content

Commit 6a1e7a9

Browse files
committed
Fix iterator being accessed before being checked.
1 parent 3afb032 commit 6a1e7a9

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

at-gradle/src/main/java/net/minecraftforge/accesstransformers/gradle/AccessTransformersExtensionImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.gradle.api.attributes.Attribute;
2020
import org.gradle.api.attributes.AttributeContainer;
2121
import org.gradle.api.attributes.Category;
22-
import org.gradle.api.file.ProjectLayout;
2322
import org.gradle.api.logging.Logger;
2423
import org.gradle.api.logging.Logging;
2524
import org.gradle.api.model.ObjectFactory;
@@ -112,8 +111,8 @@ private void apply(Configuration configuration) {
112111
// Check if we have a constraint that matches the dependency, so we can combine AT attributes.
113112
// It's a tad paranoid, but is better than risking having multiple dependency substitutions for the same module.
114113
{
115-
var itor = dependencyConstraints.iterator();
116-
for (var constraint = itor.next(); itor.hasNext(); constraint = itor.next()) {
114+
for (var itor = dependencyConstraints.iterator(); itor.hasNext(); ) {
115+
var constraint = itor.next();
117116
if (!(Objects.equals(constraint.getModule(), module.getModule()) && Objects.equals(constraint.getVersion(), module.getVersion())))
118117
continue;
119118

0 commit comments

Comments
 (0)