Skip to content

Commit 4d302ff

Browse files
committed
Avoid double looping in ListenerListInst#dispose
1 parent a2754f0 commit 4d302ff

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/main/java/net/minecraftforge/eventbus/ListenerList.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,13 @@ private ListenerListInst() {
117117

118118
public void dispose() {
119119
writeLock.acquireUninterruptibly();
120-
for (@Nullable ArrayList<IEventListener> priority : priorities) {
121-
if (priority != null)
120+
for (int i = 0; i < priorities.length; i++) {
121+
@Nullable ArrayList<IEventListener> priority = priorities[i];
122+
if (priority != null) {
122123
priority.clear();
124+
priorities[i] = null;
125+
}
123126
}
124-
Arrays.fill(priorities, null);
125127
writeLock.release();
126128
parent = null;
127129
listeners = null;

0 commit comments

Comments
 (0)