Skip to content

Commit 9be05d7

Browse files
committed
gradle build now works as expected, automatically runs the CI setup
1 parent 379f05b commit 9be05d7

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

src/main/java/net/minecraftforge/gradle/user/UserBasePlugin.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -377,11 +377,13 @@ protected void makeDecompTasks(final String globalPattern, final String localPat
377377
@Override
378378
public void execute(Project project)
379379
{
380-
boolean isDecomp = false;
381-
382-
if (project.file(recompiledJar).exists())
380+
// the recompiled jar exists, or the decomp task is part of the build
381+
boolean isDecomp = project.file(recompiledJar).exists() || project.getGradle().getStartParameter().getTaskNames().contains(TASK_SETUP_DECOMP);
382+
383+
// set task dependencies
384+
if (!isDecomp)
383385
{
384-
isDecomp = true;
386+
project.getTasks().getByName("compileJava").dependsOn(UserConstants.TASK_DEOBF_BIN);
385387
}
386388

387389
afterDecomp(isDecomp, useLocalCache(getExtension()), CONFIG_MC);
@@ -466,8 +468,7 @@ protected void configureCompilation()
466468
test.setRuntimeClasspath(test.getRuntimeClasspath()
467469
.plus(api.getOutput())
468470
.plus(project.getConfigurations().getByName(CONFIG_MC))
469-
.plus(project.getConfigurations().getByName(CONFIG_MC_DEPS))
470-
.plus(project.getConfigurations().getByName(CONFIG_START)));
471+
.plus(project.getConfigurations().getByName(CONFIG_MC_DEPS)));
471472

472473
project.getConfigurations().getByName("compile").extendsFrom(project.getConfigurations().getByName(CONFIG_DC_RESOLVED));
473474
project.getConfigurations().getByName(CONFIG_PROVIDED).extendsFrom(project.getConfigurations().getByName(CONFIG_DP_RESOLVED));

src/main/java/net/minecraftforge/gradle/user/patcherUser/PatcherUserBasePlugin.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,24 @@
11
package net.minecraftforge.gradle.user.patcherUser;
22

3-
import static net.minecraftforge.gradle.common.Constants.*;
3+
import static net.minecraftforge.gradle.common.Constants.DIR_JSONS;
4+
import static net.minecraftforge.gradle.common.Constants.JAR_MERGED;
5+
import static net.minecraftforge.gradle.common.Constants.MCP_PATCHES_MERGED;
6+
import static net.minecraftforge.gradle.common.Constants.TASK_DL_VERSION_JSON;
7+
import static net.minecraftforge.gradle.common.Constants.TASK_GENERATE_SRGS;
8+
import static net.minecraftforge.gradle.common.Constants.TASK_MERGE_JARS;
49
import static net.minecraftforge.gradle.user.UserConstants.*;
510
import static net.minecraftforge.gradle.user.patcherUser.PatcherUserConstants.*;
6-
import groovy.lang.Closure;
711

812
import java.io.File;
913

14+
import org.gradle.api.Action;
15+
import org.gradle.api.Project;
16+
import org.gradle.api.plugins.JavaPluginConvention;
17+
import org.gradle.api.tasks.SourceSet;
18+
19+
import com.google.common.collect.ImmutableMap;
20+
21+
import groovy.lang.Closure;
1022
import net.minecraftforge.gradle.tasks.DeobfuscateJar;
1123
import net.minecraftforge.gradle.tasks.ExtractConfigTask;
1224
import net.minecraftforge.gradle.tasks.PatchSourcesTask;
@@ -17,13 +29,6 @@
1729
import net.minecraftforge.gradle.user.UserBasePlugin;
1830
import net.minecraftforge.gradle.util.delayed.TokenReplacer;
1931

20-
import org.gradle.api.Action;
21-
import org.gradle.api.Project;
22-
import org.gradle.api.plugins.JavaPluginConvention;
23-
import org.gradle.api.tasks.SourceSet;
24-
25-
import com.google.common.collect.ImmutableMap;
26-
2732
public abstract class PatcherUserBasePlugin<T extends UserBaseExtension> extends UserBasePlugin<T>
2833
{
2934
@Override

0 commit comments

Comments
 (0)