fixed CI workspace AT issue

Author: AbrarSyed

build.gradle

@@ -35,6 +35,13 @@ repositories {
     }
     jcenter() // get as many deps from here as possible
     mavenCentral()
+
+    // because SS and its snapshot
+    maven {
+        name = "sonatype"
+        url = "https://oss.sonatype.org/content/repositories/snapshots/"
+    }
+
 
     // because of the GradleStart stuff
     maven {
@@ -67,7 +74,7 @@ dependencies {
     compile 'com.google.code.gson:gson:2.2.4' // Used instead of Argo for buuilding changelog.
     compile 'com.github.tony19:named-regexp:0.2.3' // 1.7 Named regexp features
 
-    compile 'net.md-5:SpecialSource:1.7.3' // deobf and reobs
+    compile 'net.md-5:SpecialSource:1.7.4-SNAPSHOT' // deobf and reobs
 
     // because curse
     compile 'org.apache.httpcomponents:httpclient:4.3.3'

src/main/java/net/minecraftforge/gradle/patcher/PatcherPlugin.java

@@ -745,7 +745,7 @@ else if (f.getName().endsWith(".srg"))
                 else if (f.getName().endsWith("_at.cfg"))
                 {
                     // Add ATs for deobf in the same run.. why not...
-                    deobfJar.addTransformerClean(f);
+                    deobfJar.addTransformer(f);
                     mergeFiles.addAt(f);
                 }
             }

src/main/java/net/minecraftforge/gradle/tasks/DeobfuscateJar.java

@@ -83,16 +83,6 @@ public class DeobfuscateJar extends CachedTask
 
     private Object            log;
 
-    private boolean           isClean       = true;
-
-    public void addTransformerClean(Object... obj)
-    {
-        for (Object object : obj)
-        {
-            ats.add(object);
-        }
-    }
-
     /**
      * adds an access transformer to the deobfuscation of this
      * @param obj access transformers
@@ -103,11 +93,6 @@ public void addTransformer(Object... obj)
         {
             ats.add(object);
         }
-
-        if (obj.length > 0)
-        {
-            isClean = false;
-        }
     }
 
     @TaskAction
@@ -147,24 +132,6 @@ private void deobfJar(File inJar, File outJar, File srg, Collection<File> ats) t
         ErroringRemappingAccessMap accessMap = new ErroringRemappingAccessMap(new File[] { getMethodCsv(), getFieldCsv() });
 
         getLogger().info("Using AccessTransformers...");
-        //        PrintStream tmp = System.out;
-        //        System.setOut(new PrintStream(new ByteArrayOutputStream()
-        //        {
-        //            @Override
-        //            public void write(int b)
-        //            {
-        //            }
-        //
-        //            @Override
-        //            public void write(byte[] b, int off, int len)
-        //            {
-        //            }
-        //
-        //            @Override
-        //            public void writeTo(OutputStream out) throws IOException
-        //            {
-        //            }
-        //        }));
         //Make SS shutup about access maps
         for (File at : ats)
         {
@@ -496,22 +463,6 @@ public void setMethodCsv(Object methodCsv)
         this.methodCsv = methodCsv;
     }
 
-    @Override
-    protected boolean defaultCache()
-    {
-        return isClean;
-    }
-
-    public boolean isClean()
-    {
-        return isClean;
-    }
-
-    public void setDirty()
-    {
-        isClean = false;
-    }
-
     private static final class ErroringRemappingAccessMap extends AccessMap
     {
         private final Map<String, String> renames     = Maps.newHashMap();
@@ -589,8 +540,9 @@ public void addAccessChange(String symbolString, String accessString)
         @Override
         protected void accessApplied(String key, int oldAccess, int newAccess)
         {
-            // if the access' are equal, then the line is broken, and we dont want to remove it.
-            if (oldAccess != newAccess)
+            // if the access' are equal, then the line is broken, and we dont want to remove it.\
+            // or not... it still applied.. just applied twice somehow.. not an issue.
+//            if (oldAccess != newAccess) 
             {
                 // key added before is in format: package/class{method/field sig}
                 // and the key here is in format: package/class {method/field sig}

src/main/java/net/minecraftforge/gradle/user/patcherUser/PatcherUserBasePlugin.java

@@ -72,8 +72,8 @@ public Boolean call()
             DeobfuscateJar deobfBin = (DeobfuscateJar) project.getTasks().getByName(TASK_DEOBF_BIN);
             DeobfuscateJar deobf = (DeobfuscateJar) project.getTasks().getByName(TASK_DEOBF);
 
-            deobfBin.addTransformerClean(delayedFile(AT_USERDEV));
-            deobf.addTransformerClean(delayedFile(AT_USERDEV));
+            deobfBin.addTransformer(delayedFile(AT_USERDEV));
+            deobf.addTransformer(delayedFile(AT_USERDEV));
         }
 
         // setup binpatching