Switch to DiffPatch (#710)

* Switch to DiffPatch

* Remove deprecated legacy compat.

* Use forge published DiffPatch

Author: covers1624

build.gradle

@@ -71,7 +71,6 @@ wrapper {
 
 dependencies {
     commonImplementation gradleApi()
-    commonImplementation 'com.cloudbees:diff4j:1.3'
     commonImplementation 'commons-io:commons-io:2.8.0'
     commonImplementation 'com.github.jponge:lzma-java:1.3' // replaces the LZMA binary
     commonImplementation 'com.nothome:javaxdelta:2.0.1' // GDIFF implementation for BinPatches
@@ -82,6 +81,7 @@ dependencies {
     commonImplementation 'org.apache.maven:maven-artifact:3.6.3'
     commonImplementation 'org.apache.httpcomponents:httpclient:4.5.13'
     commonImplementation 'net.minecraftforge:srgutils:0.2.13'
+    commonImplementation 'net.minecraftforge:DiffPatch:2.0.0:all'
 
     mcpImplementation sourceSets.common.output
     patcherImplementation sourceSets.mcp.output

src/common/java/net/minecraftforge/gradle/common/diff/ContextualPatch.java

@@ -39,6 +39,9 @@
 import net.minecraftforge.artifactural.gradle.GradleRepositoryAdapter;
 
 public abstract class BaseRepo implements ArtifactProvider<ArtifactIdentifier> {
+
+    public static final boolean DEBUG = Boolean.getBoolean("fg.debugRepo");
+
     private final File cache;
     protected final Logger log;
     protected final String REPO_NAME = getClass().getSimpleName();
@@ -61,7 +64,7 @@ protected String clean(ArtifactIdentifier art) {
     }
 
     protected void debug(String message) {
-        if (System.getProperty("fg.debugRepo", "false").equals("true"))
+        if (DEBUG)
             this.log.lifecycle(message);
     }
     protected void info(String message) {