A few renames to make more sense

- MinecraftMavenExec -> SyncMinecraftMaven
- DefaultTools -> Tools (this is already package-private)

Author: Jonathing

src/main/groovy/net/minecraftforge/gradle/ForgeGradleProblems.java

@@ -182,7 +182,7 @@ void reportMissingMetadata(Throwable throwable) {
             .withException(throwable)
             .stackLocation()
             .solution("Re-run the synchronization for your Gradle project.")
-            .solution("Manually run the " + MinecraftMavenExec.NAME + " task if necessary.")
+            .solution("Manually run the " + SyncMinecraftMaven.NAME + " task if necessary.")
             .solution(HELP_MESSAGE)
         );
     }

src/main/groovy/net/minecraftforge/gradle/MinecraftExtensionImpl.groovy

@@ -219,7 +219,7 @@ import java.util.concurrent.Callable
                     it.attributes(this.&applyAttributes)
             }
 
-            MinecraftMavenExec.register(project, MinecraftExtensionImpl.this.globalCaches, this.minecraft)
+            SyncMinecraftMaven.register(project, MinecraftExtensionImpl.this.globalCaches, this.minecraft)
 
             var repositories = project.extensions.extraProperties.has(EXT_MAVEN_REPOS)
                 ? new AppliedRepos(project.extensions.extraProperties.get(EXT_MAVEN_REPOS) as List<? extends MavenArtifactRepository>)

…ftforge/gradle/MinecraftMavenExec.groovy …ftforge/gradle/SyncMinecraftMaven.groovysrc/main/groovy/net/minecraftforge/gradle/MinecraftMavenExec.groovy renamed to src/main/groovy/net/minecraftforge/gradle/SyncMinecraftMaven.groovy src/main/groovy/net/minecraftforge/gradle/MinecraftMavenExec.groovy renamed to src/main/groovy/net/minecraftforge/gradle/SyncMinecraftMaven.groovy

@@ -9,12 +9,10 @@ import groovy.transform.CompileStatic
 import groovy.transform.PackageScope
 import groovy.transform.PackageScopeTarget
 import org.gradle.api.Project
-import org.gradle.api.artifacts.Configuration
 import org.gradle.api.artifacts.Dependency
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.problems.Problems
 import org.gradle.api.provider.Property
-import org.gradle.api.provider.ProviderFactory
 import org.gradle.api.tasks.Input
 import org.gradle.api.tasks.InputDirectory
 import org.gradle.api.tasks.JavaExec
@@ -30,16 +28,16 @@ import javax.inject.Inject
  */
 @CompileStatic
 @PackageScope([PackageScopeTarget.CLASS, PackageScopeTarget.FIELDS])
-abstract class MinecraftMavenExec extends JavaExec {
+abstract class SyncMinecraftMaven extends JavaExec {
     /** The name of the task that is used to sync the Minecraft Maven. */
     static final String NAME = 'syncMinecraftMaven'
 
-    @PackageScope static TaskProvider<MinecraftMavenExec> register(Project project, DirectoryProperty globalCaches, Dependency dependency) {
-        project.tasks.register(NAME, MinecraftMavenExec) {
+    @PackageScope static TaskProvider<SyncMinecraftMaven> register(Project project, DirectoryProperty globalCaches, Dependency dependency) {
+        project.tasks.register(NAME, SyncMinecraftMaven) {
             it.group = 'Build Setup'
             it.description = 'Syncs the Minecraft Maven dependencies.'
 
-            it.classpath = it.objectFactory.fileCollection().from(DefaultTools.MINECRAFT_MAVEN.get(globalCaches, it.providerFactory))
+            it.classpath = it.objectFactory.fileCollection().from(Tools.MINECRAFT_MAVEN.get(globalCaches, it.providerFactory))
 
             it.cacheDir.set globalCaches.dir('mc-maven/cache').map(it.problems.ensureDirectory())
             it.jdkCacheDir.set globalCaches.dir('mc-maven/cache/jdks').map(it.problems.ensureDirectory())
@@ -62,7 +60,7 @@ abstract class MinecraftMavenExec extends JavaExec {
      * @param classpath The classpath containing the Minecraft Mavenizer.
      */
     @Inject
-    MinecraftMavenExec(Problems problems) {
+    SyncMinecraftMaven(Problems problems) {
         this.problems = new ForgeGradleProblems(problems, this.providerFactory)
 
         this.mainClass.convention(Constants.MCMAVEN_MAIN)

…/minecraftforge/gradle/DefaultTools.java …ovy/net/minecraftforge/gradle/Tools.javasrc/main/groovy/net/minecraftforge/gradle/DefaultTools.java renamed to src/main/groovy/net/minecraftforge/gradle/Tools.java src/main/groovy/net/minecraftforge/gradle/DefaultTools.java renamed to src/main/groovy/net/minecraftforge/gradle/Tools.java

@@ -17,29 +17,21 @@
 import org.gradle.api.tasks.InputFile;
 import org.gradle.api.tasks.PathSensitive;
 import org.gradle.api.tasks.PathSensitivity;
-import org.jetbrains.annotations.Nullable;
-import org.jetbrains.annotations.UnknownNullability;
 
 import javax.inject.Inject;
 import java.io.File;
 import java.io.IOException;
-import java.util.Objects;
-import java.util.concurrent.Callable;
-import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.Future;
 
 import static net.minecraftforge.gradle.ForgeGradlePlugin.LOGGER;
 
-enum DefaultTools {
+enum Tools {
     MINECRAFT_MAVEN("minecraft-maven-" + Constants.MCMAVEN_VERSION + ".jar", Constants.MCMAVEN_DL_URL),
     SLIME_LAUNCHER("slime-launcher-" + Constants.SL_VERSION + ".jar", Constants.SL_DL_URL);
 
     private final String fileName;
     private final String downloadUrl;
 
-    private static @UnknownNullability DirectoryProperty caches;
-
-    DefaultTools(String fileName, String downloadUrl) {
+    Tools(String fileName, String downloadUrl) {
         this.fileName = fileName;
         this.downloadUrl = downloadUrl;
     }