Gradle 9, independence from AT plugin, major update to DSL

This major update to the ForgeGradle 7 Beta introduces the Gradle 9
requirement and is now completely built on Java, instead of being a
Java/Groovy mixture. There are two major changes beta testers should be
aware of.

First, the `net.minecraftforge.accesstransformers` plugin *must be
applied* before ForgeGradle in order to use AccessTransformers.
Additionally, ATs must be declared within the Minecraft dependency
itself, not within the Minecraft extension block.
```groovy
dependencies {
    implementation minecraft.dep(libs.forge) {
        accessTransformer =
file('src/main/resources/META-INF/accesstransformer.cfg')
    }
}
```
Additionally, mappings can be declared either within the Minecraft
extension or in the Minecraft dependency, with priority given to the
latter.

Second, this update now includes **very experimental** support for
drop-in replacing the tools used by ForgeGradle, which are currently the
Minecraft Mavenizer and Slime Launcher. Things could break and the
implementation is very ugly, but will be stabilized in due time. Also,
there is currently no IDE linting supported (because Gradle sucks).
```groovy
fgtools {
    mavenizer {
        classpath = 'me.jonathing:mavenizer:1.0.0'
    }
}
```
There is currently no other documentation on this and should be used at
your own risk if you want to test custom versions of the mavenizer and
launcher. Everything you need will be found in
`net.minecraftforge.gradle.ToolsExtension` and
`net.minecraftforge.gradle.ToolsDefinition`.

Author: Jonathing

build.gradle

@@ -1,29 +1,30 @@
-//import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+import com.github.jengelman.gradle.plugins.shadow.ShadowJavaPlugin
 import org.gradle.api.attributes.plugin.GradlePluginApiVersion
 
-// TODO [Jonathan][ForgeGradle7][Publishing] Re-enable the shadow jar once the AT Plugin dependency is figured out
-
 plugins {
     id 'java-gradle-plugin'
-    id 'groovy'
     id 'idea'
+    id 'eclipse'
     id 'maven-publish'
+    id 'io.freefair.javadoc-links'
+    id 'net.minecraftforge.gradleutils'
+    alias libs.plugins.gitversion
+    alias libs.plugins.changelog
     alias libs.plugins.licenser
-    alias libs.plugins.gradleutils
-    alias libs.plugins.javadoc.links
-    //alias libs.plugins.shadow
+    alias libs.plugins.plugin.publish
+    alias libs.plugins.shadow
 }
 
 final projectDisplayName = 'ForgeGradle'
-final projectArtifactId = base.archivesName = 'forgegradle'
 description = "Forge's Gradle plugin for Mod development"
+base.archivesName = 'forgegradle'
 group = 'net.minecraftforge'
 version = gitversion.tagOffset
 
 println "Version: $version"
 
 java {
-    // Gradle 9 will require Java 17
     toolchain.languageVersion = JavaLanguageVersion.of 17
     withSourcesJar()
     withJavadocJar()
@@ -38,74 +39,63 @@ configurations {
         }
     }
 
-    applyGradleVersionAttribute(apiElements)
-    applyGradleVersionAttribute(runtimeElements)
-    //applyGradleVersionAttribute(shadowRuntimeElements)
+    named(JavaPlugin.RUNTIME_ELEMENTS_CONFIGURATION_NAME, applyGradleVersionAttribute)
+    named(ShadowJavaPlugin.SHADOW_RUNTIME_ELEMENTS_CONFIGURATION_NAME, applyGradleVersionAttribute)
 }
 
 dependencies {
+    // Static Analysis
+    compileOnly libs.nulls
+
     // Gradle API
     compileOnly libs.gradle
-    compileOnly libs.nulls
+
+    // GradleUtils Shared Base
+    implementation libs.gradleutils.shared
 
     // AccessTransformers
-    runtimeOnly libs.accesstransformers.plugin
-    compileOnlyApi libs.accesstransformers.binary
+    compileOnlyApi libs.accesstransformers.gradle
 
     // Utils
     implementation libs.bundles.utils
 }
 
-/*
 // Removes local Gradle API from compileOnly. This is a workaround for bugged plugins.
-// TODO [GradleUtils][GradleAPI] Remove this once they are fixed.
 // Publish Plugin: https://github.com/gradle/plugin-portal-requests/issues/260
 // Shadow:         https://github.com/GradleUp/shadow/pull/1422
 afterEvaluate { project ->
     project.configurations.named(JavaPlugin.COMPILE_ONLY_CONFIGURATION_NAME) { compileOnly ->
-        compileOnly.dependencies.remove project.dependencies.gradleApi()
+        compileOnly.dependencies.remove(project.dependencies.gradleApi())
     }
 }
- */
 
 license {
     header = rootProject.file('LICENSE-header.txt')
     newLine = false
     exclude '**/*.properties'
 }
 
-/*
 tasks.named('jar', Jar) {
     archiveClassifier = 'thin'
 }
 
 tasks.named('shadowJar', ShadowJar) {
-    enableRelocation = true
+    enableAutoRelocation = true
     archiveClassifier = null
     relocationPrefix = 'net.minecraftforge.gradle.shadow'
-
-    dependencies {
-        libs.bundles.accesstransformers.get().collect { exclude dependency(it) }
-    }
-}
- */
-
-tasks.withType(GroovyCompile).configureEach {
-    groovyOptions.optimizationOptions.indy = true
 }
 
 tasks.withType(Javadoc).configureEach {
-    javadocTool = javaToolchains.javadocToolFor { languageVersion = JavaLanguageVersion.of 24 }
+    javadocTool = javaToolchains.javadocToolFor { languageVersion = JavaLanguageVersion.of(24) }
 
     options { StandardJavadocDocletOptions options ->
         options.windowTitle = projectDisplayName + project.version
-        options.tags 'apiNote:a:API Note:', 'implNote:a:Implementation Note:'
+        options.tags 'apiNote:a:API Note:', 'implNote:a:Implementation Note:', 'implSpec:a:Implementation Requirements:'
     }
 }
 
 changelog {
     fromBase()
-    publishAll = false
 }
 
 gradlePlugin {
@@ -117,26 +107,24 @@ gradlePlugin {
         implementationClass = 'net.minecraftforge.gradle.ForgeGradlePlugin'
         displayName = projectDisplayName
         description = project.description
+        tags = ['minecraftforge', 'minecraft']
     }
 }
 
-/*
-// Allows the thin jar to be published, but won't be considered as the java-runtime variant in the module
-// This forces Gradle to use the fat jar when applying the plugin
-(components.java as AdhocComponentWithVariants).withVariantsFromConfiguration(configurations.runtimeElements) {
-    skip()
-}
- */
-
 publishing {
+    repositories {
+        maven gradleutils.publishingForgeMaven
+    }
+
     publications.register('pluginMaven', MavenPublication) {
-        artifactId = projectArtifactId
+        changelog.publish(it)
+        gradleutils.promote(it)
 
         pom { pom ->
             name = projectDisplayName
             description = project.description
 
-            gradleutils.pom.setGitHubDetails pom
+            gradleutils.pom.addRemoteDetails(pom)
 
             licenses {
                 license gradleutils.pom.licenses.LGPLv2_1
@@ -147,10 +135,7 @@ publishing {
             }
         }
     }
-
-    repositories {
-        maven gradleutils.publishingForgeMaven
-    }
 }
 
 idea.module { downloadSources = downloadJavadoc = true }
+eclipse.classpath { downloadSources = downloadJavadoc = true }

gradle.properties

@@ -2,10 +2,8 @@ org.gradle.caching=true
 org.gradle.parallel=true
 org.gradle.configureondemand=true
 
-# TODO [GradleUtils][Gradle9] Re-enable config cache in Gradle 9
-# Configuration Cache causes issues with plugin publishing.
-# Do continue to make our Gradle plugins (GU, FG7, etc.) support it though.
-#org.gradle.configuration-cache=true
-#org.gradle.configuration-cache.parallel=true
+org.gradle.configuration-cache=true
+org.gradle.configuration-cache.parallel=true
+org.gradle.configuration-cache.problems=warn
 
 systemProp.org.gradle.unsafe.suppress-gradle-api=true

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

settings.gradle

@@ -1,39 +1,45 @@
 plugins {
-    id 'org.gradle.toolchains.foojay-resolver-convention' version '0.10.0'
+    id 'org.gradle.toolchains.foojay-resolver-convention' version '1.0.0' // https://plugins.gradle.org/plugin/org.gradle.toolchains.foojay-resolver-convention
+
+    // NOTE: We need to load this into the classpath before GradleUtils for the service to load correctly
+    id 'io.freefair.javadoc-links' version '8.14' apply false // https://plugins.gradle.org/plugin/io.freefair.javadoc-links
+
+    id 'net.minecraftforge.gradleutils' version '3.2.5' // https://plugins.gradle.org/plugin/net.minecraftforge.gradleutils
 }
 
 rootProject.name = 'forgegradle'
 
 dependencyResolutionManagement {
     repositories {
-        maven { url = 'https://maven.minecraftforge.net/' }
-        maven { url = 'https://maven.moddinglegacy.com/maven' } // Gradle API
-        mavenCentral()
         //mavenLocal()
+        mavenCentral()
+        maven gradleutils.forgeMaven
+        maven { url = 'https://maven.moddinglegacy.com/maven' } // Gradle API
     }
 
     //@formatter:off
     versionCatalogs.register('libs') {
-        plugin 'licenser',       'net.minecraftforge.licenser'    version '1.2.0'        // https://plugins.gradle.org/plugin/net.minecraftforge.licenser
-        plugin 'gradleutils',    'net.minecraftforge.gradleutils' version '2.6.0'        // https://plugins.gradle.org/plugin/net.minecraftforge.gradleutils
-        plugin 'javadoc-links',  'io.freefair.javadoc-links'      version '8.13.1'       // https://plugins.gradle.org/plugin/io.freefair.javadoc-links
-        plugin 'plugin-publish', 'com.gradle.plugin-publish'      version '1.3.1'        // https://plugins.gradle.org/plugin/com.gradle.plugin-publish
-        plugin 'shadow',         'com.gradleup.shadow'            version '9.0.0-beta15' // https://plugins.gradle.org/plugin/com.gradleup.shadow
+        plugin 'licenser',       'net.minecraftforge.licenser'   version '1.2.0' // https://plugins.gradle.org/plugin/net.minecraftforge.licenser
+        plugin 'gitversion',     'net.minecraftforge.gitversion' version '3.0.3' // https://plugins.gradle.org/plugin/net.minecraftforge.changelog
+        plugin 'changelog',      'net.minecraftforge.changelog'  version '3.0.3' // https://plugins.gradle.org/plugin/net.minecraftforge.changelog
+        plugin 'plugin-publish', 'com.gradle.plugin-publish'     version '1.3.1' // https://plugins.gradle.org/plugin/com.gradle.plugin-publish
+        plugin 'shadow',         'com.gradleup.shadow'           version '9.0.2' // https://plugins.gradle.org/plugin/com.gradleup.shadow
+
+        // Static Analysis
+        library 'nulls', 'org.jetbrains', 'annotations' version '26.0.2'
 
         // Gradle API
-        // TODO [ForgeGradle][FG7][Gradle Api] REMOVE once Gradle publish their own API artifacts
-        // Original:  https://github.com/remal-gradle-api/packages/packages/760197
-        // Mirror:    https://maven.moddinglegacy.com/#browse/browse:maven-public:name%2Fremal%2Fgradle-api%2Fgradle-api%2F8.14.1
-        version 'gradle', '8.14.1'
+        // Original: https://github.com/remal-gradle-api/packages/packages/760197?version=9.0.0
+        // Mirror:   https://repos.moddinglegacy.com/#/modding-legacy/name/remal/gradle-api/gradle-api/9.0.0
+        version 'gradle', '9.0.0'
         library 'gradle', 'name.remal.gradle-api', 'gradle-api'  versionRef 'gradle'
-        library 'nulls',  'org.jetbrains',         'annotations' version    '26.0.2'
+
+        // GradleUtils Shared Base
+        library 'gradleutils-shared', 'net.minecraftforge', 'gradleutils-shared' version '3.2.5'
 
         // AccessTransformers Gradle Plugin
         // https://plugins.gradle.org/plugin/net.minecraftforge.accesstransformers
-        version 'accesstransformers', '1.0.1'
-        library 'accesstransformers-plugin', 'net.minecraftforge.accesstransformers', 'net.minecraftforge.accesstransformers.gradle.plugin' versionRef 'accesstransformers'
-        library 'accesstransformers-binary', 'net.minecraftforge', 'accesstransformers-gradle' versionRef 'accesstransformers'
-        bundle 'accesstransformers', ['accesstransformers-plugin', 'accesstransformers-binary']
+        library 'accesstransformers-gradle', 'net.minecraftforge.accesstransformers', 'net.minecraftforge.accesstransformers.gradle.plugin' version '3.0.0'
 
         library 'utils-data',     'net.minecraftforge', 'json-data-utils' version '0.2.1' // https://files.minecraftforge.net/net/minecraftforge/json-data-utils/index.html
         library 'utils-hash',     'net.minecraftforge', 'hash-utils'      version '0.1.9' // https://files.minecraftforge.net/net/minecraftforge/hash-utils/index.html