Add known inherited properties for ToolExecBase

These inherited properties can also be accessed using `SharedUtil#getForkProperties`. These properties are a combination of known defaults and my best guesses at properties that mussed be passed down to forked JVMs. Gradle, by default (and probably for good reason), does not pass down the Daemon JVM's system properties.

This fixes issues with declared proxy settings used by Gradle.

Author: Jonathing

gradleutils-shared/src/main/java/net/minecraftforge/gradleutils/shared/JavaForkProperties.java

@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) Forge Development LLC and contributors
+ * SPDX-License-Identifier: LGPL-2.1-only
+ */
+package net.minecraftforge.gradleutils.shared;
+
+import org.gradle.api.provider.ValueSource;
+import org.gradle.api.provider.ValueSourceParameters;
+import org.jspecify.annotations.Nullable;
+
+import javax.inject.Inject;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/// Contains best-guesses at JVM properties that need to be passed into forked JVMs. This is mostly for network access
+/// and proxies.
+///
+/// @see jdk.internal.util.SystemProps#initProperties()
+/// @see <a
+///  href="https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/doc-files/net-properties.html">JRE
+/// Networking Properties</a>
+@SuppressWarnings("JavadocReference")
+abstract class JavaForkProperties implements ValueSource<Map<String, String>, ValueSourceParameters.None> {
+    private static final List<String> CONTAINS = List.of(
+        "socksProxyHost",
+        "socksProxyPort",
+        "socksProxyVersion",
+        "socksNonProxyHosts"
+    );
+
+    private static final List<String> STARTS_WITH = List.of(
+        "http.",
+        "https.",
+        "ftp.",
+        "java.net.",
+        "javax.net.ssl.",
+        "jdk.tls."
+    );
+
+    private static boolean test(String key) {
+        if (CONTAINS.contains(key))
+            return true;
+
+        for (var prefix : STARTS_WITH) {
+            if (key.startsWith(prefix))
+                return true;
+        }
+
+        return false;
+    }
+
+    @Inject
+    public JavaForkProperties() { }
+
+    @Override
+    public @Nullable Map<String, String> obtain() {
+        var systemProperties = System.getProperties();
+        var forkProperties = new HashMap<String, String>(systemProperties.size());
+
+        for (var property : systemProperties.entrySet()) {
+            var key = property.getKey().toString();
+            var value = property.getValue().toString();
+            if (!test(key)) continue;
+
+            forkProperties.put(key, value);
+        }
+
+        return forkProperties;
+    }
+}

gradleutils-shared/src/main/java/net/minecraftforge/gradleutils/shared/SharedUtil.java

@@ -10,7 +10,6 @@
 import groovy.transform.stc.FirstParam;
 import kotlin.jvm.functions.Function0;
 import org.codehaus.groovy.runtime.DefaultGroovyMethods;
-import org.codehaus.groovy.runtime.InvokerHelper;
 import org.gradle.TaskExecutionRequest;
 import org.gradle.api.Action;
 import org.gradle.api.DomainObjectCollection;
@@ -49,6 +48,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
 import java.util.concurrent.Callable;
@@ -175,6 +175,10 @@ static abstract class ProjectServiceWrapper {
         @Inject
         public ProjectServiceWrapper() { }
     }
+
+    public static Provider<Map<String, String>> getForkProperties(ProviderFactory providers) {
+        return providers.of(JavaForkProperties.class, spec -> { });
+    }
     //endregion
 
     //region Project Eval
@@ -557,7 +561,7 @@ public static <T> Provider<T> asProvider(ProviderFactory providers, Object value
     }
     //endregion
 
-    //region Properties
+    //region Gradle Properties
 
     /**
      * Makes a returning-self closure that finalizes a given property using {@link #finalizeProperty(Property)}.

gradleutils-shared/src/main/java/net/minecraftforge/gradleutils/shared/ToolExecBase.java

@@ -22,6 +22,7 @@
 import org.gradle.api.model.ObjectFactory;
 import org.gradle.api.plugins.JavaPluginExtension;
 import org.gradle.api.provider.ListProperty;
+import org.gradle.api.provider.MapProperty;
 import org.gradle.api.provider.Property;
 import org.gradle.api.provider.Provider;
 import org.gradle.api.provider.ProviderConvertible;
@@ -91,6 +92,8 @@ public abstract class ToolExecBase<P extends EnhancedProblems> extends DefaultTa
     public abstract @Input @Optional Property<Boolean> getPreferToolchainJvm();
 
     public abstract @Internal DirectoryProperty getWorkingDir();
+
+    protected abstract @Internal MapProperty<String, String> getForkProperties();
     //endregion
 
     //region Logging
@@ -141,6 +144,8 @@ protected ToolExecBase(Tool tool) {
             this.getToolchainLauncher().set(getJavaToolchains().launcherFor(getProject().getExtensions().getByType(JavaPluginExtension.class).getToolchain()))
         );
 
+        this.getForkProperties().set(SharedUtil.getForkProperties(getProviders()));
+
         this.getStandardOutputLogLevel().convention(LogLevel.LIFECYCLE);
         this.getStandardErrorLogLevel().convention(LogLevel.ERROR);
 
@@ -224,6 +229,10 @@ protected ExecResult exec() throws IOException {
         var args = DefaultGroovyMethods.collect(this.args, Closures.<Provider<String>, String>function(Provider::get));
         var jvmArgs = DefaultGroovyMethods.collect(this.jvmArgs, Closures.<Provider<String>, String>function(Provider::get));
 
+        for (var property : this.getForkProperties().get().entrySet()) {
+            this.systemProperties.putIfAbsent(property.getKey(), property.getValue());
+        }
+
         var stdOutLevel = this.getStandardOutputLogLevel().get();
         var stdErrLevel = this.getStandardErrorLogLevel().get();
 
@@ -266,14 +275,27 @@ protected ExecResult exec() throws IOException {
                     }
                 ));
 
-                log.println("Java Launcher: " + spec.getExecutable());
-                log.println("Working directory: " + spec.getWorkingDir().getAbsolutePath());
-                log.println("Main class: " + spec.getMainClass().get());
-                log.println("Arguments: '" + String.join(", ", spec.getArgs()) + '\'');
-                log.println("JVM Arguments: '" + String.join(", ", spec.getAllJvmArgs()) + '\'');
+                log.print("Java Launcher: ");
+                log.println(spec.getExecutable());
+                log.print("Working directory: ");
+                log.println(spec.getWorkingDir().getAbsolutePath());
+                log.print("Main class: ");
+                log.println(spec.getMainClass().get());
+                log.println("Arguments:");
+                for (var s : spec.getArgs()) {
+                    log.print("  ");
+                    log.println(s);
+                }
+                log.println("JVM Arguments:");
+                for (var s : spec.getAllJvmArgs()) {
+                    log.print("  ");
+                    log.println(s);
+                }
                 log.println("Classpath:");
-                for (var f : getClasspath())
-                    log.println(" - " + f.getAbsolutePath());
+                for (var f : getClasspath()) {
+                    log.print("  ");
+                    log.println(f.getAbsolutePath());
+                }
                 log.println("====================================");
             });
         }