Consolidate PomUtils#addRemoteDetails

Removes `#addForgeDetails`. Forge organization information is included
if the URL contains "github.com/MinecraftForge/".

Author: Jonathing

settings.gradle

@@ -6,11 +6,10 @@ rootProject.name = 'gradleutils'
 
 dependencyResolutionManagement {
     repositories {
+        //mavenLocal()
+        mavenCentral()
         maven { url = 'https://maven.minecraftforge.net/' }
         maven { url = 'https://maven.moddinglegacy.com' } // Gradle API
-        maven { url = 'https://repo.eclipse.org/content/groups/releases/' }
-        mavenCentral()
-        //mavenLocal()
     }
 
     versionCatalogs.register('libs') {

src/main/groovy/net/minecraftforge/gradleutils/PomUtils.java

@@ -46,14 +46,6 @@ sealed interface Licenses permits PomUtilsInternal.Licenses {
     /// {@linkplain MavenPomDeveloper#getId() ID} and {@linkplain MavenPomDeveloper#getName() name}.
     Map<String, Action<? super MavenPomDeveloper>> developers = PomUtilsInternal.makeDevelopers();
 
-    /// Adds MinecraftForge-specific details to the given POM.
-    ///
-    /// @param pom The POM to add details to
-    @ApiStatus.Internal
-    static void addForgeDetails(MavenPom pom) {
-        PomUtilsInternal.addForgeDetails(pom);
-    }
-
     /// Adds details from the project's remote URL to the given POM.
     ///
     /// @param pom The POM to add details to

src/main/groovy/net/minecraftforge/gradleutils/PomUtilsImpl.groovy

@@ -41,18 +41,4 @@ import javax.inject.Inject
         // Overridden by Git Version Plugin
         throw this.problems.pomUtilsGitVersionMissing()
     }
-
-    @Override
-    void addRemoteDetails(MavenPom pom, String url) {
-        super.addRemoteDetails(pom, url)
-
-        if (url.contains('github.com/MinecraftForge/')) {
-            SharedUtil.ensureAfterEvaluate(this.project) {
-                pom.organization { organization ->
-                    if (organization.name.orNull != Constants.FORGE_ORG_NAME)
-                        this.problems.reportPomUtilsForgeProjWithoutForgeOrg()
-                }
-            }
-        }
-    }
 }

src/main/groovy/net/minecraftforge/gradleutils/PomUtilsInternal.java

@@ -86,13 +86,6 @@ private static Action<? super MavenPomDeveloper> makeDev(String id, String name,
         };
     }
 
-    static void addForgeDetails(MavenPom pom) {
-        pom.organization(organization -> {
-            organization.getName().set(Constants.FORGE_ORG_NAME);
-            organization.getUrl().set(Constants.FORGE_ORG_URL);
-        });
-    }
-
     @Override
     @MustBeInvokedByOverriders
     default void addRemoteDetails(MavenPom pom, String url) {
@@ -119,6 +112,14 @@ default void addRemoteDetails(MavenPom pom, String url) {
             ci.getSystem().set("github");
             ci.getUrl().set(fullURL + "/actions");
         });
+
+        // the rest is Forge-exclusive information
+        if (!strippedUrl.contains("github.com/MinecraftForge/")) return;
+
+        pom.organization(organization -> {
+            organization.getName().set(Constants.FORGE_ORG_NAME);
+            organization.getUrl().set(Constants.FORGE_ORG_URL);
+        });
     }
 
     private static String stripProtocol(String url) {

src/main/groovy/net/minecraftforge/gradleutils/package-info.java

@@ -7,7 +7,6 @@
 /// [net.minecraftforge.gradleutils.PomUtils] that help eliminate duplicate code within buildscripts and allow us to
 /// change any default values, such as Maven URLs, in case things change unexpectedly.
 ///
-/// If you are a non-Forge consumer, it is recommended not to use any Forge-specific APIs, including methods such as
-/// [net.minecraftforge.gradleutils.PomUtils#addForgeDetails(org.gradle.api.publish.maven.MavenPom)] and the
+/// If you are a non-Forge consumer, it is recommended not to use any Forge-specific APIs such as the
 /// [net.minecraftforge.gradleutils.GenerateActionsWorkflow] task.
 package net.minecraftforge.gradleutils;