Fixed issues with Gradle property decoration

Any public or protected method that has the getter naming convention
(getProperty) is decorated by Gradle when the class is instantiated. A
lot of things in the shared package are largely internal and do not need
modifications from Gradle, so they have been renamed without the "get"
keyword to avoid that. For non-tasks, the `@Internal` annotation has no
effect.

Author: Jonathing

src/main/groovy/net/minecraftforge/gradleutils/GradleUtilsExtensionImpl.groovy

@@ -30,7 +30,8 @@ import static net.minecraftforge.gradleutils.GradleUtilsPlugin.LOGGER
 
         final PomUtils pom
 
-        private ForProjectImpl(Project project) {
+        @Inject
+        ForProjectImpl(Project project) {
             this.project = project
 
             this.pom = this.objects.newInstance(PomUtilsImpl, project)

src/main/groovy/net/minecraftforge/gradleutils/shared/EnhancedPlugin.java

@@ -12,6 +12,7 @@
 import org.gradle.api.model.ObjectFactory;
 import org.gradle.api.provider.Provider;
 import org.gradle.api.provider.ProviderFactory;
+import org.gradle.api.tasks.Internal;
 import org.jetbrains.annotations.ApiStatus;
 
 import javax.inject.Inject;
@@ -44,7 +45,7 @@ public abstract class EnhancedPlugin<T> implements Plugin<T> {
 
     /// This constructor must be called by all subclasses using a public constructor annotated with [Inject]. The name
     /// and display name passed in are used in a minimal instance of [EnhancedProblems], which is used to set up the
-    /// plugin's [global][#getGlobalCaches()] and [local][#getLocalCaches()] caches. Additionally, the name is used to
+    /// plugin's [global][#globalCaches()] and [local][#localCaches()] caches. Additionally, the name is used to
     /// create the cache folders (`minecraftforge/name`).
     ///
     /// @param name        The name for this plugin (must be machine-friendly)
@@ -70,11 +71,11 @@ public final void apply(T target) {
     public abstract void setup(T target);
 
     /// Gets the target for this plugin. This will throw an exception if this is called before application (i.e. through
-    /// early usage of [#getGlobalCaches()]).
+    /// early usage of [#globalCaches()]).
     ///
     /// @return The plugin target
     /// @throws RuntimeException If this plugin is not yet applied
-    protected final T getTarget() {
+    private T getTarget() {
         try {
             return Objects.requireNonNull(this.target);
         } catch (Exception e) {
@@ -96,7 +97,7 @@ final EnhancedProblems getProblemsInternal() {
     /// @return A provider for the tool file
     @SuppressWarnings("deprecation") // deprecation intentional, please use this method
     public Provider<File> getTool(Tool tool) {
-        return tool.get(this.getGlobalCaches(), this.getProviders());
+        return tool.get(this.globalCaches(), this.getProviders());
     }
 
 
@@ -112,7 +113,7 @@ public Provider<File> getTool(Tool tool) {
     /// @return The global caches
     /// @throws RuntimeException If this plugin cannot access global caches (i.e. the target is not [Project] or
     ///                          [org.gradle.api.initialization.Settings])
-    public final DirectoryProperty getGlobalCaches() {
+    public final DirectoryProperty globalCaches() {
         return this.globalCaches.get();
     }
 
@@ -142,7 +143,7 @@ private DirectoryProperty makeGlobalCaches() {
     /// @return The global caches
     /// @throws RuntimeException If this plugin cannot access global caches (i.e. the target is not [Project] or
     ///                          [org.gradle.api.initialization.Settings])
-    public final DirectoryProperty getLocalCaches() {
+    public final DirectoryProperty localCaches() {
         return this.localCaches.get();
     }
 

src/main/groovy/net/minecraftforge/gradleutils/shared/EnhancedProblems.java

@@ -22,6 +22,7 @@
 import org.gradle.api.reflect.TypeOf;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.Nullable;
+import org.jetbrains.annotations.VisibleForTesting;
 
 import javax.inject.Inject;
 import java.io.IOException;
@@ -34,7 +35,7 @@
 
 /// The enhanced problems contain several base helper members to help reduce duplicate code between Gradle plugins.
 @ApiStatus.OverrideOnly
-public abstract class EnhancedProblems implements Problems {
+public abstract class EnhancedProblems implements Problems, Predicate<String> {
     /// The common message to send in [ProblemSpec#solution(String)] when reporting problems.
     protected static final String HELP_MESSAGE = "Consult the documentation or ask for help on the Forge Forums, GitHub, or Discord server.";
 
@@ -87,7 +88,7 @@ protected final ProblemId id(String name, String displayName) {
     ///
     /// @param property The property to test
     /// @return If the property exists and is `true`
-    protected final boolean hasProperty(String property) {
+    public final boolean test(String property) {
         return this.properties.test(property);
     }
 

src/main/groovy/net/minecraftforge/gradleutils/shared/EnhancedTask.java

@@ -18,30 +18,26 @@ public interface EnhancedTask<T extends EnhancedPlugin<? super Project>> extends
     /// The enhanced plugin type for this task.
     ///
     /// @return The plugin type
-    @Internal
-    Class<T> getPluginType();
+    @Internal Class<T> getPluginType();
 
     /// The enhanced plugin associated with this task.
     ///
     /// @return The plugin
-    @Internal
-    default T getPlugin() {
+    default @Internal T getPlugin() {
         return this.getProject().getPlugins().getPlugin(this.getPluginType());
     }
 
     /// The default output directory to use for this task if it outputs a directory.
     ///
     /// @return A provider for the directory
-    @Internal
-    default Provider<Directory> getDefaultOutputDirectory() {
-        return this.getPlugin().getLocalCaches().dir(this.getName()).map(this.getPlugin().getProblemsInternal().ensureFileLocation());
+    default @Internal Provider<Directory> getDefaultOutputDirectory() {
+        return this.getPlugin().localCaches().dir(this.getName()).map(this.getPlugin().getProblemsInternal().ensureFileLocation());
     }
 
     /// The default output file to use for this task if it outputs a file. Uses the `.jar` extension.
     ///
     /// @return A provider for the file
-    @Internal
-    default Provider<RegularFile> getDefaultOutputFile() {
+    default @Internal Provider<RegularFile> getDefaultOutputFile() {
         return this.getDefaultOutputFile("jar");
     }
 
@@ -50,6 +46,6 @@ default Provider<RegularFile> getDefaultOutputFile() {
     /// @param ext The extension to use for the file
     /// @return A provider for the file
     default Provider<RegularFile> getDefaultOutputFile(String ext) {
-        return this.getPlugin().getLocalCaches().file("%s/output.%s".formatted(this.getName(), ext)).map(this.getPlugin().getProblemsInternal().ensureFileLocation());
+        return this.getPlugin().localCaches().file("%s/output.%s".formatted(this.getName(), ext)).map(this.getPlugin().getProblemsInternal().ensureFileLocation());
     }
 }

src/main/groovy/net/minecraftforge/gradleutils/shared/ToolExecBase.java

@@ -51,7 +51,7 @@ protected ToolExecBase(Class<P> problemsType, Tool tool) {
 
         if (this instanceof EnhancedTask<?> enhancedTask) {
             this.defaultToolDir = this.getObjectFactory().directoryProperty().value(
-                enhancedTask.getPlugin().getGlobalCaches().dir(tool.getName().toLowerCase(Locale.ENGLISH)).map(this.ensureFileLocationInternal())
+                enhancedTask.getPlugin().globalCaches().dir(tool.getName().toLowerCase(Locale.ENGLISH)).map(this.ensureFileLocationInternal())
             );
             this.setClasspath(this.getObjectFactory().fileCollection().from(enhancedTask.getPlugin().getTool(tool)));
         } else {