Skip to content

Commit 0d85386

Browse files
committed
Fix no newline at the end of the file
- Add message which line feed is currently used - Add color to existing messages
1 parent 9567de5 commit 0d85386

File tree

5 files changed

+31
-5
lines changed

5 files changed

+31
-5
lines changed

src/main/java/com/minecrafttas/discombobulator/processor/FilePreprocessor.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void preprocessFile(Path inFile, Path outFile, String version, String ext
6363

6464
public Triple<List<String>, Path, Path> /*<- TODO Change to it's own class*/ preprocessVersions(Path inFile, Map<String, Path> versions, String extension, Path currentDir) throws Exception {
6565

66-
// System.out.println(inFile);
66+
System.out.println(String.format("Preprocessing \033[0;35m%s\033[0;37m\n", inFile.getFileName().toString()));
6767

6868
boolean ignored = fileFilter != null && fileFilter.accept(inFile.toFile());
6969

@@ -85,6 +85,7 @@ public void preprocessFile(Path inFile, Path outFile, String version, String ext
8585
Path outFile = targetSubSourceDir.resolve(relativeInFile);
8686

8787
if (ignored) {
88+
System.out.println(String.format("into version \033[0;36m%s\033[0;37m", versionName));
8889
Files.copy(inFile, outFile, StandardCopyOption.REPLACE_EXISTING);
8990
continue;
9091
}
@@ -99,6 +100,7 @@ public void preprocessFile(Path inFile, Path outFile, String version, String ext
99100
}
100101

101102
preprocessLines(outLines, outFile, versionName, extension);
103+
System.out.println(String.format("into version \033[0;36m%s\033[0;37m", versionName));
102104
}
103105

104106
return out;
@@ -121,7 +123,14 @@ public List<String> preprocessLines(List<String> inLines, Path outFile, String v
121123

122124
// Write file and update last modified date
123125
Files.createDirectories(outFile.getParent());
124-
Files.write(outFile, String.join(LineFeedHelper.newLine(), lines).getBytes());
126+
127+
StringBuilder stringBuilder = new StringBuilder();
128+
String linefeed = LineFeedHelper.newLine();
129+
for (String line : lines) {
130+
stringBuilder.append(line);
131+
stringBuilder.append(linefeed);
132+
}
133+
Files.write(outFile, stringBuilder.toString().getBytes());
125134

126135
return lines;
127136
}

src/main/java/com/minecrafttas/discombobulator/tasks/TaskPreprocessBase.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.minecrafttas.discombobulator.Discombobulator;
1414
import com.minecrafttas.discombobulator.processor.FilePreprocessor;
1515
import com.minecrafttas.discombobulator.utils.BetterFileWalker;
16+
import com.minecrafttas.discombobulator.utils.LineFeedHelper;
1617
import com.minecrafttas.discombobulator.utils.SocketLock;
1718

1819
/**
@@ -44,6 +45,8 @@ public void preprocessBase() {
4445
return;
4546
}
4647

48+
LineFeedHelper.printMessage();
49+
4750
System.out.println("Preprocessing base source...\n");
4851

4952
Path baseSourceDir = baseProjectDir.resolve("src");

src/main/java/com/minecrafttas/discombobulator/tasks/TaskPreprocessWatch2.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.minecrafttas.discombobulator.Discombobulator;
2020
import com.minecrafttas.discombobulator.utils.FileWatcher;
21+
import com.minecrafttas.discombobulator.utils.LineFeedHelper;
2122
import com.minecrafttas.discombobulator.utils.PathLock;
2223
import com.minecrafttas.discombobulator.utils.SafeFileOperations;
2324
import com.minecrafttas.discombobulator.utils.SocketLock;
@@ -52,6 +53,8 @@ public void preprocessWatch() {
5253
Path baseProjectDir = this.getProject().getProjectDir().toPath();
5354
baseSourceDir = baseProjectDir.resolve("src");
5455

56+
LineFeedHelper.printMessage();
57+
5558
Map<String, Path> versionsConfig;
5659
try {
5760
versionsConfig = Discombobulator.getVersionPairs(baseProjectDir);
@@ -89,7 +92,7 @@ public void preprocessWatch() {
8992
SafeFileOperations.write(outFile, outLines, StandardOpenOption.CREATE, StandardOpenOption.WRITE);
9093
currentFileUpdater = null;
9194

92-
System.out.println(String.format("Processed the recently edited file %s\n", outFile.getFileName()));
95+
System.out.println(String.format("Preprocessed the recently edited file \033[0;35m%s\033[0;37m\n", outFile.getFileName()));
9396
}
9497
}
9598
} catch (IOException e1) {
@@ -191,7 +194,7 @@ private class FileWatcherThread extends Thread {
191194

192195
public FileWatcherThread(FileWatcher watcher, String version) {
193196
super("FileWatcher-" + version);
194-
System.out.println("Started watching " + version);
197+
System.out.println(String.format("Started watching \033[0;32m%s\033[0;37m", version));
195198
this.watcher = watcher;
196199
this.setDaemon(true);
197200
this.start();

src/main/java/com/minecrafttas/discombobulator/utils/LineFeedHelper.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,17 @@
22

33
public class LineFeedHelper {
44

5+
public static void printMessage() {
6+
String property = System.getProperty("line.seperator");
7+
if ("\\n".equals(property) || "\n".equals(property)) {
8+
System.out.println("Preprocessing with line seperator \033[0;32m\\n\033[0;37m\n");
9+
} else if ("\\r\\n".equals(property) || "\r\n".equals(property)) {
10+
System.out.println("Preprocessing with line seperator \033[0;32m\\r\\n\033[0;37m\n");
11+
} else {
12+
System.out.println(String.format("Preprocessing with default line seperator \033[0;32m%s\033[0;37m\nTo change this, add \033[0;33m-Dline.seperator=\"\\n\"\033[0;37m to VM arguments\n", System.lineSeparator().equals("\r\n") ? "\\r\\n" : "\\n"));
13+
}
14+
}
15+
516
public static String newLine() {
617
String out = System.lineSeparator();
718
String property = System.getProperty("line.seperator");

src/main/java/com/minecrafttas/discombobulator/utils/SocketLock.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class SocketLock {
2626
*/
2727
public SocketLock(int port) {
2828
this.port = port;
29-
System.out.println(String.format("Locking Port %s", port));
29+
System.out.println(String.format("Locking Port \033[0;32m%s\033[0;37m\n", port));
3030
try {
3131
this.socket = new ServerSocket();
3232
} catch (IOException e) {

0 commit comments

Comments
 (0)