[VirtualInput] Documentation and method naming fixes

- Fixed documentation in MixinEntityRenderer and renamed mixin methods to better describe the area

Author: ScribbleTAS

src/main/java/com/minecrafttas/tasmod/mixin/events/MixinEntityRenderer.java

@@ -11,12 +11,15 @@
 
 import com.llamalad7.mixinextras.sugar.Share;
 import com.llamalad7.mixinextras.sugar.ref.LocalFloatRef;
+import com.minecrafttas.mctcommon.events.EventListenerRegistry;
 import com.minecrafttas.tasmod.TASmodClient;
+import com.minecrafttas.tasmod.events.EventClient.EventDrawHotbarAlways;
 import com.minecrafttas.tasmod.util.Ducks.SubtickDuck;
 import com.minecrafttas.tasmod.virtual.VirtualInput;
 
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.entity.EntityPlayerSP;
+import net.minecraft.client.gui.ScaledResolution;
 import net.minecraft.client.renderer.EntityRenderer;
 import net.minecraft.client.renderer.GlStateManager;
 
@@ -114,11 +117,18 @@ public void runUpdate(float partialTicks) {
 		Float newPitch = TASmodClient.virtual.CAMERA_ANGLE.getCurrentPitch();
 		Float newYaw = TASmodClient.virtual.CAMERA_ANGLE.getCurrentYaw();
 
-		// If the pitch or yaw is null (usually on initialize or when the player joins the world),
-		// set nextCameraAngle to the current absolute camera coordinates.
-		// This ensures that the camera position is loaded correctly
+		/* 
+		 * If the pitch or yaw is null, 
+		 * usually on initialize or when the player joins the world),
+		 * do not update the camera angle.
+		 * 
+		 * This is called during the loading screen for 2 game loops,
+		 * at which point the player is not initialized, 
+		 * hence we do not have the correct camera angle yet.
+		 * 
+		 * The angle is instead initialized in LoadingScreenHandler#onDoneLoadingPlayer.
+		 */
 		if (newPitch == null || newYaw == null) {
-//			TASmod.LOGGER.warn("Pitch and Yaw is null! This is not good!");
 //			TASmodClient.virtual.CAMERA_ANGLE.setCamera(prevPitch, prevYaw);
 			return;
 		}
@@ -139,7 +149,7 @@ public void runUpdate(float partialTicks) {
 	 * @return 0f for disabeling this method
 	 */
 	@ModifyArg(method = "orientCamera", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GlStateManager;rotate(FFFF)V", ordinal = 8), index = 0)
-	public float redirect_orientCameraPitch(float pitch, @Share("pitch") LocalFloatRef sharedPitch) {
+	public float playback_orientCameraPitch(float pitch, @Share("pitch") LocalFloatRef sharedPitch) {
 		sharedPitch.set(pitch);
 		return 0f;
 	}
@@ -151,7 +161,7 @@ public float redirect_orientCameraPitch(float pitch, @Share("pitch") LocalFloatR
 	 * @return The redirected yaw
 	 */
 	@ModifyArg(method = "orientCamera", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GlStateManager;rotate(FFFF)V", ordinal = 9), index = 0)
-	public float redirect_orientCameraYawAnimal(float yawAnimal, @Share("pitch") LocalFloatRef sharedPitch) {
+	public float playback_orientCameraYawAnimal(float yawAnimal, @Share("pitch") LocalFloatRef sharedPitch) {
 		return redirectCam(sharedPitch.get(), yawAnimal);
 	}
 
@@ -162,10 +172,27 @@ public float redirect_orientCameraYawAnimal(float yawAnimal, @Share("pitch") Loc
 	 * @return The redirected yaw
 	 */
 	@ModifyArg(method = "orientCamera", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GlStateManager;rotate(FFFF)V", ordinal = 10), index = 0)
-	public float redirect_orientCameraYaw(float yaw, @Share("pitch") LocalFloatRef sharedPitch) {
+	public float playback_orientCameraYaw(float yaw, @Share("pitch") LocalFloatRef sharedPitch) {
 		return redirectCam(sharedPitch.get(), yaw);
 	}
 
+	/**
+	 * Updates the game overlay and adds an event
+	 * @param ci CallBackInfo
+	 */
+	@Inject(method = "updateCameraAndRender", at = @At(value = "INVOKE", target = "Lnet/minecraft/profiler/Profiler;endStartSection(Ljava/lang/String;)V"))
+	public void playback_updateOverlay(CallbackInfo ci) {
+		ScaledResolution scaledResolution = new ScaledResolution(this.mc);
+		GlStateManager.clear(256);
+		GlStateManager.matrixMode(5889);
+		GlStateManager.loadIdentity();
+		GlStateManager.ortho(0.0, scaledResolution.getScaledWidth_double(), scaledResolution.getScaledHeight_double(), 0.0, 1000.0, 3000.0);
+		GlStateManager.matrixMode(5888);
+		GlStateManager.loadIdentity();
+		GlStateManager.translate(0.0F, 0.0F, -2000.0F);
+		EventListenerRegistry.fireEvent(EventDrawHotbarAlways.class);
+	}
+
 	/**
 	 * Turns the camera via GLStateManager
 	 * @param pitch The pi

src/main/java/com/minecrafttas/tasmod/mixin/playbackhooks/MixinEntityRenderer.java

@@ -41,7 +41,6 @@
 
 		// Events
 		"events.MixinGuiIngame",
-		"events.MixinEntityRenderer",
 		"events.MixinNetHandlerPlayClient",
 
 		"clientcommands.MixinEntityPlayerSP",