better linter and more unprofiled tests

Author: goenning

.eslintrc.json

@@ -8,6 +8,7 @@
   "rules": {
     "semi": [2, "always"],
     "no-unused-vars": ["error", { "vars": "all", "args": "none" }],
-    "quotes": ["error", "single", { "avoidEscape": true } ]
+    "quotes": ["error", "single", { "avoidEscape": true } ],
+    "space-before-function-paren": ["error", "never"]
   }
 }

lib/miniprofiler.js

@@ -73,7 +73,7 @@ function static(reqPath, res) {
 	fs.readFile(path.join(includesDir, reqPath), function(err, data) {
 		if (err) {
 			debug(err);
-			res.setHeader('Content-Type', 'text/html');
+			res.setHeader('Content-Type', 'text/plain');
 			res.writeHead(404);
 			res.end('Resource unavailable.');
 			return;
@@ -92,7 +92,7 @@ function results(req, res) {
 		var data = storage(id);
     if (!data) {
 			debug(`Id '${id}' not found.`);
-			res.setHeader('Content-Type', 'text/html');
+			res.setHeader('Content-Type', 'text/plain');
 			res.writeHead(404);
 			res.end(`Id '${id}' not found.`);
       return;
@@ -155,7 +155,9 @@ function middleware(f) {
 
 		if(req.path.startsWith(resourcePath)) {
 			if (!enabled) {
-				res.send(404);
+        res.setHeader('Content-Type', 'text/plain');
+  			res.writeHead(404);
+  			res.end(`MiniProfiler is disabled.`);
 				return;
 			}
 

package.json

@@ -5,7 +5,9 @@
   "main": "lib/miniprofiler.js",
   "scripts": {
     "lint": "eslint .",
-    "test": "istanbul cover node_modules/mocha/bin/_mocha tests/",
+    "test": "mocha tests/",
+    "test:watch": "mocha tests/ --watch",
+    "coverage": "istanbul cover node_modules/mocha/bin/_mocha tests/",
     "example": "node examples/express/server.js"
   },
   "repository": {

tests/assets-test.js

@@ -24,7 +24,7 @@ describe('MiniProfiler Assets Tests', function() {
   it('Unknown file should return 404', function(done) {
     server.get('/mini-profiler-resources/unkown.js', (err, response, body) => {
       expect(response.statusCode).to.be.equal(404);
-      expect(response.headers['content-type']).to.be.equal('text/html');
+      expect(response.headers['content-type']).to.be.equal('text/plain');
       expect(body).to.be.equal('Resource unavailable.');
       done();
     });

tests/share-test.js

@@ -13,7 +13,7 @@ describe('MiniProfiler Share Tests', function() {
 
   var expectNotFoundResponse = (done) => (err, response, body) => {
     expect(response.statusCode).to.be.equal(404);
-    expect(response.headers['content-type']).to.be.equal('text/html');
+    expect(response.headers['content-type']).to.be.equal('text/plain');
     done();
   };
 

tests/unprofiled-test.js

@@ -5,10 +5,28 @@ describe('MiniProfiler Unprofiled Tests', function() {
   before(server.start);
   after(server.stop);
 
-  it('Unprofiled route should not return Profiler ID', function(done) {
+  it('Unprofiled server should not return Profiler ID', function(done) {
     server.get('/', (err, response) => {
       expect(response.headers).to.not.include.keys('x-miniprofiler-ids');
       done();
     });
   });
+
+  var paths = [
+    '/',
+    '/includes.css',
+    '/results',
+    '/results?id=2'
+  ];
+
+  paths.forEach((path) => {
+    it(`Unprofiled server should not find ${path} route`, function(done) {
+      server.get(`/mini-profiler-resources${path}`, (err, response, body) => {
+        expect(response.statusCode).to.be.equal(404);
+        expect(response.headers['content-type']).to.be.equal('text/plain');
+        expect(body).to.be.equal('MiniProfiler is disabled.');
+        done();
+      });
+    });
+  });
 });