share page test

Author: goenning

lib/miniprofiler.js

@@ -89,32 +89,53 @@ function results(req, res) {
 	var proc = function(post) {
 		// todo: store client timings
 		var id = post.id || url.parse(req.url, true).query.id;
-		var s = storage(id);
-		if (post.popup == '1')
-			res.end(s);
-		else {
-			var j = JSON.parse(s);
+		var data = storage(id);
+    if (!data) {
+			debug(`Id '${id}' not found.`);
 			res.setHeader('Content-Type', 'text/html');
-			res.end(includes.share({
-				name: j.Name,
-				duration: j.DurationMilliseconds,
-				path: resourcePath,
-				json: s,
-				includes: include(id),
-				version: version
-			}));
-		}
+			res.writeHead(404);
+			res.end(`Id '${id}' not found.`);
+      return;
+    }
+
+		if (post.popup == '1') {
+      res.setHeader('Content-Type', 'application/json');
+			res.end(data);
+      return;
+    }
+
+		var json = JSON.parse(data);
+		res.setHeader('Content-Type', 'text/html');
+		res.end(includes.share({
+			name: json.Name,
+			duration: json.DurationMilliseconds,
+			path: resourcePath,
+			json: data,
+			includes: include(id),
+			version: version
+		}));
+
 	};
+
+  /*
+
+  https://nodejs.org/api/http.html#http_class_http_clientrequest
+  Request does not have `body` attribute
+  Do we still need this?
+
 	if(req.body) {
 		proc(req.body);
 		return;
 	}
+  */
+
 	var body = '';
 	req.on('data', function(data) {
 		body += data;
 		if (body.length > 1e6)
 			req.connection.destroy();
 	});
+
 	req.on('end', function() {
 		var post = qs.parse(body);
 		proc(post);

package.json

@@ -5,7 +5,8 @@
   "main": "lib/miniprofiler.js",
   "scripts": {
     "lint": "eslint .",
-    "test": "istanbul cover node_modules/mocha/bin/_mocha tests/"
+    "test": "istanbul cover node_modules/mocha/bin/_mocha tests/",
+    "example": "node examples/express/server.js"
   },
   "repository": {
     "type": "git",

tests/static-assets-test.js tests/assets-test.jstests/static-assets-test.js renamed to tests/assets-test.js

@@ -2,7 +2,7 @@ var expect = require('chai').expect;
 var server = require('./server');
 var fs = require('fs');
 
-describe('MiniProfiler Static Assets Tests', function() {
+describe('MiniProfiler Assets Tests', function() {
   before(server.start);
   after(server.stop);
 

tests/basic-test.js

@@ -5,6 +5,13 @@ describe('MiniProfiler Tests', function() {
   before(server.start);
   after(server.stop);
 
+  it('Profiled routes should always return Profiler ID', function(done) {
+    server.get('/', (err, response) => {
+      expect(response.headers).to.include.keys('x-miniprofiler-ids');
+      done();
+    });
+  });
+
   it('Unprofiled route should not return Profiler ID', function(done) {
     server.get('/unprofiled', (err, response) => {
       expect(response.headers).to.not.include.keys('x-miniprofiler-ids');

tests/server/index.js

@@ -1,4 +1,4 @@
-var miniprofiler = require('../lib/miniprofiler.js');
+var miniprofiler = require('../../lib/miniprofiler.js');
 var express = require('express');
 var request = require('request');
 

tests/share-test.js

@@ -0,0 +1,37 @@
+var expect = require('chai').expect;
+var server = require('./server');
+
+describe('MiniProfiler Share Tests', function() {
+  before(server.start);
+  after(server.stop);
+
+  it('Valid profiled id should render share page', function(done) {
+    server.get('/', (err, response) => {
+      var ids = JSON.parse(response.headers['x-miniprofiler-ids']);
+
+      server.get(`/mini-profiler-resources/results?id=${ids[0]}`, (err, response, body) => {
+        expect(response.statusCode).to.be.equal(200);
+        expect(response.headers['content-type']).to.be.equal('text/html');
+        done();
+      });
+
+    });
+  });
+
+  it('Invalid profiled id should render 404', function(done) {
+    server.get(`/mini-profiler-resources/results?id=123`, (err, response, body) => {
+      expect(response.statusCode).to.be.equal(404);
+      expect(response.headers['content-type']).to.be.equal('text/html');
+      done();
+    });
+  });
+
+  it('Invalid profiled id should render 404', function(done) {
+    server.post(`/mini-profiler-resources/results`, { id: 123 }, (err, response, body) => {
+      expect(response.statusCode).to.be.equal(404);
+      expect(response.headers['content-type']).to.be.equal('text/html');
+      done();
+    });
+  });
+
+});