Commit 263f0d8
authored
Add flamegraph path to response headers (#601)
* Add flamegraph path to response headers
The motivation for this is to enable easy access to the flamegraph
when using the async-flamegraph action. Currently, if have a CURL
request that you are wanting to profile, you have to add the
`pp=async-flamegraph` query parameter to the request, then copy the
first ID from the `X-MiniProfiler-Ids` header, then add that ID to the
`/mini-profiler-resources/flamegraph?id=` path in the browser.
This assumes that you know that the current request profile id is the
first one in the `X-MiniProfiler-Ids` header (personally I was not
confident of this until I read the source code) and that you know the
path to the flamegraph endpoint.
I originally added the protocol, host, and port to the path, but I
didn't know if that was guaranteed to be correct in all cases, so I
removed it.
* Add note of X-MiniProfiler-Flamegraph-Path header to README1 parent 9081657 commit 263f0d8
File tree
3 files changed
+10
-3
lines changed- lib
- spec/integration
3 files changed
+10
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
469 | | - | |
| 469 | + | |
470 | 470 | | |
471 | 471 | | |
472 | 472 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
| 439 | + | |
439 | 440 | | |
440 | 441 | | |
441 | 442 | | |
| |||
605 | 606 | | |
606 | 607 | | |
607 | 608 | | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
608 | 613 | | |
609 | 614 | | |
610 | 615 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
181 | 183 | | |
182 | 184 | | |
183 | 185 | | |
| |||
0 commit comments