Requests page fails due to trying to modify a frozen string. (#630)

DropsOfSerenity · nateberkopec · web-flow · commit 470c9a8c66ed · 2025-04-14T08:29:37.000+09:00
* Inserting into frozen string fails.

Frozen strings cannot have `#insert` called on them, this was causing an
error on the requests page.

* Only dup blank page

* Spec actually was incorrect: we werent inserting the script tag!

---------

Co-authored-by: Nate Berkopec &lt;nate.berkopec@gmail.com&gt;
diff --git a/lib/mini_profiler.rb b/lib/mini_profiler.rb
@@ -329,7 +329,7 @@ def call(env)
             )
           end
         elsif path == '/rack-mini-profiler/requests'
-          status, headers, body = [200, { 'Content-Type' => 'text/html' }, [blank_page_html]]
+          status, headers, body = [200, { 'Content-Type' => 'text/html' }, [blank_page_html.dup]] # important to dup here!
         else
           status, headers, body = @app.call(env)
         end
diff --git a/spec/integration/middleware_spec.rb b/spec/integration/middleware_spec.rb
@@ -27,7 +27,7 @@ def app
       get '/rack-mini-profiler/requests', {}, 'HTTP_ACCEPT_ENCODING' => 'gzip, compress'
 
       expect(last_response.body).to include('<title>Rack::MiniProfiler Requests</title>')
-      expect(last_response.body).to match('<body>\n  </body>')
+      expect(last_response.body).to match('<body>\n  <script async nonce="" type="text/javascript" id="mini-profiler"')
     end
   end
 

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,7 @@ def call(env)`
`329`	`329`	`)`
`330`	`330`	`end`
`331`	`331`	`elsif path == '/rack-mini-profiler/requests'`
`332`		`- status, headers, body = [200, { 'Content-Type' => 'text/html' }, [blank_page_html]]`
	`332`	`+ status, headers, body = [200, { 'Content-Type' => 'text/html' }, [blank_page_html.dup]] # important to dup here!`
`333`	`333`	`else`
`334`	`334`	`status, headers, body = @app.call(env)`
`335`	`335`	`end`