fix(SimpleWebTransport): Too many calls to conn.Dispose

- WebsocketServer calls it from HandshakeAndReceiveLoop
- WebSocketClientStandAlone calls it from ConnectAndReceiveLoop
Both in try...finally -- that's enough and minimizes confusing logging

Author: MrGadget1024

Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Client/StandAlone/WebSocketClientStandAlone.cs

@@ -61,15 +61,13 @@ void ConnectAndReceiveLoop(Uri serverAddress)
                 if (!success)
                 {
                     Log.Warn("[SWT-WebSocketClientStandAlone]: Failed to create Stream with {0}", serverAddress);
-                    conn.Dispose();
                     return;
                 }
 
                 success = handshake.TryHandshake(conn, serverAddress);
                 if (!success)
                 {
                     Log.Warn("[SWT-WebSocketClientStandAlone]: Failed Handshake with {0}", serverAddress);
-                    conn.Dispose();
                     return;
                 }
 
@@ -106,7 +104,8 @@ void ConnectAndReceiveLoop(Uri serverAddress)
             finally
             {
                 // close here in case connect fails
-                conn?.Dispose();
+                if (conn != null && !conn.hasDisposed)
+                    conn.Dispose();
             }
         }
 
@@ -124,8 +123,8 @@ public override void Disconnect()
 
             if (conn == null)
                 state = ClientState.NotConnected;
-            else
-                conn?.Dispose();
+            else if (!conn.hasDisposed)
+                conn.Dispose();
         }
 
         public override void Send(ArraySegment<byte> segment)

Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Common/Connection.cs

@@ -35,7 +35,7 @@ internal sealed class Connection : IDisposable
         public ConcurrentQueue<ArrayBuffer> sendQueue = new ConcurrentQueue<ArrayBuffer>();
 
         public Action<Connection> onDispose;
-        volatile bool hasDisposed;
+        volatile internal bool hasDisposed;
 
         public Connection(TcpClient client, Action<Connection> onDispose)
         {

Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Common/ReceiveLoop.cs

@@ -100,7 +100,6 @@ public static void Loop(Config config)
             finally
             {
                 Profiler.EndThreadProfiling();
-                conn.Dispose();
             }
         }
 
@@ -237,8 +236,6 @@ static void HandleCloseMessage(Config config, byte[] buffer, int msgOffset, int
             // dump after mask off
             Log.DumpBuffer("[SWT-ReceiveLoop]: Message", buffer, msgOffset, payloadLength);
             Log.Verbose("[SWT-ReceiveLoop]: Close: {0} message:{1}", GetCloseCode(buffer, msgOffset), GetCloseMessage(buffer, msgOffset, payloadLength));
-
-            conn.Dispose();
         }
 
         static string GetCloseMessage(byte[] buffer, int msgOffset, int payloadLength)

Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Common/SendLoop.cs

@@ -121,7 +121,6 @@ public static void Loop(Config config)
             finally
             {
                 Profiler.EndThreadProfiling();
-                conn.Dispose();
                 maskHelper?.Dispose();
             }
         }

Assets/Mirror/Transports/SimpleWeb/SimpleWeb/Server/WebSocketServer.cs

@@ -109,7 +109,6 @@ void HandshakeAndReceiveLoop(Connection conn)
                 if (!success)
                 {
                     Log.Warn("[SWT-WebSocketServer]: Failed to create SSL Stream {0}", conn);
-                    conn.Dispose();
                     return;
                 }
 
@@ -118,7 +117,6 @@ void HandshakeAndReceiveLoop(Connection conn)
                 if (!success)
                 {
                     Log.Warn("[SWT-WebSocketServer]: Handshake failed for connection {0}", conn);
-                    conn.Dispose();
                     return;
                 }
 

Assets/Mirror/Transports/SimpleWeb/SimpleWebTransport.cs

@@ -234,8 +234,9 @@ public override void ClientConnect(Uri uri)
 
         public override void ClientDisconnect()
         {
-            // don't set client null here of messages wont be processed
-            client?.Disconnect();
+            // don't set client null here or messages wont be processed
+            if (client != null && client.ConnectionState != ClientState.NotConnected)
+                client.Disconnect();
         }
 
         public override void ClientSend(ArraySegment<byte> segment, int channelId)