Make pub(crate) fields of pub(crate) structs public

This doesn't change whether the fields are accessible outside the crate,
and avoids clippy warnings:

    warning: scoped visibility modifier on a field
      --> src/input/key_bindings.rs:44:2
       |
    44 |     pub(crate) action_drop: Vec<Event>,
       |     ^^^^^^^^^^
       |
       = help: consider making the field private and adding a scoped visibility method for it
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_scoped_visibility_modifiers

Author: bgilbert

src/config.rs

@@ -41,29 +41,29 @@ const DEFAULT_TAB_SYMBOL: &str = "\u{2192}"; // →
 #[non_exhaustive]
 pub(crate) struct Config {
 	/// If to select the next line in the list after performing an action.
-	pub(crate) auto_select_next: bool,
+	pub auto_select_next: bool,
 	/// How to handle whitespace when calculating diffs.
-	pub(crate) diff_ignore_whitespace: DiffIgnoreWhitespaceSetting,
+	pub diff_ignore_whitespace: DiffIgnoreWhitespaceSetting,
 	/// If to ignore blank lines when calculating diffs.
-	pub(crate) diff_ignore_blank_lines: bool,
+	pub diff_ignore_blank_lines: bool,
 	/// How to show whitespace in diffs.
-	pub(crate) diff_show_whitespace: DiffShowWhitespaceSetting,
+	pub diff_show_whitespace: DiffShowWhitespaceSetting,
 	/// The symbol used to replace space characters.
-	pub(crate) diff_space_symbol: String,
+	pub diff_space_symbol: String,
 	/// The symbol used to replace tab characters.
-	pub(crate) diff_tab_symbol: String,
+	pub diff_tab_symbol: String,
 	/// The display width of the tab character.
-	pub(crate) diff_tab_width: u32,
+	pub diff_tab_width: u32,
 	/// If set, automatically add an exec line with the command after every modified line
-	pub(crate) post_modified_line_exec_command: Option<String>,
+	pub post_modified_line_exec_command: Option<String>,
 	/// The maximum number of undo steps.
-	pub(crate) undo_limit: u32,
+	pub undo_limit: u32,
 	/// Configuration options loaded directly from Git.
-	pub(crate) git: GitConfig,
+	pub git: GitConfig,
 	/// Key binding configuration.
-	pub(crate) key_bindings: KeyBindings,
+	pub key_bindings: KeyBindings,
 	/// Theme configuration.
-	pub(crate) theme: Theme,
+	pub theme: Theme,
 }
 
 impl Config {

src/config/git_config.rs

@@ -28,31 +28,31 @@ pub(crate) struct GitConfig {
 	/// The Git comment character, from [`core.commentChar`](
 	///     https://git-scm.com/docs/git-config#Documentation/git-config.txt-corecommentChar
 	/// ).
-	pub(crate) comment_char: String,
+	pub comment_char: String,
 	/// Number of context lines, from [`diff.context`](
 	///     https://git-scm.com/docs/diff-config/#Documentation/diff-config.txt-diffcontext
 	/// ).
-	pub(crate) diff_context: u32,
+	pub diff_context: u32,
 	/// Number of interhunk lines, from [`diff.interhunk_lines`](
 	///     https://git-scm.com/docs/diff-config/#Documentation/diff-config.txt-diffinterHunkContext
 	/// ).
-	pub(crate) diff_interhunk_lines: u32,
+	pub diff_interhunk_lines: u32,
 	/// The limit for detecting renames, from [`diff.renameLimit`](
 	///     https://git-scm.com/docs/diff-config/#Documentation/diff-config.txt-diffrenameLimit
 	/// ).
-	pub(crate) diff_rename_limit: u32,
+	pub diff_rename_limit: u32,
 	/// If to detect renames, from [`diff.renames`](
 	///     https://git-scm.com/docs/diff-config/#Documentation/diff-config.txt-diffrenames
 	/// ).
-	pub(crate) diff_renames: bool,
+	pub diff_renames: bool,
 	/// If to detect copies, from [`diff.renames`](
 	///     https://git-scm.com/docs/diff-config/#Documentation/diff-config.txt-diffrenames
 	/// ).
-	pub(crate) diff_copies: bool,
+	pub diff_copies: bool,
 	/// The Git editor, from [`core.editor`](
 	///     https://git-scm.com/docs/git-config#Documentation/git-config.txt-coreeditor
 	/// ).
-	pub(crate) editor: String,
+	pub editor: String,
 }
 
 impl GitConfig {

src/config/key_bindings.rs

@@ -17,100 +17,100 @@ fn map_single_ascii_to_lower(s: &str) -> String {
 #[non_exhaustive]
 pub(crate) struct KeyBindings {
 	/// Key bindings for aborting.
-	pub(crate) abort: Vec<String>,
+	pub abort: Vec<String>,
 	/// Key bindings for the break action.
-	pub(crate) action_break: Vec<String>,
+	pub action_break: Vec<String>,
 	/// Key bindings for the drop action.
-	pub(crate) action_drop: Vec<String>,
+	pub action_drop: Vec<String>,
 	/// Key bindings for the edit action.
-	pub(crate) action_edit: Vec<String>,
+	pub action_edit: Vec<String>,
 	/// Key bindings for the fixup action.
-	pub(crate) action_fixup: Vec<String>,
+	pub action_fixup: Vec<String>,
 	/// Key bindings for the pick action.
-	pub(crate) action_pick: Vec<String>,
+	pub action_pick: Vec<String>,
 	/// Key bindings for the reword action.
-	pub(crate) action_reword: Vec<String>,
+	pub action_reword: Vec<String>,
 	/// Key bindings for the squash action.
-	pub(crate) action_squash: Vec<String>,
+	pub action_squash: Vec<String>,
 	/// Key bindings for negative confirmation.
-	pub(crate) confirm_no: Vec<String>,
+	pub confirm_no: Vec<String>,
 	/// Key bindings for positive confirmation.
-	pub(crate) confirm_yes: Vec<String>,
+	pub confirm_yes: Vec<String>,
 	/// Key bindings for editing.
-	pub(crate) edit: Vec<String>,
+	pub edit: Vec<String>,
 	/// Key bindings for forcing a abort.
-	pub(crate) force_abort: Vec<String>,
+	pub force_abort: Vec<String>,
 	/// Key bindings for forcing a rebase.
-	pub(crate) force_rebase: Vec<String>,
+	pub force_rebase: Vec<String>,
 	/// Key bindings for showing help.
-	pub(crate) help: Vec<String>,
+	pub help: Vec<String>,
 	/// Key bindings for inserting a line.
-	pub(crate) insert_line: Vec<String>,
+	pub insert_line: Vec<String>,
 
 	/// Key bindings for moving down.
-	pub(crate) move_down: Vec<String>,
+	pub move_down: Vec<String>,
 	/// Key bindings for moving to the end.
-	pub(crate) move_end: Vec<String>,
+	pub move_end: Vec<String>,
 	/// Key bindings for moving to the start.
-	pub(crate) move_home: Vec<String>,
+	pub move_home: Vec<String>,
 	/// Key bindings for moving to the left.
-	pub(crate) move_left: Vec<String>,
+	pub move_left: Vec<String>,
 	/// Key bindings for moving to the right.
-	pub(crate) move_right: Vec<String>,
+	pub move_right: Vec<String>,
 	/// Key bindings for moving up.
-	pub(crate) move_up: Vec<String>,
+	pub move_up: Vec<String>,
 	/// Key bindings for moving down a step.
-	pub(crate) move_down_step: Vec<String>,
+	pub move_down_step: Vec<String>,
 	/// Key bindings for moving up a step.
-	pub(crate) move_up_step: Vec<String>,
+	pub move_up_step: Vec<String>,
 	/// Key bindings for moving the selection down.
-	pub(crate) move_selection_down: Vec<String>,
+	pub move_selection_down: Vec<String>,
 	/// Key bindings for moving the selection up.
-	pub(crate) move_selection_up: Vec<String>,
+	pub move_selection_up: Vec<String>,
 
 	/// Key bindings for scrolling down.
-	pub(crate) scroll_down: Vec<String>,
+	pub scroll_down: Vec<String>,
 	/// Key bindings for scrolling to the end.
-	pub(crate) scroll_end: Vec<String>,
+	pub scroll_end: Vec<String>,
 	/// Key bindings for scrolling to the start.
-	pub(crate) scroll_home: Vec<String>,
+	pub scroll_home: Vec<String>,
 	/// Key bindings for scrolling to the left.
-	pub(crate) scroll_left: Vec<String>,
+	pub scroll_left: Vec<String>,
 	/// Key bindings for scrolling to the right.
-	pub(crate) scroll_right: Vec<String>,
+	pub scroll_right: Vec<String>,
 	/// Key bindings for scrolling up.
-	pub(crate) scroll_up: Vec<String>,
+	pub scroll_up: Vec<String>,
 	/// Key bindings for scrolling down a step.
-	pub(crate) scroll_step_down: Vec<String>,
+	pub scroll_step_down: Vec<String>,
 	/// Key bindings for scrolling up a step.
-	pub(crate) scroll_step_up: Vec<String>,
+	pub scroll_step_up: Vec<String>,
 
 	/// Key bindings for opening the external editor.
-	pub(crate) open_in_external_editor: Vec<String>,
+	pub open_in_external_editor: Vec<String>,
 	/// Key bindings for rebasing.
-	pub(crate) rebase: Vec<String>,
+	pub rebase: Vec<String>,
 	/// Key bindings for redoing a change.
-	pub(crate) redo: Vec<String>,
+	pub redo: Vec<String>,
 	/// Key bindings for removing a line.
-	pub(crate) remove_line: Vec<String>,
+	pub remove_line: Vec<String>,
 	/// Key bindings for starting search.
-	pub(crate) search_start: Vec<String>,
+	pub search_start: Vec<String>,
 	/// Key bindings for next search match.
-	pub(crate) search_next: Vec<String>,
+	pub search_next: Vec<String>,
 	/// Key bindings for previous search match.
-	pub(crate) search_previous: Vec<String>,
+	pub search_previous: Vec<String>,
 	/// Key bindings for showing a commit.
-	pub(crate) show_commit: Vec<String>,
+	pub show_commit: Vec<String>,
 	/// Key bindings for showing a diff.
-	pub(crate) show_diff: Vec<String>,
+	pub show_diff: Vec<String>,
 	/// Key bindings for toggling visual mode.
-	pub(crate) toggle_visual_mode: Vec<String>,
+	pub toggle_visual_mode: Vec<String>,
 	/// Key bindings for undoing a change.
-	pub(crate) undo: Vec<String>,
+	pub undo: Vec<String>,
 	/// Key bindings for the fixup specific action to toggle the c option.
-	pub(crate) fixup_keep_message_with_editor: Vec<String>,
+	pub fixup_keep_message_with_editor: Vec<String>,
 	/// Key bindings for the fixup specific action to toggle the c option.
-	pub(crate) fixup_keep_message: Vec<String>,
+	pub fixup_keep_message: Vec<String>,
 }
 
 impl KeyBindings {

src/config/theme.rs

@@ -28,49 +28,49 @@ fn get_color(config: Option<&Config>, name: &str, default: Color) -> Result<Colo
 #[non_exhaustive]
 pub(crate) struct Theme {
 	/// The character for filling vertical spacing.
-	pub(crate) character_vertical_spacing: String,
+	pub character_vertical_spacing: String,
 	/// The color for the break action.
-	pub(crate) color_action_break: Color,
+	pub color_action_break: Color,
 	/// The color for the drop action.
-	pub(crate) color_action_drop: Color,
+	pub color_action_drop: Color,
 	/// The color for the edit action.
-	pub(crate) color_action_edit: Color,
+	pub color_action_edit: Color,
 	/// The color for the exec action.
-	pub(crate) color_action_exec: Color,
+	pub color_action_exec: Color,
 	/// The color for the fixup action.
-	pub(crate) color_action_fixup: Color,
+	pub color_action_fixup: Color,
 	/// The color for the pick action.
-	pub(crate) color_action_pick: Color,
+	pub color_action_pick: Color,
 	/// The color for the reword action.
-	pub(crate) color_action_reword: Color,
+	pub color_action_reword: Color,
 	/// The color for the squash action.
-	pub(crate) color_action_squash: Color,
+	pub color_action_squash: Color,
 	/// The color for the label action.
-	pub(crate) color_action_label: Color,
+	pub color_action_label: Color,
 	/// The color for the reset action.
-	pub(crate) color_action_reset: Color,
+	pub color_action_reset: Color,
 	/// The color for the merge action.
-	pub(crate) color_action_merge: Color,
+	pub color_action_merge: Color,
 	/// The color for the update-ref action.
-	pub(crate) color_action_update_ref: Color,
+	pub color_action_update_ref: Color,
 	/// The color for the background.
-	pub(crate) color_background: Color,
+	pub color_background: Color,
 	/// The color for added lines in a diff.
-	pub(crate) color_diff_add: Color,
+	pub color_diff_add: Color,
 	/// The color for changed lines in a diff.
-	pub(crate) color_diff_change: Color,
+	pub color_diff_change: Color,
 	/// The color for context lines in a diff.
-	pub(crate) color_diff_context: Color,
+	pub color_diff_context: Color,
 	/// The color for removed lines in a diff.
-	pub(crate) color_diff_remove: Color,
+	pub color_diff_remove: Color,
 	/// The color for whitespace characters in a diff.
-	pub(crate) color_diff_whitespace: Color,
+	pub color_diff_whitespace: Color,
 	/// The color for the standard text.
-	pub(crate) color_foreground: Color,
+	pub color_foreground: Color,
 	/// The color for indicator text.
-	pub(crate) color_indicator: Color,
+	pub color_indicator: Color,
 	/// The background color for selected lines.
-	pub(crate) color_selected_background: Color,
+	pub color_selected_background: Color,
 }
 
 impl Theme {

src/git/commit.rs

@@ -5,14 +5,14 @@ use crate::git::{GitError, Reference, User};
 /// Represents a commit.
 #[derive(Debug, PartialEq, Eq)]
 pub(crate) struct Commit {
-	pub(crate) hash: String,
-	pub(crate) reference: Option<Reference>,
-	pub(crate) author: User,
-	pub(crate) authored_date: Option<DateTime<Local>>,
-	pub(crate) message: Option<String>,
-	pub(crate) committer: Option<User>,
-	pub(crate) committed_date: DateTime<Local>,
-	pub(crate) summary: Option<String>,
+	pub hash: String,
+	pub reference: Option<Reference>,
+	pub author: User,
+	pub authored_date: Option<DateTime<Local>>,
+	pub message: Option<String>,
+	pub committer: Option<User>,
+	pub committed_date: DateTime<Local>,
+	pub summary: Option<String>,
 }
 
 impl Commit {

src/git/commit_diff_loader_options.rs

@@ -2,14 +2,14 @@
 #[derive(Copy, Clone, Debug)]
 #[allow(clippy::struct_excessive_bools)]
 pub(crate) struct CommitDiffLoaderOptions {
-	pub(crate) context_lines: u32,
-	pub(crate) copies: bool,
-	pub(crate) ignore_whitespace: bool,
-	pub(crate) ignore_whitespace_change: bool,
-	pub(crate) ignore_blank_lines: bool,
-	pub(crate) interhunk_context: u32,
-	pub(crate) rename_limit: u32,
-	pub(crate) renames: bool,
+	pub context_lines: u32,
+	pub copies: bool,
+	pub ignore_whitespace: bool,
+	pub ignore_whitespace_change: bool,
+	pub ignore_blank_lines: bool,
+	pub interhunk_context: u32,
+	pub rename_limit: u32,
+	pub renames: bool,
 }
 
 impl CommitDiffLoaderOptions {