Don't register dictation subsystem on non-Windows (#1001)

Author: keveleigh

org.mixedrealitytoolkit.core/Subsystems/Speech/DictationSubsystemDescriptor.cs

@@ -59,15 +59,15 @@ public class DictationSubsystemDescriptor :
         /// </returns>
         internal static DictationSubsystemDescriptor Create(DictationSubsystemCinfo cinfo)
         {
-           // Validates cinfo.
-           if (!XRSubsystemHelpers.CheckTypes<DictationSubsystem, DictationSubsystem.Provider>(cinfo.Name,
-                                                                                                               cinfo.SubsystemTypeOverride,
-                                                                                                               cinfo.ProviderType))
-           {
-               throw new ArgumentException("Could not create DictationSubsystemDescriptor.");
-           }
+            // Validates cinfo.
+            if (!XRSubsystemHelpers.CheckTypes<DictationSubsystem, DictationSubsystem.Provider>(cinfo.Name,
+                                                                                                                cinfo.SubsystemTypeOverride,
+                                                                                                                cinfo.ProviderType))
+            {
+                throw new ArgumentException("Could not create DictationSubsystemDescriptor.");
+            }
 
-           return new DictationSubsystemDescriptor(cinfo);
+            return new DictationSubsystemDescriptor(cinfo);
         }
     }
 }

org.mixedrealitytoolkit.windowsspeech/CHANGELOG.md

@@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Changed
 
-* Subsystem no longer registers itself on non-Windows platforms.
+* Subsystems no longer register themselves on non-Windows platforms.
 
 ## [3.0.3] - 2024-04-17
 

org.mixedrealitytoolkit.windowsspeech/Subsystems/WindowsDictationSubsystem.cs

@@ -7,14 +7,14 @@
 
 #if UNITY_EDITOR_WIN || UNITY_STANDALONE_WIN || UNITY_WSA
 using UnityEngine.Windows.Speech;
-#endif // UNITY_STANDALONE_WIN || UNITY_WSA || UNITY_EDITOR_WIN
+#endif // UNITY_EDITOR_WIN || UNITY_STANDALONE_WIN || UNITY_WSA
 
 namespace MixedReality.Toolkit.Speech.Windows
 {
     /// <summary>
     /// A Unity subsystem that extends <see cref="MixedReality.Toolkit.Subsystems.DictationSubsystem">DictationSubsystem</see>
     /// so to expose the dictation services available on Windows platforms. This subsystem is enabled for Windows Standalone and
-    /// Universal Windows Applications. 
+    /// Universal Windows Applications.
     /// </summary>
     /// <remarks>
     /// This subsystem can be configured using the <see cref="MixedReality.Toolkit.Speech.Windows.WindowsDictationSubsystemConfig">WindowsDictationSubsystemConfig</see> Unity asset.
@@ -35,10 +35,14 @@ static void Register()
             // Fetch subsystem metadata from the attribute.
             var cinfo = XRSubsystemHelpers.ConstructCinfo<WindowsDictationSubsystem, DictationSubsystemCinfo>();
 
+#if UNITY_EDITOR_WIN || UNITY_STANDALONE_WIN || UNITY_WSA
             if (!Register(cinfo))
             {
                 Debug.LogError($"Failed to register the {cinfo.Name} subsystem.");
             }
+#else
+            Debug.Log($"Skipping registration of the {cinfo.Name} subsystem due to running on an unsupported platform.");
+#endif
         }
 
         /// <summary>