Fix asset not being marked dirty when changed

Author: keveleigh

org.mixedrealitytoolkit.uxcore/Editor/Inspectors/FontIconSet/FontIconSetInspector.cs

@@ -34,7 +34,7 @@ public class FontIconSetInspector : UnityEditor.Editor
         private const string TextMeshProMenuItem = "Window/TextMeshPro/Font Asset Creator";
 
         private SerializedProperty iconFontAssetProp = null;
-        private SerializedProperty fontIconSetDefinition = null;
+        private SerializedProperty fontIconSetDefinitionProp = null;
 
         private class IconEntry
         {
@@ -57,7 +57,7 @@ private void OnEnable()
         {
             FontIconSet fontIconSet = (FontIconSet)target;
             iconFontAssetProp = serializedObject.FindProperty("iconFontAsset");
-            fontIconSetDefinition = serializedObject.FindProperty("fontIconSetDefinition");
+            fontIconSetDefinitionProp = serializedObject.FindProperty("fontIconSetDefinition");
 
             // Make a list out of dictionary to avoid changing order while editing names
             foreach (KeyValuePair<string, uint> kv in fontIconSet.GlyphIconsByName)
@@ -81,7 +81,7 @@ public override void OnInspectorGUI()
             if (showGlyphIconFoldout)
             {
                 EditorGUILayout.PropertyField(iconFontAssetProp);
-                EditorGUILayout.PropertyField(fontIconSetDefinition);
+                EditorGUILayout.PropertyField(fontIconSetDefinitionProp);
 
                 if (iconFontAssetProp.objectReferenceValue == null)
                 {
@@ -133,7 +133,7 @@ public override void OnInspectorGUI()
                         {
                             EditorGUILayout.HelpBox("These icons will appear in the button config helper inspector. Click an icon to remove it from this list.", MessageType.Info);
 
-                            if (fontIconSetDefinition.objectReferenceValue == null)
+                            if (fontIconSetDefinitionProp.objectReferenceValue == null)
                             {
                                 EditorGUILayout.HelpBox("It's recommended to use a Font Icon Set Definition to ensure consistent icon names across icon sets.", MessageType.Warning);
                             }
@@ -252,6 +252,7 @@ private bool AddIcon(FontIconSet fontIconSet, uint unicodeValue)
             if (fontIconSet.AddIcon(name, unicodeValue))
             {
                 iconEntries.Add(new IconEntry(name, unicodeValue));
+                EditorUtility.SetDirty(fontIconSet);
             }
             return true;
         }
@@ -262,6 +263,7 @@ private bool RemoveIcon(FontIconSet fontIconSet, string iconName)
             if (removed && FindIconIndexByName(iconName, out int index))
             {
                 iconEntries.RemoveAt(index);
+                EditorUtility.SetDirty(fontIconSet);
             }
             return removed;
         }
@@ -284,6 +286,7 @@ private void UpdateIconName(FontIconSet fontIconSet, string oldName, string newN
             if (fontIconSet.UpdateIconName(oldName, newName) && FindIconIndexByName(oldName, out int index))
             {
                 iconEntries[index].Name = newName;
+                EditorUtility.SetDirty(fontIconSet);
             }
         }