Skip to content

Commit 713b185

Browse files
committed
Iterate
1 parent f39667a commit 713b185

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

org.mixedrealitytoolkit.input/Visualizers/HandMeshVisualizer.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,6 @@ public XRInputButtonReader SelectInput
5959

6060
#endregion ISelectInputVisualizer implementation
6161

62-
/// <summary>
63-
/// Whether this visualizer currently has a loaded and visible hand mesh or not.
64-
/// </summary>
65-
public abstract bool IsRendering { get; }
66-
67-
protected abstract Renderer HandRenderer { get; }
68-
6962
// The property block used to modify the pinch amount property on the material
7063
private MaterialPropertyBlock propertyBlock = null;
7164

@@ -84,6 +77,16 @@ public XRInputButtonReader SelectInput
8477
/// <seealso cref="XRInputButtonReader.DisableDirectActionIfModeUsed"/>
8578
protected List<XRInputButtonReader> buttonReaders { get; } = new List<XRInputButtonReader>();
8679

80+
/// <summary>
81+
/// Whether this visualizer currently has a loaded and visible hand mesh or not.
82+
/// </summary>
83+
protected internal bool IsRendering => HandRenderer != null && HandRenderer.enabled;
84+
85+
/// <summary>
86+
/// The renderer for this visualizer, to use to visualize the pinch amount.
87+
/// </summary>
88+
protected abstract Renderer HandRenderer { get; }
89+
8790
/// <summary>
8891
/// A Unity event function that is called when an enabled script instance is being loaded.
8992
/// </summary>

org.mixedrealitytoolkit.input/Visualizers/PlatformHandVisualizer/PlatformHandMeshVisualizer.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public class PlatformHandMeshVisualizer : HandMeshVisualizer
1818
[SerializeField]
1919
private MeshRenderer handRenderer;
2020

21+
/// <inheritdoc/>
2122
protected override Renderer HandRenderer => handRenderer;
2223

2324
#if MROPENXR_PRESENT && (UNITY_STANDALONE_WIN || UNITY_WSA || UNITY_ANDROID)
@@ -27,9 +28,6 @@ public class PlatformHandMeshVisualizer : HandMeshVisualizer
2728
private Mesh neutralPoseMesh;
2829
private bool initializedUVs = false;
2930

30-
/// <inheritdoc/>
31-
public override bool IsRendering => handRenderer != null && handRenderer.enabled && ShouldRenderHand();
32-
3331
/// <inheritdoc/>
3432
protected override void OnEnable()
3533
{

org.mixedrealitytoolkit.input/Visualizers/RiggedHandVisualizer/RiggedHandMeshVisualizer.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public class RiggedHandMeshVisualizer : HandMeshVisualizer
3333
[Tooltip("The primary visualizer. Rigged hand will not render if the primary is rendering.")]
3434
private HandMeshVisualizer primaryMeshVisualizer = null;
3535

36+
/// <inheritdoc/>
3637
protected override Renderer HandRenderer => handRenderer;
3738

3839
// Automatically calculated over time, based on the accumulated error
@@ -50,9 +51,6 @@ public class RiggedHandMeshVisualizer : HandMeshVisualizer
5051
// at the end of a finger, which is discarded.
5152
private const string endJointName = "end";
5253

53-
/// <inheritdoc/>
54-
public override bool IsRendering => handRenderer != null && handRenderer.enabled && ShouldRenderHand();
55-
5654
/// <summary>
5755
/// A Unity event function that is called when an enabled script instance is being loaded.
5856
/// </summary>

0 commit comments

Comments
 (0)