Skip to content

incorrect angles and name of the axes  #5

@J-Christophe

Description

@J-Christophe

Hi,

Very good job. However a few remarks

In the following example ViewCenterZoom.ipynb :

  • the axis long should be renamed as Ra or alpha when we look at the sky
  • the axis lat should be renamed as Dec or delta when we look at the sky

According to the coordinate reference system, the name changes. Loot at Mizar in each CRS :
https://github.com/MizarWeb/Mizar/blob/bbf75ab7599fcb35d7e8b6f666b94b13b9752e33/src/Crs/EquatorialCrs.js#L82-L88
https://github.com/MizarWeb/Mizar/blob/bbf75ab7599fcb35d7e8b6f666b94b13b9752e33/src/Crs/GalacticCrs.js#L114-L124

Again, according to the coordinate reference system, the angle is not counted in the same way. For instance, in the equatorial frame we count the Ra from 0 to 360° (https://github.com/MizarWeb/Mizar/blob/bbf75ab7599fcb35d7e8b6f666b94b13b9752e33/src/Crs/EquatorialCrs.js#L127) and not from -180 to 180

Jean-Christophe

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions