Skip to content

Commit b4be4de

Browse files
friedfacebook-github-bot
authored andcommitted
Remove libpython from a majority of binaries
Summary: Ok this one change has caused issues in the past changing implicit behavior because of the presence of python symbols at runtime. Causing folly singletons to abort. Because Singleton Vault was set to Relaxed with python symbols linked, and defaults to Strict without python symbols linked. SEE: T220549503 S520322 - Pre-emptive sev. Its been mentioned in the past that unless this next land causes significant failures we should point people to a pre-emptive Sev for a fix forward. Reviewed By: yfeldblum Differential Revision: D74011853 fbshipit-source-id: 750465c8d030a0a688d97e6a0f98b00810b05299
1 parent 35fe13c commit b4be4de

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

folly/python/BUCK

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,6 @@ non_fbcode_target(
404404
platforms = CYTHON_DEFAULT_PLATFORMS,
405405
raw_headers = ["error.h"],
406406
deps = [
407-
"fbsource//third-party/python:python", # @manual see: T220549503 # TODO: FRIED remove this
408407
":weak",
409408
"//xplat/folly:conv",
410409
"//xplat/folly:range",
@@ -830,7 +829,6 @@ fbcode_target(
830829
"error.h",
831830
],
832831
deps = [
833-
"fbsource//third-party/python:python", # @manual see: T220549503 # TODO: FRIED remove this
834832
":weak",
835833
"//folly:conv",
836834
"//folly:scope_guard",

0 commit comments

Comments
 (0)