build_def: build cc_binary .pyd directly

Author: corentinl

build_defs.bzl

@@ -105,18 +105,41 @@ def pybind_extension(
         **kwargs
     )
 
-    copy_file(
-        name = name + "_copy_dll_to_pyd",
-        src = name + ".dll",
-        out = name + ".pyd",
-        testonly = kwargs.get("testonly"),
-        visibility = kwargs.get("visibility"),
+    cc_binary(
+        name = name + ".pyd",
+        copts = copts + PYBIND_COPTS + select({
+            Label("@pybind11//:msvc_compiler"): [],
+            "//conditions:default": ["-fvisibility=hidden"],
+        }),
+        features = features + PYBIND_FEATURES,
+        linkopts = linkopts + select({
+            "@platforms//os:osx": ["-undefined", "dynamic_lookup"],
+            Label("@pybind11//:msvc_compiler"): [],
+            "//conditions:default": ["-Wl,-Bsymbolic"],
+        }),
+        linkshared = 1,
+        tags = tags,
+        target_compatible_with = select({
+            "@platforms//os:windows": [],
+            "//conditions:default": ["@platforms//:incompatible"],
+        }),
+        deps = deps + PYBIND_DEPS,
+        **kwargs
     )
 
+    #copy_file(
+    #    name = name + "_copy_dll_to_pyd",
+    #    src = name + ".dll",
+    #    out = name + ".pyd",
+    #    testonly = kwargs.get("testonly"),
+    #    visibility = kwargs.get("visibility"),
+    #)
+
     native.alias(
         name = name,
         actual = select({
-            "@platforms//os:windows": name + "_copy_dll_to_pyd",
+            "@platforms//os:windows": name + ".pyd",
+            #"@platforms//os:windows": name + "_copy_dll_to_pyd",
             "//conditions:default": name + ".so",
         }),
         testonly = kwargs.get("testonly"),