Skip to content

Commit 2cf79ee

Browse files
committed
Add failing test for proxying derived record type
On .NET 6+ this fails with a `TypeLoadException`: > Return type in method `DerivedEmptyRecord.<Clone>$()` [...] is not > compatible with base type method `EmptyRecord.<Clone>$()` From dotnet/efcore#26602 (comment): > The C# compiler changed the emit strategy for records in .NET 6 to > take advantage of covariant returns. The Clone method now always has a > return type that matches the containing type. Covariant returns were > added to the runtime and language in .NET 5 but records didn't take > advantage of them (just ran out of time). In .NET 6 though we finished > off that feature and added it to records. So we'll need to add support for covariant returns to DynamicProxy.
1 parent 9a84a79 commit 2cf79ee

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// Copyright 2004-2022 Castle Project - http://www.castleproject.org/
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
namespace Castle.DynamicProxy.Tests.Records
16+
{
17+
public record DerivedEmptyRecord : EmptyRecord
18+
{
19+
}
20+
}

src/Castle.Core.Tests/DynamicProxy.Tests/RecordsTestCase.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,11 @@ public void Can_proxy_empty_record()
2626
{
2727
_ = generator.CreateClassProxy<EmptyRecord>(new StandardInterceptor());
2828
}
29+
30+
[Test]
31+
public void Can_proxy_derived_empty_record()
32+
{
33+
_ = generator.CreateClassProxy<DerivedEmptyRecord>(new StandardInterceptor());
34+
}
2935
}
3036
}

0 commit comments

Comments
 (0)