Also check for covariant return types if both of them are generic

stakx · stakx · commit a1b44d7750c3 · 2022-12-29T12:47:04.000+01:00
diff --git a/src/Castle.Core/DynamicProxy/Generators/MethodSignatureComparer.cs b/src/Castle.Core/DynamicProxy/Generators/MethodSignatureComparer.cs
@@ -121,9 +121,12 @@ private bool EqualSignatureTypes(Type x, Type y, MethodInfo xm = null, MethodInf
 					return false;
 				}
 
-				for (var i = 0; i < xArgs.Length; ++i)
+				if (IsCovariantReturnTypes(x, y, xm, ym) == false)
 				{
-					 if(!EqualSignatureTypes(xArgs[i], yArgs[i])) return false;
+					for (var i = 0; i < xArgs.Length; ++i)
+					{
+						 if(!EqualSignatureTypes(xArgs[i], yArgs[i])) return false;
+					}
 				}
 			}
 			else

Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,12 @@ private bool EqualSignatureTypes(Type x, Type y, MethodInfo xm = null, MethodInf`
`121`	`121`	`return false;`
`122`	`122`	`}`
`123`	`123`
`124`		`- for (var i = 0; i < xArgs.Length; ++i)`
	`124`	`+ if (IsCovariantReturnTypes(x, y, xm, ym) == false)`
`125`	`125`	`{`
`126`		`- if(!EqualSignatureTypes(xArgs[i], yArgs[i])) return false;`
	`126`	`+ for (var i = 0; i < xArgs.Length; ++i)`
	`127`	`+ {`
	`128`	`+ if(!EqualSignatureTypes(xArgs[i], yArgs[i])) return false;`
	`129`	`+ }`
`127`	`130`	`}`
`128`	`131`	`}`
`129`	`132`	`else`