Skip to content

Commit f077ca6

Browse files
committed
SRE bug got fixed in .NET 6, unskip 3 tests
1 parent bcf05dc commit f077ca6

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/Castle.Core.Tests/DynamicProxy.Tests/ValueTypeReferenceSemanticsTestCase.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ public void Can_intercept_method_having_valuetypes_parameter_with_in_modifier()
6060
}
6161

6262
[Test]
63+
#if !NET6_0_OR_GREATER // bug got fixed in .NET 6, so run the test there (by omitting [Platform] because it doesn't support version specs for .NET Core)
6364
[Platform(Exclude = "Net,NetCore", Reason = "Fails with a MissingMethodException due to a bug in System.Reflection.Emit. See https://github.com/dotnet/corefx/issues/29254.")]
65+
#endif
6466
public void Can_proxy_method_in_generic_type_having_valuetyped_parameter_with_in_modifier()
6567
{
6668
var proxy = this.generator.CreateInterfaceProxyWithoutTarget<IGenericTypeWithInModifier<bool>>(new DoNothingInterceptor());
@@ -69,7 +71,9 @@ public void Can_proxy_method_in_generic_type_having_valuetyped_parameter_with_in
6971
}
7072

7173
[Test]
74+
#if !NET6_0_OR_GREATER // as above
7275
[Platform(Exclude = "Net,NetCore", Reason = "Fails with a MissingMethodException due to a bug in System.Reflection.Emit. See https://github.com/dotnet/corefx/issues/29254.")]
76+
#endif
7377
public void Can_proxy_generic_method_in_nongeneric_type_having_valuetyped_parameter_with_in_modifier()
7478
{
7579
var proxy = this.generator.CreateInterfaceProxyWithoutTarget<IGenericMethodWithInModifier>(new DoNothingInterceptor());
@@ -78,7 +82,9 @@ public void Can_proxy_generic_method_in_nongeneric_type_having_valuetyped_parame
7882
}
7983

8084
[Test]
85+
#if !NET6_0_OR_GREATER // as above
8186
[Platform(Exclude = "Net,NetCore", Reason = "Fails with a MissingMethodException due to a bug in System.Reflection.Emit. See https://github.com/dotnet/corefx/issues/29254.")]
87+
#endif
8288
public void Can_proxy_generic_method_in_generic_type_having_valuetyped_parameter_with_in_modifier()
8389
{
8490
var proxy = this.generator.CreateInterfaceProxyWithoutTarget<IGenericTypeAndMethodWithInModifier<bool>>(new DoNothingInterceptor());

0 commit comments

Comments
 (0)