[HOTFIX] Migrate from setup.py to poetry, tox QA (#2249)

* Migrate from setup.py to use poetry build and publish
* Tox QA
* Version is now configured only at pyproject.toml
* Added poetry build test
* Updated mobsf PyPI publishing workflow 
* Update local DBs

Author: ajinabraham

.dockerignore

@@ -5,6 +5,7 @@
 .dockerignore
 .sonarcloud.properties
 .pyup.yml
+.python-version
 tox.ini
 mobsf/db.sqlite3
 Dockerfile
@@ -15,8 +16,6 @@ build
 docker-compose.yml
 *.md
 venv
-setup.py
-MANIFEST.in
 setup.bat
 run.bat
 setup.sh

.github/workflows/mobsf-test.yml

@@ -26,7 +26,7 @@ jobs:
       run: |
         python -m pip install pip==22.3.1 poetry==1.6.1
 
-    - name: Lint
+    - name: Lint on Ubuntu
       if: startsWith(matrix.os, 'ubuntu')
       run: |
         python -m pip install --upgrade tox
@@ -52,14 +52,22 @@ jobs:
 
     - name: Install Python dependencies
       run: |
-        poetry install --only main --no-interaction --no-ansi || poetry install --only main --no-interaction --no-ansi || poetry install --only main --no-interaction --no-ansi
+        poetry install --only main --no-root --no-interaction --no-ansi || poetry install --only main --no-root --no-interaction --no-ansi || poetry install --only main --no-root --no-interaction --no-ansi
 
     - name: Migrate Database
       run: |
         poetry run python manage.py makemigrations
         poetry run python manage.py makemigrations StaticAnalyzer
         poetry run python manage.py migrate
-    - name: Unit Tests
+
+    - name: Unit Tests on Ubuntu, macOS and Windows
       run: |
         git submodule update --init --recursive
         poetry run python manage.py test mobsf
+
+    - name: Python Package Test in Ubuntu and macOS
+      if: startsWith(matrix.os, 'ubuntu') || startsWith(matrix.os, 'macOS')
+      run: |
+        poetry build
+        python -m pip install dist/*.whl
+        mobsf db

.github/workflows/python-publish.yml

@@ -18,11 +18,11 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install setuptools twine
+        pip install poetry==1.6.1
     - name: Build and publish
       env:
-        TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
-        TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
+        PYPI_TOKEN: ${{ secrets.PYPI_PASSWORD }}
       run: |
-        python setup.py sdist
-        twine upload dist/*
+        poetry config pypi-token.pypi ${PYPI_TOKEN}
+        poetry build
+        poetry publish

.gitignore

@@ -68,6 +68,7 @@ classes-error.zip
 */migrations/*
 .fuse_hidden*
 .tox
+.python-version
 
 #MobSF Files
 mobsf/debug.log

Dockerfile

@@ -64,7 +64,7 @@ RUN adduser $MOBSF_USER --shell /bin/false -u 9901 --ingroup $MOBSF_USER --gecos
 COPY poetry.lock pyproject.toml ./
 RUN python3 -m pip install --upgrade --no-cache-dir pip poetry==${POETRY_VERSION} && \
     poetry config virtualenvs.create false && \
-    poetry install --only main --no-interaction --no-ansi
+    poetry install --only main --no-root --no-interaction --no-ansi
 
 # Cleanup
 RUN \

MANIFEST.in

@@ -3,10 +3,13 @@
 import platform
 
 from django.core.management import execute_from_command_line
+from django.db import connection
+
+
+os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'mobsf.MobSF.settings')
 
 
 def db():
-    os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'mobsf.MobSF.settings')
     execute_from_command_line([
         '',
         'makemigrations',
@@ -23,10 +26,20 @@ def db():
 
 
 def main():
-    if len(sys.argv) == 2:
-        listen = sys.argv[1]
-    else:
-        listen = '127.0.0.1:8000'
+    try:
+        if not connection.introspection.table_names():
+            db()
+    except Exception:
+        db()
+    listen = '127.0.0.1:8000'
+    if len(sys.argv) == 2 and sys.argv[1]:
+        if sys.argv[1] == 'db':
+            db()
+            listen = None
+        elif sys.argv[1]:
+            listen = sys.argv[1]
+    if not listen:
+        exit(0)
     if platform.system() != 'Windows':
         sys.argv = [
             '',
@@ -36,6 +49,11 @@ def main():
             '--workers=1',
             '--threads=10',
             '--timeout=3600',
+            '--log-level=citical',
+            '--log-file=-',
+            '--access-logfile=-',
+            '--error-logfile=-',
+            '--capture-output',
         ]
         from gunicorn.app.wsgiapp import run
         run()