* fixed error messages in idea.log:

1) `#c.i.i.p.PluginManager - Plugin descriptor for 'depends' sub-descriptor 'com.mobidevelop.robovm.intellij-maven.xml' of plugin 'com.mobidevelop.robovm.intellij' has declared element 'url' which has no effect there`

fix: removed from plugin.xml

2) java.lang.IllegalArgumentException: Must specify non-empty 'commandLine' parameter
fix: using "launching RoboVm application..." string as command line

3) java.lang.IllegalStateException: Failed to get PID from an instance of class org.robovm.compiler.launcher.ProcessProxy
fix: as wrapper/proxy processes doesn't have native PID, override `destroyProcessImpl` that doesn't call super.

Author: dkimitsa

plugins/idea/src/main/java/org/robovm/idea/running/RoboVmRunProfileState.java

@@ -19,8 +19,9 @@
 import com.intellij.execution.ExecutionException;
 import com.intellij.execution.RunnerAndConfigurationSettings;
 import com.intellij.execution.configurations.CommandLineState;
+import com.intellij.execution.executors.DefaultDebugExecutor;
+import com.intellij.execution.executors.DefaultRunExecutor;
 import com.intellij.execution.process.ColoredProcessHandler;
-import com.intellij.execution.process.OSProcessHandler;
 import com.intellij.execution.process.ProcessHandler;
 import com.intellij.execution.process.ProcessTerminatedListener;
 import com.intellij.execution.process.SelfKiller;
@@ -84,7 +85,14 @@ protected ProcessHandler executeRun() throws Throwable {
             process = new ProcessProxy(process, pipedOut, stdoutStream, stderrStream, compiler);
         }
 
-        final OSProcessHandler processHandler = new ColoredProcessHandler(process, null);
+        // subclass to handle destroyProcessImpl to bypass the OS-level SIGKILL/PID reflection as process is synthetic ProcessProxy
+        final ColoredProcessHandler processHandler = new ColoredProcessHandler(process, "launching RoboVm application...") {
+                @Override
+                protected void destroyProcessImpl() {
+                    getProcess().destroy();
+                    notifyProcessTerminated(0);
+                }
+        };
         ProcessTerminatedListener.attach(processHandler);
         return processHandler;
     }
@@ -119,9 +127,9 @@ protected void customizeLaunchParameters(RoboVmRunConfiguration runConfig, Confi
     @Override
     protected ProcessHandler startProcess() throws ExecutionException {
         try {
-            if (getEnvironment().getExecutor().getId().equals(RoboVmRunner.RUN_EXECUTOR)) {
+            if (getEnvironment().getExecutor().getId().equals(DefaultRunExecutor.EXECUTOR_ID)) {
                 return executeRun();
-            } else if (getEnvironment().getExecutor().getId().equals(RoboVmRunner.DEBUG_EXECUTOR)) {
+            } else if (getEnvironment().getExecutor().getId().equals(DefaultDebugExecutor.EXECUTOR_ID)) {
                 return executeRun();
             } else {
                 throw new ExecutionException("Unsupported executor " + getEnvironment().getExecutor().getId());

plugins/idea/src/main/java/org/robovm/idea/running/RoboVmRunner.java

@@ -23,13 +23,14 @@
 import com.intellij.debugger.engine.JavaDebugProcess;
 import com.intellij.debugger.impl.DebuggerSession;
 import com.intellij.debugger.ui.tree.render.BatchEvaluator;
-import com.intellij.execution.DefaultExecutionResult;
 import com.intellij.execution.ExecutionException;
 import com.intellij.execution.ExecutionResult;
 import com.intellij.execution.configurations.RemoteConnection;
 import com.intellij.execution.configurations.RunProfile;
 import com.intellij.execution.configurations.RunProfileState;
 import com.intellij.execution.configurations.RunnerSettings;
+import com.intellij.execution.executors.DefaultDebugExecutor;
+import com.intellij.execution.executors.DefaultRunExecutor;
 import com.intellij.execution.runners.ExecutionEnvironment;
 import com.intellij.execution.runners.GenericProgramRunner;
 import com.intellij.execution.runners.RunContentBuilder;
@@ -38,15 +39,11 @@
 import com.intellij.xdebugger.XDebugProcessStarter;
 import com.intellij.xdebugger.XDebugSession;
 import com.intellij.xdebugger.XDebuggerManager;
-import com.intellij.xdebugger.impl.XDebugSessionImpl;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 public class RoboVmRunner extends GenericProgramRunner<RunnerSettings> {
 
-    public static final String DEBUG_EXECUTOR = "Debug";
-    public static final String RUN_EXECUTOR = "Run";
-
     @NotNull
     @Override
     public String getRunnerId() {
@@ -55,22 +52,22 @@ public String getRunnerId() {
 
     @Override
     public boolean canRun(@NotNull String executorId, @NotNull RunProfile profile) {
-        return (executorId.equals(DEBUG_EXECUTOR) || executorId.equals(RUN_EXECUTOR)) && profile instanceof RoboVmRunConfiguration;
+        return (executorId.equals(DefaultDebugExecutor.EXECUTOR_ID) || executorId.equals(DefaultRunExecutor.EXECUTOR_ID)) && profile instanceof RoboVmRunConfiguration;
     }
 
     @Override
     protected void execute(@NotNull ExecutionEnvironment environment, @Nullable Callback callback, @NotNull RunProfileState state) {
         // we need to pass the run profile info to the compiler so
         // we can decide if this is a debug or release build
         RoboVmRunConfiguration runConfig = (RoboVmRunConfiguration)environment.getRunProfile();
-        runConfig.setDebug(DEBUG_EXECUTOR.equals(environment.getExecutor().getId()));
+        runConfig.setDebug(DefaultDebugExecutor.EXECUTOR_ID.equals(environment.getExecutor().getId()));
         super.execute(environment, callback, state);
     }
 
     @Nullable
     @Override
     protected RunContentDescriptor doExecute(@NotNull RunProfileState state, @NotNull ExecutionEnvironment environment) throws ExecutionException {
-        if(DEBUG_EXECUTOR.equals(environment.getExecutor().getId())) {
+        if(DefaultDebugExecutor.EXECUTOR_ID.equals(environment.getExecutor().getId())) {
             RoboVmRunConfiguration runConfig = (RoboVmRunConfiguration)environment.getRunProfile();
             RemoteConnection connection = new RemoteConnection(true, "127.0.0.1", "" + runConfig.getDebugPort(), false);
             connection.setServerMode(true);
@@ -104,18 +101,16 @@ protected RunContentDescriptor attachVirtualMachine(RunProfileState state,
         // which is an expensive operation when executed first time
         debugProcess.putUserData(BatchEvaluator.REMOTE_SESSION_KEY, Boolean.TRUE);
 
-        return XDebuggerManager.getInstance(env.getProject()).startSession(env, new XDebugProcessStarter() {
+        XDebugProcessStarter starter = new XDebugProcessStarter() {
             @Override
-            @NotNull
-            public XDebugProcess start(@NotNull XDebugSession session) {
-                XDebugSessionImpl sessionImpl = (XDebugSessionImpl)session;
-                ExecutionResult executionResult = debugProcess.getExecutionResult();
-                sessionImpl.addExtraActions(executionResult.getActions());
-                if (executionResult instanceof DefaultExecutionResult) {
-                    sessionImpl.addRestartActions(((DefaultExecutionResult)executionResult).getRestartActions());
-                }
+            public @NotNull XDebugProcess start(final @NotNull XDebugSession session) {
                 return JavaDebugProcess.create(session, debuggerSession);
             }
-        }).getRunContentDescriptor();
+        };
+        // TODO: startSession is deprecated and causes exception
+        // java.lang.Throwable: [Split debugger] RunContentDescriptor should not be used in split mode from XDebugSession.
+        // but replacement is marked as not stabled and can't be used yet
+        return XDebuggerManager.getInstance(env.getProject()).startSession(env, starter)
+            .getRunContentDescriptor();
     }
 }

plugins/idea/src/main/resources/META-INF/com.mobidevelop.robovm.intellij-maven.xml

@@ -1,4 +1,4 @@
-<idea-plugin url="https://github.com/MobiVM/robovm">
+<idea-plugin>
     <extensions defaultExtensionNs="org.jetbrains.idea.maven">
         <importer implementation="org.robovm.idea.maven.sync.RoboVmMavenImporter"/>
     </extensions>