Show al transitive deps in Link Binary With Libraries build phase

Karim Alweheshy · Karim Alweheshy · commit 758949898ed4 · 2025-03-07T04:17:06.000Z
diff --git a/tools/generators/files_and_groups/src/Generator/CreateBuildFileObject.swift b/tools/generators/files_and_groups/src/Generator/CreateBuildFileObject.swift
@@ -42,7 +42,7 @@ extension Generator.CreateBuildFileObject {
             settings = #"settings = {COMPILER_FLAGS = "-fno-objc-arc"; }; "#
         case .compileStub, .source:
             settings = ""
-        case .product, .watchKitExtension:
+        case .product, .watchKitExtension, .framework:
             // Handled in `CreateProductBuildFileObject` and
             // `CreateProductObject`
             preconditionFailure()
diff --git a/tools/generators/lib/PBXProj/src/BuildPhase.swift b/tools/generators/lib/PBXProj/src/BuildPhase.swift
@@ -5,6 +5,7 @@ public enum BuildPhase {
     case sources
     case copySwiftGeneratedHeader
     case embedAppExtensions
+    case linkBinaryWithLibraries
 
     public var name: String {
         switch self {
@@ -16,6 +17,7 @@ Copy Bazel Outputs / Generate Bazel Dependencies (Index Build)
         case .sources: return "Sources"
         case .copySwiftGeneratedHeader: return "Copy Swift Generated Header"
         case .embedAppExtensions: return "Embed App Extensions"
+        case .linkBinaryWithLibraries: return "Frameworks"
         }
     }
 }
diff --git a/tools/generators/lib/PBXProj/src/Identifiers.swift b/tools/generators/lib/PBXProj/src/Identifiers.swift
@@ -89,6 +89,9 @@ FF01000000000000000001\#(byteHexStrings[index]!) \#
             /// The product reference for a target.
             case product = "P"
 
+            /// The framework reference for a target in libraries to link build phase.
+            case framework = "f"
+
             /// A normal file referenced in a `BuildPhase.sources` build phase.
             case source = "0"
 
@@ -186,6 +189,14 @@ FF01000000000000000001\#(byteHexStrings[index]!) \#
                 return #"""
 \#(subIdentifier.shard)00\#(subIdentifier.hash)0000000000FF \#
 /* \#(subIdentifier.path.path) */
+"""#
+
+            case .framework:
+                let basename = subIdentifier.path.path
+                    .split(separator: "/").last!
+                return #"""
+\#(subIdentifier.shard)A8\#(subIdentifier.hash) \#
+/* \#(basename) in Frameworks */
 """#
 
             case .compileStub:
@@ -535,6 +546,7 @@ private extension Identifiers.BuildFiles.FileType {
     var buildPhase: BuildPhase {
         switch self {
         case .product: preconditionFailure() // product reference used as build file
+        case .framework: return .linkBinaryWithLibraries
         case .source: return .sources
         case .nonArcSource: return .sources
         case .compileStub: return .sources
@@ -566,6 +578,7 @@ extension BuildPhase {
         case .sources: return "06"
         case .copySwiftGeneratedHeader: return "07"
         case .embedAppExtensions: return "08"
+        case .linkBinaryWithLibraries: return "09"
         }
     }
 }
diff --git a/tools/generators/pbxnativetargets/src/Generator/CalculatePlatformVariantBuildSettings.swift b/tools/generators/pbxnativetargets/src/Generator/CalculatePlatformVariantBuildSettings.swift
@@ -188,7 +188,6 @@ extension Generator.CalculatePlatformVariantBuildSettings {
                 key: "LIBRARY_SEARCH_PATHS",
                 value: platformVariant.librarySearchPaths
                     .map { $0.path.quoteIfNeeded }
-                    // TODO: See if we can not sort, or sort earlier
                     .sorted()
                     .joined(separator: " ")
                     .pbxProjEscaped
diff --git a/tools/generators/pbxnativetargets/src/Generator/CalculatePlatformVariants.swift b/tools/generators/pbxnativetargets/src/Generator/CalculatePlatformVariants.swift
@@ -59,6 +59,7 @@ extension Generator.CalculatePlatformVariants {
     ) {
         var srcs: [[BazelPath]] = []
         var nonArcSrcs: [[BazelPath]] = []
+        var librariesToLinkPaths: [[BazelPath]] = []
         var excludableFilesKeysWithValues: [(TargetID, Set<BazelPath>)] = []
         for id in ids {
             let targetArguments = try targetArguments.value(
@@ -68,6 +69,7 @@ extension Generator.CalculatePlatformVariants {
 
             srcs.append(targetArguments.srcs)
             nonArcSrcs.append(targetArguments.nonArcSrcs)
+            librariesToLinkPaths.append(targetArguments.librariesToLinkPaths)
 
             excludableFilesKeysWithValues.append(
                 (
@@ -142,7 +144,8 @@ extension Generator.CalculatePlatformVariants {
 
         let consolidatedInputs = Target.ConsolidatedInputs(
             srcs: consolidatePaths(srcs),
-            nonArcSrcs: consolidatePaths(nonArcSrcs)
+            nonArcSrcs: consolidatePaths(nonArcSrcs),
+            librariesToLinkPaths: consolidatePaths(librariesToLinkPaths)
         )
 
         return (platformVariants, allConditionalFiles, consolidatedInputs)
diff --git a/tools/generators/pbxnativetargets/src/Generator/CreateBuildPhases.swift b/tools/generators/pbxnativetargets/src/Generator/CreateBuildPhases.swift
@@ -13,6 +13,10 @@ extension Generator {
             CreateEmbedAppExtensionsBuildPhaseObject
         private let createProductBuildFileObject: CreateProductBuildFileObject
         private let createSourcesBuildPhaseObject: CreateSourcesBuildPhaseObject
+        private let createLinkBinaryWithLibrariesBuildPhaseObject:
+            CreateLinkBinaryWithLibrariesBuildPhaseObject
+        private let createFrameworkObject: CreateFrameworkObject
+        private let createFrameworkBuildFileObject: CreateFrameworkBuildFileObject
 
         private let callable: Callable
 
@@ -31,6 +35,10 @@ extension Generator {
                 CreateEmbedAppExtensionsBuildPhaseObject,
             createProductBuildFileObject: CreateProductBuildFileObject,
             createSourcesBuildPhaseObject: CreateSourcesBuildPhaseObject,
+            createLinkBinaryWithLibrariesBuildPhaseObject:
+                CreateLinkBinaryWithLibrariesBuildPhaseObject,
+            createFrameworkObject: CreateFrameworkObject,
+            createFrameworkBuildFileObject: CreateFrameworkBuildFileObject,
             callable: @escaping Callable = Self.defaultCallable
         ) {
             self.createBazelIntegrationBuildPhaseObject =
@@ -44,6 +52,9 @@ extension Generator {
                 createEmbedAppExtensionsBuildPhaseObject
             self.createProductBuildFileObject = createProductBuildFileObject
             self.createSourcesBuildPhaseObject = createSourcesBuildPhaseObject
+            self.createLinkBinaryWithLibrariesBuildPhaseObject = createLinkBinaryWithLibrariesBuildPhaseObject
+            self.createFrameworkObject = createFrameworkObject
+            self.createFrameworkBuildFileObject = createFrameworkBuildFileObject
 
             self.callable = callable
         }
@@ -86,7 +97,10 @@ extension Generator {
                 /*createEmbedAppExtensionsBuildPhaseObject:*/
                     createEmbedAppExtensionsBuildPhaseObject,
                 /*createProductBuildFileObject:*/ createProductBuildFileObject,
-                /*createSourcesBuildPhaseObject:*/ createSourcesBuildPhaseObject
+                /*createSourcesBuildPhaseObject:*/ createSourcesBuildPhaseObject,
+                /*createLinkBinaryWithLibrariesBuildPhaseObject:*/ createLinkBinaryWithLibrariesBuildPhaseObject,
+                /*createFrameworkObject:*/ createFrameworkObject,
+                /*createFrameworkBuildFileObject:*/ createFrameworkBuildFileObject
             )
         }
     }
@@ -116,7 +130,11 @@ extension Generator.CreateBuildPhases {
         _ createEmbedAppExtensionsBuildPhaseObject:
             Generator.CreateEmbedAppExtensionsBuildPhaseObject,
         _ createProductBuildFileObject: Generator.CreateProductBuildFileObject,
-        _ createSourcesBuildPhaseObject: Generator.CreateSourcesBuildPhaseObject
+        _ createSourcesBuildPhaseObject: Generator.CreateSourcesBuildPhaseObject,
+        _ createLinkBinaryWithLibrariesBuildPhaseObject:
+            Generator.CreateLinkBinaryWithLibrariesBuildPhaseObject,
+        _ createFrameworkObject: Generator.CreateFrameworkObject,
+        _ createFrameworkBuildFileObject: Generator.CreateFrameworkBuildFileObject
     ) -> (
         buildPhases: [Object],
         buildFileObjects: [Object],
@@ -144,7 +162,11 @@ extension Generator.CreateBuildPhases {
         createEmbedAppExtensionsBuildPhaseObject:
             Generator.CreateEmbedAppExtensionsBuildPhaseObject,
         createProductBuildFileObject: Generator.CreateProductBuildFileObject,
-        createSourcesBuildPhaseObject: Generator.CreateSourcesBuildPhaseObject
+        createSourcesBuildPhaseObject: Generator.CreateSourcesBuildPhaseObject,
+        createLinkBinaryWithLibrariesBuildPhaseObject:
+            Generator.CreateLinkBinaryWithLibrariesBuildPhaseObject,
+        createFrameworkObject: Generator.CreateFrameworkObject,
+        createFrameworkBuildFileObject: Generator.CreateFrameworkBuildFileObject
     ) -> (
         buildPhases: [Object],
         buildFileObjects: [Object],
@@ -259,6 +281,45 @@ extension Generator.CreateBuildPhases {
             )
         }
 
+        let librariesToLinkSubIdentifiers = consolidatedInputs.librariesToLinkPaths.map { bazelPath in
+            return (
+                bazelPath,
+                createBuildFileSubIdentifier(
+                    BazelPath(bazelPath.path.split(separator: "/").last.map(String.init)!),
+                    type: .framework,
+                    shard: shard
+                ),
+                createBuildFileSubIdentifier(
+                    bazelPath,
+                    type: .framework,
+                    shard: shard
+                )
+            )
+        }
+        librariesToLinkSubIdentifiers
+            .forEach { bazelPath, buildSubIdentifier, frameworkSubIdentifier  in
+                buildFileObjects.append(
+                    createFrameworkBuildFileObject(
+                        frameworkSubIdentifier: frameworkSubIdentifier,
+                        subIdentifier: buildSubIdentifier
+                    )
+                )
+                buildFileObjects.append(
+                    createFrameworkObject(
+                        frameworkPath: bazelPath,
+                        subIdentifier: frameworkSubIdentifier
+                    )
+                )
+            }
+        buildPhases.append(
+            createLinkBinaryWithLibrariesBuildPhaseObject(
+                subIdentifier: identifier.subIdentifier,
+                librariesToLinkIdentifiers: librariesToLinkSubIdentifiers
+                    .map { $0.1 }
+                    .map { Identifiers.BuildFiles.id(subIdentifier: $0) }
+            )
+        )
+
         return (buildPhases, buildFileObjects, buildFileSubIdentifiers)
     }
 }
diff --git a/tools/generators/pbxnativetargets/src/Generator/CreateFrameworkBuildFileObject.swift b/tools/generators/pbxnativetargets/src/Generator/CreateFrameworkBuildFileObject.swift
@@ -0,0 +1,50 @@
+import PBXProj
+
+extension Generator {
+    struct CreateFrameworkBuildFileObject {
+        private let callable: Callable
+
+        /// - Parameters:
+        ///   - callable: The function that will be called in
+        ///     `callAsFunction()`.
+        init(callable: @escaping Callable = Self.defaultCallable) {
+            self.callable = callable
+        }
+
+        /// Creates a `PBXBuildFile` element.
+        func callAsFunction(
+            frameworkSubIdentifier: Identifiers.BuildFiles.SubIdentifier,
+            subIdentifier: Identifiers.BuildFiles.SubIdentifier
+        ) -> Object {
+            return callable(
+                /*frameworkSubIdentifier:*/ frameworkSubIdentifier,
+                /*subIdentifier:*/ subIdentifier
+            )
+        }
+    }
+}
+
+// MARK: - CreateFrameworkBuildFileObject.Callable
+
+extension Generator.CreateFrameworkBuildFileObject {
+    typealias Callable = (
+        _ frameworkSubIdentifier: Identifiers.BuildFiles.SubIdentifier,
+        _ subIdentifier: Identifiers.BuildFiles.SubIdentifier
+    ) -> Object
+
+    static func defaultCallable(
+        frameworkSubIdentifier: Identifiers.BuildFiles.SubIdentifier,
+        subIdentifier: Identifiers.BuildFiles.SubIdentifier
+    ) -> Object {
+        let fileRef = Identifiers.BuildFiles
+            .id(subIdentifier: frameworkSubIdentifier)
+        let content = #"""
+{isa = PBXBuildFile; fileRef = \#(fileRef); }
+"""#
+
+        return Object(
+            identifier: Identifiers.BuildFiles.id(subIdentifier: subIdentifier),
+            content: content
+        )
+    }
+}
diff --git a/tools/generators/pbxnativetargets/src/Generator/CreateFrameworkObject.swift b/tools/generators/pbxnativetargets/src/Generator/CreateFrameworkObject.swift
@@ -0,0 +1,49 @@
+import PBXProj
+
+extension Generator {
+    struct CreateFrameworkObject {
+        private let callable: Callable
+        private static var existingFrameworkPaths = [BazelPath]()
+
+        /// - Parameters:
+        ///   - callable: The function that will be called in
+        ///     `callAsFunction()`.
+        init(callable: @escaping Callable = Self.defaultCallable) {
+            self.callable = callable
+        }
+
+        /// Creates a `PBXBuildFile` element.
+        func callAsFunction(
+            frameworkPath: BazelPath,
+            subIdentifier: Identifiers.BuildFiles.SubIdentifier
+        ) -> Object {
+            return callable(
+                /*frameworkPath:*/ frameworkPath,
+                /*subIdentifier:*/ subIdentifier
+            )
+        }
+    }
+}
+
+// MARK: - CreateProductObject.Callable
+
+extension Generator.CreateFrameworkObject {
+    typealias Callable = (
+        _ frameworkPath: BazelPath,
+        _ subIdentifier: Identifiers.BuildFiles.SubIdentifier
+    ) -> Object
+
+    static func defaultCallable(
+        frameworkPath: BazelPath,
+        subIdentifier: Identifiers.BuildFiles.SubIdentifier
+    ) -> Object {
+        let content = #"""
+{isa = PBXFileReference; lastKnownFileType = archive.ar; name = "\#(frameworkPath.path.split(separator: "/").last!)"; path = "\#(frameworkPath.path)"; sourceTree = "<group>"; }
+"""#
+
+        return Object(
+            identifier: Identifiers.BuildFiles.id(subIdentifier: subIdentifier),
+            content: content
+        )
+    }
+}
diff --git a/tools/generators/pbxnativetargets/src/Generator/CreateLinkBinaryWithLibrariesBuildPhaseObject.swift b/tools/generators/pbxnativetargets/src/Generator/CreateLinkBinaryWithLibrariesBuildPhaseObject.swift
@@ -0,0 +1,59 @@
+import PBXProj
+
+extension Generator {
+    struct CreateLinkBinaryWithLibrariesBuildPhaseObject {
+        private let callable: Callable
+
+        /// - Parameters:
+        ///   - callable: The function that will be called in
+        ///     `callAsFunction()`.
+        init(callable: @escaping Callable = Self.defaultCallable) {
+            self.callable = callable
+        }
+
+        /// Creates the `PBXSourcesBuildPhase` object for a target.
+        func callAsFunction(
+            subIdentifier: Identifiers.Targets.SubIdentifier,
+            librariesToLinkIdentifiers: [String]
+        ) -> Object {
+            return callable(
+                /*subIdentifier:*/ subIdentifier,
+                /*buildFileIdentifiers:*/ librariesToLinkIdentifiers
+            )
+        }
+    }
+}
+
+// MARK: - CreateSourcesBuildPhaseObject.Callable
+
+extension Generator.CreateLinkBinaryWithLibrariesBuildPhaseObject {
+    typealias Callable = (
+        _ subIdentifier: Identifiers.Targets.SubIdentifier,
+        _ librariesToLinkIdentifiers: [String]
+    ) -> Object
+
+    static func defaultCallable(
+        subIdentifier: Identifiers.Targets.SubIdentifier,
+        librariesToLinkIdentifiers: [String]
+    ) -> Object {
+        // The tabs for indenting are intentional
+        let content = #"""
+{
+			isa = PBXFrameworksBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+\#(librariesToLinkIdentifiers.map { "\t\t\t\t\($0),\n" }.joined())\#
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+		}
+"""#
+
+        return Object(
+            identifier: Identifiers.Targets.buildPhase(
+                .linkBinaryWithLibraries,
+                subIdentifier: subIdentifier
+            ),
+            content: content
+        )
+    }
+}
diff --git a/tools/generators/pbxnativetargets/src/Generator/Environment.swift b/tools/generators/pbxnativetargets/src/Generator/Environment.swift
@@ -32,7 +32,12 @@ extension Generator.Environment {
                 createProductBuildFileObject:
                     Generator.CreateProductBuildFileObject(),
                 createSourcesBuildPhaseObject:
-                    Generator.CreateSourcesBuildPhaseObject()
+                    Generator.CreateSourcesBuildPhaseObject(),
+                createLinkBinaryWithLibrariesBuildPhaseObject:
+                    Generator.CreateLinkBinaryWithLibrariesBuildPhaseObject(),
+                createFrameworkObject: Generator.CreateFrameworkObject(),
+                createFrameworkBuildFileObject:
+                    Generator.CreateFrameworkBuildFileObject()
             ),
             createProductObject: Generator.CreateProductObject(),
             createTargetObject: Generator.CreateTargetObject(),
diff --git a/tools/generators/pbxnativetargets/src/Generator/Target.swift b/tools/generators/pbxnativetargets/src/Generator/Target.swift
diff --git a/xcodeproj/internal/files/linker_input_files.bzl b/xcodeproj/internal/files/linker_input_files.bzl

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ public enum BuildPhase {`
`5`	`5`	`case sources`
`6`	`6`	`case copySwiftGeneratedHeader`
`7`	`7`	`case embedAppExtensions`
	`8`	`+ case linkBinaryWithLibraries`
`8`	`9`
`9`	`10`	`public var name: String {`
`10`	`11`	`switch self {`
`@@ -16,6 +17,7 @@ Copy Bazel Outputs / Generate Bazel Dependencies (Index Build)`
`16`	`17`	`case .sources: return "Sources"`
`17`	`18`	`case .copySwiftGeneratedHeader: return "Copy Swift Generated Header"`
`18`	`19`	`case .embedAppExtensions: return "Embed App Extensions"`
	`20`	`+ case .linkBinaryWithLibraries: return "Frameworks"`
`19`	`21`	`}`
`20`	`22`	`}`
`21`	`23`	`}`