Skip to content

Commit db27460

Browse files
authored
Feature/use rectools lightfm (#165)
- Used `rectools-lightfm` package instead of original `lightfm`
1 parent 374b4ae commit db27460

File tree

3 files changed

+24
-30
lines changed

3 files changed

+24
-30
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
- `r_precision` parameter to `Precision` metric ([#155](https://github.com/MobileTeleSystems/RecTools/pull/155))
1919

2020
### Fixed
21-
- Used the latest version of `lightfm` that allows to install it using `poetry>=1.5.0` ([#141](https://github.com/MobileTeleSystems/RecTools/pull/141))
21+
- Used `rectools-lightfm` instead of pure `lightfm` that allowed to install it using `poetry>=1.5.0` ([#165](https://github.com/MobileTeleSystems/RecTools/pull/165))
2222
- Added restriction to `pytorch` version for MacOSX + x86_64 that allows to install it on such platforms ([#142](https://github.com/MobileTeleSystems/RecTools/pull/142))
2323
- `PopularInCategoryModel` fitting for multiple times, `cross_validate` compatibility, behaviour with empty category interactions ([#163](https://github.com/MobileTeleSystems/RecTools/pull/163))
2424

poetry.lock

Lines changed: 20 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,7 @@ typeguard = "^4.1.0"
7171

7272

7373
# The latest released version of lightfm is 1.17 and it's not compatible with PEP-517 installers (like latest poetry versions).
74-
# So we use the latest commit from the master branch.
75-
# Will update to the latest version when it's released.
76-
lightfm = {git = "https://github.com/lyst/lightfm", rev = "0c9c31e", python = "<3.12", optional = true}
74+
rectools-lightfm = {version="1.17.1", python = "<3.12", optional = true}
7775

7876
nmslib = {version = "^2.0.4", python = "<3.11", optional = true}
7977

@@ -89,12 +87,12 @@ plotly = {version="^5.22.0", optional = true}
8987

9088

9189
[tool.poetry.extras]
92-
lightfm = ["lightfm"]
90+
lightfm = ["rectools-lightfm"]
9391
nmslib = ["nmslib"]
9492
torch = ["torch", "pytorch-lightning"]
9593
visuals = ["ipywidgets", "plotly"]
9694
all = [
97-
"lightfm",
95+
"rectools-lightfm",
9896
"nmslib",
9997
"torch", "pytorch-lightning",
10098
"ipywidgets", "plotly",

0 commit comments

Comments
 (0)