[DOP-22530] Allow multi value GET /v1/locations?location_type=...

Author: dolfinus

data_rentgen/db/repositories/location.py

@@ -51,16 +51,15 @@ async def paginate(
         page: int,
         page_size: int,
         location_ids: Collection[int],
-        location_type: str | None,
+        location_type: Collection[str],
         search_query: str | None,
     ) -> PaginationDTO[Location]:
         where = []
-
         if location_ids:
             where.append(Location.id == any_(list(location_ids)))  # type: ignore[arg-type]
-
         if location_type:
-            where.append(Location.type == location_type)
+            location_type_lower = [location_type.lower() for location_type in location_type]
+            where.append(Location.type == any_(location_type_lower))  # type: ignore[arg-type]
 
         query: Select | CompoundSelect
         order_by: list[ColumnElement | SQLColumnExpression]

data_rentgen/server/schemas/v1/location.py

@@ -66,10 +66,10 @@ class LocationPaginateQueryV1(PaginateQueryV1):
     """Query params for Location paginate request."""
 
     location_id: list[int] = Field(default_factory=list, description="Location id")
-    location_type: str | None = Field(
-        default=None,
+    location_type: list[str] = Field(
+        default_factory=list,
         description="Location type",
-        examples=["kafka", "hdfs", "yarn"],
+        examples=[["kafka", "hdfs"], ["yarn"]],
     )
     search_query: str | None = Field(
         default=None,

data_rentgen/server/services/location.py

@@ -62,7 +62,7 @@ async def paginate(
         page: int,
         page_size: int,
         location_ids: Collection[int],
-        location_type: str | None,
+        location_type: Collection[str],
         search_query: str | None,
     ) -> LocationServicePaginatedResult:
         pagination = await self._uow.location.paginate(

docs/changelog/next_release/328.feature.4.rst

@@ -0,0 +1 @@
+Allow passing multiple ``location_type`` filters to ``GET /v1/locations``.

tests/test_server/test_locations/test_get_locations.py

@@ -82,7 +82,7 @@ async def test_get_locations_with_type_filter(
     response = await test_client.get(
         "v1/locations",
         headers={"Authorization": f"Bearer {mocked_user.access_token}"},
-        params={"location_type": location_type},
+        params={"location_type": location_type.upper()},  # case-insensitive
     )
 
     assert response.status_code == HTTPStatus.OK, response.json()