[DOP-22361] fix after review

Author: Zabilsya

src/entities/transformation/ui/FilterRows/index.tsx

@@ -1,24 +1,23 @@
 import { Button, Form } from 'antd';
 import React, { memo, useLayoutEffect } from 'react';
 
-import { TransformationRowsFilter, TransformationType } from '../../types';
+import { Transformations, TransformationType } from '../../types';
 
 import { FilterRowsItem } from './components';
 
 export const FilterRows = memo(() => {
   const formInstance = Form.useFormInstance();
-  const filterRowsValues: TransformationRowsFilter['filters'] | undefined = formInstance.getFieldValue([
+  const filterRowsValues: Transformations[0]['filters'] | undefined = formInstance.getFieldValue([
     'transformations',
     TransformationType.ROWS_FILTER,
   ]);
 
-  /** Add at least one element to array form value */
+  /** Add at least one element to array form value here,
+   * because it is inconvenient to check for the presence of a default value of this array,
+   * when forming a request to backend or initial form values */
   useLayoutEffect(() => {
     if (!filterRowsValues || !filterRowsValues.length) {
-      formInstance.setFieldValue(
-        ['transformations', TransformationType.ROWS_FILTER],
-        [{ column: '', type: undefined }],
-      );
+      formInstance.setFieldValue(['transformations', TransformationType.ROWS_FILTER], [{}]);
     }
   }, [formInstance, filterRowsValues]);
 

src/features/transfer/MutateTransferForm/components/TransferConnectionsCanvas/utils/getInitialEdges/index.ts

@@ -5,6 +5,7 @@ import { TransferCanvasNodeData } from '../../types';
 export const getInitialEdges = (nodes: TransferCanvasNodeData[]): Edge[] => {
   const edges: Edge[] = [];
 
+  /** for instead of Array.prototype.map, because we need to skip first element */
   for (let i = 1; i < nodes.length; i++) {
     edges.push({
       id: `edge-${i}`,

src/shared/ui/CronSelect/hooks/useCron/useCron.ts

@@ -13,6 +13,7 @@ export const useCron = ({ value, onChange = () => undefined }: UseCronProps) =>
   /** Invoke onChange callback to set default value to antd Form if not specified */
   useEffect(() => {
     handleChange();
+    /** Disable eslint, because need to invoke useEffect only after mounting */
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);