Skip to content

Commit d9d7443

Browse files
committed
Make S3 bucket styles less cryptic
1 parent d12acac commit d9d7443

File tree

3 files changed

+11
-7
lines changed
  • src
    • entities/connection/ui/ConnectionTypeForm/components/ConnectionS3
    • shared/config/i18n/translations

3 files changed

+11
-7
lines changed

src/entities/connection/ui/ConnectionTypeForm/components/ConnectionS3/index.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,20 @@ export const ConnectionS3 = () => {
2121
<Input size="large" placeholder="s3.mycompany.com" />
2222
</Form.Item>
2323
<ConnectionHttpProtocol />
24+
<Form.Item label={t('s3.bucket')} name={['connection_data', 'bucket']} rules={[{ required: true }]}>
25+
<Input size="large" />
26+
</Form.Item>
2427
<Form.Item
2528
label={t('s3.bucketStyle')}
2629
name={['connection_data', 'bucket_style']}
2730
rules={[{ required: true }]}
2831
initialValue="domain"
2932
>
3033
<Radio.Group>
31-
<Radio.Button value="domain">bucket.s3.mycompany.com</Radio.Button>
32-
<Radio.Button value="path">s3.mycompany.com/bucket</Radio.Button>
34+
<Radio.Button value="domain">{t('s3.bucketStyleDomain')}</Radio.Button>
35+
<Radio.Button value="path">{t('s3.bucketStylePath')}</Radio.Button>
3336
</Radio.Group>
3437
</Form.Item>
35-
<Form.Item label={t('s3.bucket')} name={['connection_data', 'bucket']} rules={[{ required: true }]}>
36-
<Input size="large" />
37-
</Form.Item>
3838
<Form.Item label={t('s3.region')} name={['connection_data', 'region']}>
3939
<Input size="large" placeholder="us-east-1" />
4040
</Form.Item>

src/shared/config/i18n/translations/en.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@
6868
"serviceNameOrSidRequired": "Either Service Name or SID is required"
6969
},
7070
"s3": {
71-
"bucketStyle": "Bucket style",
7271
"bucket": "Bucket name",
72+
"bucketStyle": "Bucket style",
73+
"bucketStyleDomain": "Domain",
74+
"bucketStylePath": "Path",
7375
"region": "Region",
7476
"accessKey": "Access key",
7577
"secretKey": "Secret key"

src/shared/config/i18n/translations/ru.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,10 @@
6969
"sid": "SID базы данных"
7070
},
7171
"s3": {
72-
"bucketStyle": "Стиль бакета",
7372
"bucket": "Название бакета",
73+
"bucketStyle": "Стиль бакета",
74+
"bucketStyleDomain": "Домен",
75+
"bucketStylePath": "Путь",
7476
"region": "Регион",
7577
"accessKey": "Ключ доступа",
7678
"secretKey": "Секретный ключ"

0 commit comments

Comments
 (0)