Fix S3 and IcebergRestS3 tests

Author: dolfinus

syncmaster/dto/connections.py

@@ -85,8 +85,9 @@ class IcebergRESTCatalogS3ConnectionDTO(ConnectionDTO):
     s3_secret_key: str
     metastore_username: str
     metastore_password: str
-    s3_port: int | None = None
-    s3_protocol: str = "https"
+    s3_port: int | None
+    s3_protocol: str
+    additional_params: dict
     type: ClassVar[str] = "iceberg_rest_s3"
 
 

syncmaster/schemas/v1/connections/iceberg.py

@@ -26,6 +26,7 @@ class CreateIcebergRESTCatalogS3ConnectionDataSchema(BaseModel):
     s3_bucket: str
     s3_region: str
     s3_bucket_style: Literal["domain", "path"] = "path"
+    additional_params: dict = Field(default_factory=dict)
 
 
 class ReadIcebergRESTCatalogS3ConnectionDataSchema(BaseModel):
@@ -37,6 +38,7 @@ class ReadIcebergRESTCatalogS3ConnectionDataSchema(BaseModel):
     s3_bucket: str
     s3_region: str
     s3_bucket_style: Literal["domain", "path"] = "path"
+    additional_params: dict = Field(default_factory=dict)
 
 
 class CreateIcebergConnectionSchema(CreateConnectionBaseSchema):

syncmaster/schemas/v1/connections/s3.py

@@ -23,6 +23,7 @@ class CreateS3ConnectionDataSchema(BaseModel):
     region: str | None = None
     protocol: Literal["http", "https"] = "https"
     bucket_style: Literal["domain", "path"] = "domain"
+    additional_params: dict = Field(default_factory=dict)
 
     @model_validator(mode="before")
     def validate_port(cls, values: dict) -> dict:
@@ -43,6 +44,7 @@ class ReadS3ConnectionDataSchema(BaseModel):
     region: str | None = None
     protocol: Literal["http", "https"] = "https"
     bucket_style: Literal["domain", "path"] = "domain"
+    additional_params: dict = Field(default_factory=dict)
 
 
 class CreateS3ConnectionSchema(CreateConnectionBaseSchema):