Skip to content

Commit 1f9dc55

Browse files
committed
Remove using pydantic schema from db repo
1 parent cd4b2b9 commit 1f9dc55

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

syncmaster/db/repositories/queue.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
from syncmaster.exceptions.group import GroupNotFoundError
1616
from syncmaster.exceptions.queue import DuplicatedQueueNameError, QueueNotFoundError
1717

18-
# TODO: remove HTTP response schemes from repositories, these are different layers
19-
from syncmaster.schemas.v1.queue import UpdateQueueSchema
20-
2118

2219
class QueueRepository(RepositoryWithOwner[Queue]):
2320
def __init__(self, session: AsyncSession):
@@ -69,16 +66,12 @@ async def paginate(
6966
page_size=page_size,
7067
)
7168

72-
async def update(
73-
self,
74-
queue_id: int,
75-
queue_data: UpdateQueueSchema,
76-
) -> Queue:
69+
async def update(self, queue_id: int, name: str, description: str) -> Queue:
7770
try:
7871
return await self._update(
7972
Queue.id == queue_id,
80-
name=queue_data.name,
81-
description=queue_data.description,
73+
name=name,
74+
description=description,
8275
)
8376
except IntegrityError as e:
8477
self._raise_error(e)

syncmaster/server/api/v1/queue.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ async def update_queue(
118118
async with unit_of_work:
119119
queue = await unit_of_work.queue.update(
120120
queue_id=queue_id,
121-
queue_data=queue_data,
121+
name=queue_data.name,
122+
description=queue_data.description,
122123
)
123124
return ReadQueueSchema.model_validate(queue, from_attributes=True)
124125

0 commit comments

Comments
 (0)