Skip to content

Commit 2b5412d

Browse files
committed
Small test style improvements
1 parent 73dbce0 commit 2b5412d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/test_unit/test_groups/test_read_groups.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,10 @@ async def test_filter_groups_by_role(
148148
expected_total: int,
149149
expected_roles: set,
150150
):
151-
role_query = f"?role={role}" if role else ""
152151
response = await client.get(
153-
f"v1/groups{role_query}",
152+
"v1/groups",
154153
headers={"Authorization": f"Bearer {user_with_many_roles.token}"},
154+
params={"role": role} if role else None,
155155
)
156156

157157
assert response.status_code == 200, response.text
@@ -181,10 +181,10 @@ async def test_filter_groups_not_applied_to_superuser(
181181
role: str,
182182
expected_total: int,
183183
):
184-
role_query = f"?role={role}" if role else ""
185184
response = await client.get(
186-
f"v1/groups{role_query}",
185+
"v1/groups",
187186
headers={"Authorization": f"Bearer {superuser.token}"},
187+
params={"role": role} if role else None,
188188
)
189189

190190
assert response.status_code == 200, response.text

tests/test_unit/test_queues/test_read_queues.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ async def test_group_member_can_read_queues(
2121
):
2222
user = mock_group.get_member_of_role(role_guest_plus)
2323
response = await client.get(
24-
f"v1/queues?group_id={mock_group.id}",
24+
f"v1/queues",
2525
headers={"Authorization": f"Bearer {user.token}"},
2626
params={"group_id": mock_group.id},
2727
)

0 commit comments

Comments
 (0)