[DOP-19896] Add Clickhouse API schema

Author: Ilyas Gasanov

syncmaster/schemas/v1/connection_types.py

@@ -6,15 +6,15 @@
 HIVE_TYPE = Literal["hive"]
 ORACLE_TYPE = Literal["oracle"]
 POSTGRES_TYPE = Literal["postgres"]
+CLICKHOUSE_TYPE = Literal["clickhouse"]
 S3_TYPE = Literal["s3"]
 HDFS_TYPE = Literal["hdfs"]
-CLICKHOUSE_TYPE = Literal["clickhouse"]
 
 
 class ConnectionType(str, Enum):
     POSTGRES = "postgres"
     HIVE = "hive"
     ORACLE = "oracle"
+    CLICKHOUSE = "clickhouse"
     S3 = "s3"
     HDFS = "hdfs"
-    CLICKHOUSE = "clickhouse"

tests/test_unit/test_connections/test_create_all_connection/test_create_clickhouse_connection.py

@@ -32,7 +32,7 @@ async def test_developer_plus_can_create_clickhouse_connection(
             "connection_data": {
                 "type": "clickhouse",
                 "host": "127.0.0.1",
-                "port": 1521,
+                "port": 8123,
                 "database": "database_name",
             },
             "auth_data": {
@@ -78,66 +78,3 @@ async def test_developer_plus_can_create_clickhouse_connection(
             "user": decrypted["user"],
         },
     }
-
-
-async def test_developer_plus_cannot_create_connection_with_type_mismatch(
-    client: AsyncClient,
-    group: MockGroup,
-    session: AsyncSession,
-    settings: Settings,
-    role_developer_plus: UserTestRoles,
-    event_loop,
-    request,
-):
-    # Arrange
-    user = group.get_member_of_role(role_developer_plus)
-
-    # Act
-    result = await client.post(
-        "v1/connections",
-        headers={"Authorization": f"Bearer {user.token}"},
-        json={
-            "group_id": group.id,
-            "name": "New connection",
-            "description": "",
-            "connection_data": {
-                "type": "postgres",
-                "host": "127.0.0.1",
-                "port": 5432,
-                "database_name": "postgres",
-            },
-            "auth_data": {
-                "type": "clickhouse",
-                "user": "user",
-                "password": "secret",
-            },
-        },
-    )
-
-    # Assert
-    assert result.json() == {
-        "error": {
-            "code": "invalid_request",
-            "message": "Invalid request",
-            "details": [
-                {
-                    "context": {},
-                    "input": {
-                        "group_id": group.id,
-                        "name": "New connection",
-                        "description": "",
-                        "connection_data": {
-                            "type": "postgres",
-                            "host": "127.0.0.1",
-                            "port": 5432,
-                            "database_name": "postgres",
-                        },
-                        "auth_data": {"type": "clickhouse", "user": "user", "password": "secret"},
-                    },
-                    "location": ["body"],
-                    "message": "Value error, Connection data and auth data must have same types",
-                    "code": "value_error",
-                },
-            ],
-        },
-    }

tests/test_unit/test_connections/test_read_connections.py

@@ -307,10 +307,10 @@ async def test_search_connections_with_nonexistent_query(
 @pytest.mark.parametrize(
     "filter_params, expected_total",
     [
-        ({}, 5),  # No filters applied, expecting all connections
+        ({}, 6),  # No filters applied, expecting all connections
         ({"type": ["oracle"]}, 1),
         ({"type": ["postgres", "hive"]}, 2),
-        ({"type": ["postgres", "hive", "oracle", "hdfs", "s3"]}, 5),
+        ({"type": ["postgres", "hive", "oracle", "clickhouse", "hdfs", "s3"]}, 6),
     ],
     ids=[
         "no_filters",

tests/test_unit/test_transfers/test_create_transfer.py

@@ -370,12 +370,12 @@ async def test_superuser_can_create_transfer(
                             "location": ["body", "source_params"],
                             "message": (
                                 "Input tag 'new some connection type' found using 'type' "
-                                "does not match any of the expected tags: 'postgres', 'hdfs', 'hive', 'oracle', 's3'"
+                                "does not match any of the expected tags: 'postgres', 'hdfs', 'hive', 'oracle', 'clickhouse', 's3'"
                             ),
                             "code": "union_tag_invalid",
                             "context": {
                                 "discriminator": "'type'",
-                                "expected_tags": "'postgres', 'hdfs', 'hive', 'oracle', 's3'",
+                                "expected_tags": "'postgres', 'hdfs', 'hive', 'oracle', 'clickhouse', 's3'",
                                 "tag": "new some connection type",
                             },
                             "input": {