[BREAKING] - remove is_deleted for Connection model (#170)

* [BREAKING] - remove is_deleted for Connection model

* [BREAKING] - split tests

Author: maxim-lixakov

docs/changelog/next_release/170.breaking.rst

@@ -0,0 +1 @@
+Add deletion of **connections** records instead of marking them as deleted

syncmaster/db/migrations/versions/2023-11-23_0004_create_connection_table.py

@@ -33,7 +33,6 @@ def upgrade():
         sa.Column("name", sa.String(length=128), nullable=False),
         sa.Column("description", sa.String(length=512), nullable=False),
         sa.Column("data", sa.JSON(), nullable=False),
-        sa.Column("is_deleted", sa.Boolean(), nullable=False),
         sa.Column("created_at", sa.DateTime(), server_default=sa.text("now()"), nullable=False),
         sa.Column("updated_at", sa.DateTime(), server_default=sa.text("now()"), nullable=False),
         sa.Column("search_vector", postgresql.TSVECTOR(), sa.Computed(sql_expression, persisted=True), nullable=False),

syncmaster/db/models/connection.py

@@ -8,12 +8,12 @@
 from sqlalchemy.dialects.postgresql import TSVECTOR
 from sqlalchemy.orm import Mapped, declared_attr, mapped_column, relationship
 
-from syncmaster.db.mixins import DeletableMixin, ResourceMixin, TimestampMixin
+from syncmaster.db.mixins import ResourceMixin, TimestampMixin
 from syncmaster.db.models.base import Base
 from syncmaster.db.models.group import Group
 
 
-class Connection(Base, ResourceMixin, DeletableMixin, TimestampMixin):
+class Connection(Base, ResourceMixin, TimestampMixin):
     data: Mapped[dict[str, Any]] = mapped_column(JSON, nullable=False, default={})
 
     group: Mapped[Group] = relationship("Group")

syncmaster/db/repositories/connection.py

@@ -32,7 +32,6 @@ async def paginate(
         connection_type: list[str] | None = None,
     ) -> Pagination:
         stmt = select(Connection).where(
-            Connection.is_deleted.is_(False),
             Connection.group_id == group_id,
         )
         if search_query:
@@ -53,7 +52,7 @@ async def read_by_id(
         self,
         connection_id: int,
     ) -> Connection:
-        stmt = select(Connection).where(Connection.id == connection_id, Connection.is_deleted.is_(False))
+        stmt = select(Connection).where(Connection.id == connection_id)
         result: ScalarResult[Connection] = await self._session.scalars(stmt)
         try:
             return result.one()
@@ -99,7 +98,6 @@ async def update(
 
             return await self._update(
                 Connection.id == connection_id,
-                Connection.is_deleted.is_(False),
                 name=name or connection.name,
                 description=description or connection.description,
                 data=data,