Skip to content

Commit 777ef82

Browse files
committed
[DOP-25329] Use SecretStr for cookie secret_key
1 parent 89743c0 commit 777ef82

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

syncmaster/server/middlewares/session.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
def apply_session_middleware(app: FastAPI, settings: SessionSettings) -> FastAPI:
1111
"""Add SessionMiddleware middleware to the application."""
1212

13-
app.add_middleware(
14-
SessionMiddleware,
15-
**settings.model_dump(),
16-
)
13+
settings_dict = settings.model_dump(exclude={"secret_key"})
14+
settings_dict["secret_key"] = settings.secret_key.get_secret_value()
15+
16+
app.add_middleware(SessionMiddleware, **settings_dict)
1717
return app

syncmaster/server/settings/server/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import textwrap
66

7-
from pydantic import BaseModel, ConfigDict, Field
7+
from pydantic import BaseModel, ConfigDict, Field, SecretStr
88

99

1010
class SessionSettings(BaseModel):
@@ -40,7 +40,7 @@ class SessionSettings(BaseModel):
4040
4141
"""
4242

43-
secret_key: str = Field(
43+
secret_key: SecretStr = Field(
4444
description=textwrap.dedent(
4545
"""
4646
Secret key for encrypting cookies.

0 commit comments

Comments
 (0)