[DOP-25282] Fix WPS warnings

Author: dolfinus

pyproject.toml

@@ -455,22 +455,28 @@ ignore = [
   "E704",
 # WPS220 Found too deep nesting: 34 > 20
   "WPS220",
+# WPS412 Found `__init__.py` module with logic
+  "WPS412",
+# WPS410 Found wrong metadata variable: __all__
+  "WPS410",
 ]
 
 per-file-ignores = [
-# F401 imported but unused
-# WPS410 Found wrong metadata variable: __all__
-# WPS412 Found `__init__.py` module with logic
-  "__init__.py:F401,WPS410,WPS412",
 # WPS102 Found incorrect module name pattern
 # WPS432 Found magic number: 256
   "*migrations/*.py:WPS102,WPS432",
   "*db/models/*.py:WPS102,WPS432",
+  "*db/mixins/*.py:WPS102,WPS432",
+# WPS432 Found magic number: 180
+  "*settings/*.py:WPS432",
 # WPS404 Found complex default value
   "*server/api/*.py:WPS404",
 # WPS237 Found a too complex `f` string
   "*exceptions/*.py:WPS237",
   "*exceptions/__init__.py:F40,WPS410",
+# WPS201 Found module with too many imports: 30 > 25
+# WPS203 Found module with too many imported names: 55 > 50
+  "syncmaster/worker/controller.py:WPS201,WPS203",
 # TAE001 too few type annotations
 # WPS231 Found function with too much cognitive complexity
 # S101 Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.

syncmaster/db/migrations/env.py

@@ -47,7 +47,7 @@ def get_next_revision_id():
                 id_num = int(id_part)
                 existing_ids.append(id_num)
             except ValueError:
-                continue
+                pass
 
     if existing_ids:
         next_id = max(existing_ids) + 1

syncmaster/db/mixins/__init__.py

@@ -3,3 +3,9 @@
 from syncmaster.db.mixins.deletable import DeletableMixin
 from syncmaster.db.mixins.resource import ResourceMixin
 from syncmaster.db.mixins.timestamp import TimestampMixin
+
+__all__ = [
+    "DeletableMixin",
+    "ResourceMixin",
+    "TimestampMixin",
+]

syncmaster/db/models/__init__.py

@@ -9,3 +9,20 @@
 from syncmaster.db.models.run import Run, RunType, Status
 from syncmaster.db.models.transfer import Transfer
 from syncmaster.db.models.user import User
+
+__all__ = [
+    "Base",
+    "User",
+    "Group",
+    "UserGroup",
+    "GroupMemberRole",
+    "Connection",
+    "ConnectionType",
+    "Transfer",
+    "Queue",
+    "Run",
+    "RunType",
+    "Status",
+    "AuthData",
+    "APSchedulerJob",
+]

syncmaster/db/models/group.py

@@ -109,3 +109,4 @@ class UserGroup(Base):
         ChoiceType(GroupMemberRole),
         nullable=False,
     )
+    group: Mapped[Group] = relationship(viewonly=True)

syncmaster/db/repositories/base.py

@@ -29,8 +29,7 @@ async def _read_by_id(self, id: int, **kwargs: Any) -> Model:
             raise EntityNotFoundError
         return obj
 
-    @staticmethod
-    def _model_as_dict(model: Model) -> dict[str, Any]:
+    def _model_as_dict(self, model: Model) -> dict[str, Any]:
         d = []
         for c in model.__table__.columns:
             if c.name in ("id", "search_vector"):

syncmaster/db/repositories/connection.py

@@ -132,7 +132,7 @@ async def copy(
         except IntegrityError as integrity_error:
             self._raise_error(integrity_error)
 
-    def _raise_error(self, err: DBAPIError) -> NoReturn:
+    def _raise_error(self, err: DBAPIError) -> NoReturn:  # noqa: WPS238
         constraint = err.__cause__.__cause__.constraint_name
         if constraint == "fk__connection__group_id__group":
             raise GroupNotFoundError from err

syncmaster/db/repositories/group.py

@@ -361,7 +361,7 @@ async def delete_user(
         await self._session.delete(user_group)
         await self._session.flush()
 
-    def _raise_error(self, err: DBAPIError) -> NoReturn:
+    def _raise_error(self, err: DBAPIError) -> NoReturn:  # noqa: WPS238
         constraint = err.__cause__.__cause__.constraint_name
 
         if constraint == "fk__group__owner_id__user":

syncmaster/db/repositories/queue.py

@@ -137,7 +137,7 @@ async def get_group_permission(self, user: User, group_id: int) -> Permission:
 
         return Permission.DELETE
 
-    async def get_resource_permission(self, user: User, resource_id: int) -> Permission:
+    async def get_resource_permission(self, user: User, resource_id: int) -> Permission:  # noqa: WPS212
         """
         Method for determining CRUD rights in a repository (self.model) for a resource
         'DEVELOPER' does not have WRITE permission in the QUEUE repository
@@ -192,8 +192,7 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
 
         return Permission.DELETE
 
-    @staticmethod
-    def _raise_error(err: DBAPIError) -> NoReturn:
+    def _raise_error(self, err: DBAPIError) -> NoReturn:
         constraint = err.__cause__.__cause__.constraint_name
         if constraint == "uq__queue__slug":
             raise DuplicatedQueueNameError

syncmaster/db/repositories/repository_with_owner.py

@@ -13,7 +13,7 @@
 
 
 class RepositoryWithOwner(Repository, Generic[Model]):
-    async def get_resource_permission(self, user: User, resource_id: int) -> Permission:
+    async def get_resource_permission(self, user: User, resource_id: int) -> Permission:  # noqa: WPS212
         """Method for determining CRUD rights in a repository (self.model) for a resource"""
         is_exists = await self._session.get(self._model, resource_id)
 
@@ -68,7 +68,7 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
 
         return Permission.DELETE  # Maintainer
 
-    async def get_group_permission(self, user: User, group_id: int) -> Permission:
+    async def get_group_permission(self, user: User, group_id: int) -> Permission:  # noqa: WPS212
         """Method for determining CRUD permissions in the specified group"""
         owner_query = (
             (