Fix S3 and IcebergRestS3 tests

Author: dolfinus

tests/test_integration/test_run_transfer/connection_fixtures/iceberg_fixtures.py

@@ -137,6 +137,7 @@ async def iceberg_rest_s3_connection(
             s3_bucket=iceberg.s3_bucket,
             s3_region=iceberg.s3_region,
             s3_bucket_style=iceberg.s3_bucket_style,
+            s3_additional_params=iceberg.s3_additional_params,
         ),
         group_id=group.id,
     )

tests/test_integration/test_run_transfer/connection_fixtures/s3_fixtures.py

@@ -164,6 +164,7 @@ async def s3_connection(
             bucket=s3.bucket,
             bucket_style=s3.bucket_style,
             protocol=s3.protocol,
+            additional_params=s3.additional_params,
         ),
         group_id=group.id,
     )

tests/test_unit/test_connections/test_db_connection/test_create_iceberg_connection.py

@@ -80,6 +80,7 @@ async def test_developer_plus_can_create_iceberg_rest_s3_connection(
             "s3_bucket": connection.data["s3_bucket"],
             "s3_region": connection.data["s3_region"],
             "s3_bucket_style": connection.data["s3_bucket_style"],
+            "s3_additional_params": connection.data["s3_additional_params"],
         },
         "auth_data": {
             "type": decrypted["type"],

tests/test_unit/test_connections/test_db_connection/test_update_iceberg_connection.py

@@ -2,7 +2,6 @@
 from httpx import AsyncClient
 
 from tests.mocks import MockConnection, UserTestRoles
-from tests.test_unit.utils import fetch_connection_json
 
 pytestmark = [pytest.mark.asyncio, pytest.mark.server, pytest.mark.iceberg]
 
@@ -39,13 +38,11 @@ async def test_developer_plus_can_update_iceberg_rest_s3_connection(
     role_developer_plus: UserTestRoles,
 ):
     user = group_connection.owner_group.get_member_of_role(role_developer_plus)
-    connection_json = await fetch_connection_json(client, user.token, group_connection)
 
     result = await client.put(
         f"v1/connections/{group_connection.id}",
         headers={"Authorization": f"Bearer {user.token}"},
         json={
-            **connection_json,
             "type": group_connection.type,
             "connection_data": {
                 "metastore_url": "http://rest.domain.com:8000",
@@ -81,6 +78,7 @@ async def test_developer_plus_can_update_iceberg_rest_s3_connection(
             "s3_bucket": "new_bucket",
             "s3_region": "us-east-2",
             "s3_bucket_style": "domain",
+            "s3_additional_params": {},
         },
         "auth_data": {
             "type": group_connection.credentials.value["type"],