Skip to content

Commit a6a29fb

Browse files
dolfinusdolfinus
committed
[DOP-23620] Show reponse json in status_code assertion
1 parent 88c22d1 commit a6a29fb

File tree

62 files changed

+276
-291
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+276
-291
lines changed

‎tests/test_unit/test_connections/test_copy_connection.py‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async def test_maintainer_plus_can_copy_connection_without_deleting_source(
5656
)
5757

5858
# Assertions
59-
assert result.status_code == 200
59+
assert result.status_code == 200, result.json()
6060
assert result.json() == {
6161
"ok": True,
6262
"status_code": 200,
@@ -124,7 +124,7 @@ async def test_maintainer_plus_can_copy_connection_and_delete_source(
124124
},
125125
)
126126

127-
assert result.status_code == 200
127+
assert result.status_code == 200, result.json()
128128
assert result.json() == {
129129
"ok": True,
130130
"status_code": 200,
@@ -189,7 +189,7 @@ async def test_superuser_can_copy_connection_without_deleting_source(
189189
},
190190
)
191191

192-
assert result.status_code == 200
192+
assert result.status_code == 200, result.json()
193193
assert result.json() == {
194194
"ok": True,
195195
"status_code": 200,
@@ -255,7 +255,7 @@ async def test_superuser_can_copy_connection_and_delete_source(
255255
},
256256
)
257257

258-
assert result.status_code == 200
258+
assert result.status_code == 200, result.json()
259259
assert result.json() == {
260260
"ok": True,
261261
"status_code": 200,
@@ -292,7 +292,7 @@ async def test_unauthorized_user_cannot_copy_connection(
292292
"new_group_id": empty_group.id,
293293
},
294294
)
295-
assert result.status_code == 401
295+
assert result.status_code == 401, result.json()
296296
assert result.json() == {
297297
"error": {
298298
"code": "unauthorized",
@@ -315,7 +315,7 @@ async def test_groupless_user_cannot_copy_connection(
315315
"new_group_id": empty_group.id,
316316
},
317317
)
318-
assert result.status_code == 404
318+
assert result.status_code == 404, result.json()
319319
assert result.json() == {
320320
"error": {
321321
"code": "not_found",
@@ -342,7 +342,7 @@ async def test_other_group_member_cannot_copy_connection(
342342
"new_group_id": group.group.id,
343343
},
344344
)
345-
assert result.status_code == 404
345+
assert result.status_code == 404, result.json()
346346
assert result.json() == {
347347
"error": {
348348
"code": "not_found",
@@ -404,7 +404,7 @@ async def test_not_in_both_groups_user_can_not_copy_connection(
404404
"details": None,
405405
},
406406
}
407-
assert result.status_code == 404
407+
assert result.status_code == 404, result.json()
408408

409409

410410
async def test_groupless_user_can_not_copy_connection(
@@ -451,7 +451,7 @@ async def test_groupless_user_can_not_copy_connection(
451451
)
452452

453453
# Assert
454-
assert result.status_code == 404
454+
assert result.status_code == 404, result.json()
455455
assert result.json() == {
456456
"error": {
457457
"code": "not_found",
@@ -482,7 +482,7 @@ async def test_developer_plus_can_copy_connection_without_remove_source(
482482
)
483483

484484
# Assert
485-
assert result.status_code == 200
485+
assert result.status_code == 200, result.json()
486486
assert result.json() == {
487487
"ok": True,
488488
"status_code": 200,
@@ -511,7 +511,7 @@ async def test_developer_plus_can_copy_connection_with_new_connection_name(
511511
)
512512

513513
# Assert
514-
assert result.status_code == 200
514+
assert result.status_code == 200, result.json()
515515
assert result.json() == {
516516
"ok": True,
517517
"status_code": 200,
@@ -633,7 +633,7 @@ async def test_developer_below_can_not_copy_connection_with_remove_source(
633633
"details": None,
634634
},
635635
}
636-
assert result.status_code == 403
636+
assert result.status_code == 403, result.json()
637637

638638

639639
async def test_cannot_copy_connection_with_unknown_connection_error(
@@ -664,7 +664,7 @@ async def test_cannot_copy_connection_with_unknown_connection_error(
664664
"details": None,
665665
},
666666
}
667-
assert result.status_code == 404
667+
assert result.status_code == 404, result.json()
668668

669669

670670
async def test_superuser_cannot_copy_unknown_connection_error(
@@ -689,7 +689,7 @@ async def test_superuser_cannot_copy_unknown_connection_error(
689689
"details": None,
690690
},
691691
}
692-
assert result.status_code == 404
692+
assert result.status_code == 404, result.json()
693693

694694

695695
async def test_cannot_copy_connection_with_unknown_new_group_id_error(
@@ -719,7 +719,7 @@ async def test_cannot_copy_connection_with_unknown_new_group_id_error(
719719
"details": None,
720720
},
721721
}
722-
assert result.status_code == 404
722+
assert result.status_code == 404, result.json()
723723

724724

725725
async def test_superuser_cannot_copy_connection_with_unknown_new_group_id_error(
@@ -744,4 +744,4 @@ async def test_superuser_cannot_copy_connection_with_unknown_new_group_id_error(
744744
"details": None,
745745
},
746746
}
747-
assert result.status_code == 404
747+
assert result.status_code == 404, result.json()

‎tests/test_unit/test_connections/test_create_connection.py‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ async def afin():
9090
"user": decrypted["user"],
9191
},
9292
}
93-
assert result.status_code == 200
93+
assert result.status_code == 200, result.json()
9494

9595

9696
async def test_unauthorized_user_cannot_create_connection(
@@ -116,7 +116,7 @@ async def test_unauthorized_user_cannot_create_connection(
116116
},
117117
},
118118
)
119-
assert result.status_code == 401
119+
assert result.status_code == 401, result.json()
120120
assert result.json() == {
121121
"error": {
122122
"code": "unauthorized",
@@ -157,7 +157,7 @@ async def test_check_fields_validation_on_create_connection(
157157
)
158158

159159
# Assert
160-
assert result.status_code == 422
160+
assert result.status_code == 422, result.json()
161161
assert result.json() == {
162162
"error": {
163163
"code": "invalid_request",
@@ -197,7 +197,7 @@ async def test_check_fields_validation_on_create_connection(
197197
)
198198

199199
# Assert
200-
assert result.status_code == 422
200+
assert result.status_code == 422, result.json()
201201
assert result.json() == {
202202
"error": {
203203
"code": "invalid_request",
@@ -234,7 +234,7 @@ async def test_check_fields_validation_on_create_connection(
234234
},
235235
},
236236
)
237-
assert result.status_code == 422
237+
assert result.status_code == 422, result.json()
238238
assert result.json() == {
239239
"error": {
240240
"code": "invalid_request",
@@ -273,7 +273,7 @@ async def test_check_fields_validation_on_create_connection(
273273
},
274274
)
275275

276-
assert result.status_code == 422
276+
assert result.status_code == 422, result.json()
277277
assert (
278278
result.json()["error"]["details"][0]["message"]
279279
== "Input tag 'POSTGRESQL' found using 'type' does not match any of the expected tags: 'oracle', 'postgres', 'mysql', 'mssql', 'clickhouse', 'hive', 'hdfs', 's3', 'sftp', 'ftp', 'ftps', 'webdav', 'samba'"
@@ -319,7 +319,7 @@ async def test_other_group_member_cannot_create_group_connection(
319319
"details": None,
320320
},
321321
}
322-
assert result.status_code == 404
322+
assert result.status_code == 404, result.json()
323323

324324

325325
async def test_superuser_can_create_connection(
@@ -366,7 +366,7 @@ async def test_superuser_can_create_connection(
366366
)
367367
).one()
368368
decrypted = decrypt_auth_data(creds.value, settings=settings)
369-
assert result.status_code == 200
369+
assert result.status_code == 200, result.json()
370370
assert result.json() == {
371371
"id": connection.id,
372372
"group_id": connection.group_id,
@@ -420,7 +420,7 @@ async def test_groupless_user_cannot_create_connection(
420420
"details": None,
421421
},
422422
}
423-
assert result.status_code == 404
423+
assert result.status_code == 404, result.json()
424424

425425

426426
async def test_group_member_cannot_create_connection_with_unknown_group_error(
@@ -536,7 +536,7 @@ async def test_guest_cannot_create_connection_error(
536536
)
537537

538538
# Assert
539-
assert result.status_code == 403
539+
assert result.status_code == 403, result.json()
540540
assert result.json() == {
541541
"error": {
542542
"code": "forbidden",

‎tests/test_unit/test_connections/test_db_connection/test_create_clickhouse_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def test_developer_plus_can_create_clickhouse_connection(
6060

6161
# Assert
6262
decrypted = decrypt_auth_data(creds.value, settings=settings)
63-
assert result.status_code == 200
63+
assert result.status_code == 200, result.json()
6464
assert result.json() == {
6565
"id": connection.id,
6666
"name": connection.name,

‎tests/test_unit/test_connections/test_db_connection/test_create_hive_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ async def test_developer_plus_can_create_hive_connection(
5858

5959
# Assert
6060
decrypted = decrypt_auth_data(creds.value, settings=settings)
61-
assert result.status_code == 200
61+
assert result.status_code == 200, result.json()
6262
assert result.json() == {
6363
"id": connection.id,
6464
"group_id": connection.group_id,

‎tests/test_unit/test_connections/test_db_connection/test_create_mssql_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def test_developer_plus_can_create_mssql_connection(
6060

6161
# Assert
6262
decrypted = decrypt_auth_data(creds.value, settings=settings)
63-
assert result.status_code == 200
63+
assert result.status_code == 200, result.json()
6464
assert result.json() == {
6565
"id": connection.id,
6666
"name": connection.name,

‎tests/test_unit/test_connections/test_db_connection/test_create_mysql_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def test_developer_plus_can_create_mysql_connection(
6060

6161
# Assert
6262
decrypted = decrypt_auth_data(creds.value, settings=settings)
63-
assert result.status_code == 200
63+
assert result.status_code == 200, result.json()
6464
assert result.json() == {
6565
"id": connection.id,
6666
"name": connection.name,

‎tests/test_unit/test_connections/test_db_connection/test_create_oracle_connection.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def test_developer_plus_can_create_oracle_connection_with_service_name(
6060

6161
# Assert
6262
decrypted = decrypt_auth_data(creds.value, settings=settings)
63-
assert result.status_code == 200
63+
assert result.status_code == 200, result.json()
6464
assert result.json() == {
6565
"id": connection.id,
6666
"name": connection.name,
@@ -130,7 +130,7 @@ async def test_developer_plus_can_create_oracle_connection_with_sid(
130130

131131
# Assert
132132
decrypted = decrypt_auth_data(creds.value, settings=settings)
133-
assert result.status_code == 200
133+
assert result.status_code == 200, result.json()
134134
assert result.json() == {
135135
"id": connection.id,
136136
"name": connection.name,
@@ -184,7 +184,7 @@ async def test_developer_plus_create_oracle_connection_with_sid_and_service_name
184184
)
185185

186186
# Assert
187-
assert result.status_code == 422
187+
assert result.status_code == 422, result.json()
188188
assert result.json() == {
189189
"error": {
190190
"code": "invalid_request",

‎tests/test_unit/test_connections/test_db_connection/test_create_postgres_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ async def test_developer_plus_create_postgres_connection(
6060

6161
# Assert
6262
decrypted = decrypt_auth_data(creds.value, settings=settings)
63-
assert result.status_code == 200
63+
assert result.status_code == 200, result.json()
6464
assert result.json() == {
6565
"id": connection.id,
6666
"name": connection.name,

‎tests/test_unit/test_connections/test_db_connection/test_update_clickhouse_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ async def test_developer_plus_can_update_clickhouse_connection(
5252
},
5353
)
5454

55-
assert result.status_code == 200
55+
assert result.status_code == 200, result.json()
5656
assert result.json() == {
5757
"id": group_connection.id,
5858
"name": group_connection.name,

‎tests/test_unit/test_connections/test_db_connection/test_update_mssql_connection.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ async def test_developer_plus_can_update_mssql_connection(
5353
},
5454
)
5555

56-
assert result.status_code == 200
56+
assert result.status_code == 200, result.json()
5757
assert result.json() == {
5858
"id": group_connection.id,
5959
"name": group_connection.name,

0 commit comments

Comments
 (0)