[DOP-25451] Use PUT /v1/groups/:id/users/:id instead of PATCH

Author: dolfinus

docs/changelog/0.2.2.rst

@@ -5,6 +5,7 @@ Breaking
 --------
 
 - Use ``PUT /v1/qroups/:id`` instead of ``PATCH /v1/qroups/:id``.
+- Use ``PUT /v1/qroups/:id/users/:id`` instead of ``PATCH /v1/qroups/:id/users/:id``.
 - Use ``PUT /v1/queues/:id`` instead of ``PATCH /v1/queues/:id``.
 - Now allowed names length should be in 3..128 symbols range, not 1..inf.
 

syncmaster/server/api/v1/groups.py

@@ -173,7 +173,7 @@ async def read_group_users(
     return UserPageSchemaAsGroupMember.from_pagination(pagination=pagination)
 
 
-@router.patch("/groups/{group_id}/users/{user_id}")
+@router.put("/groups/{group_id}/users/{user_id}")
 async def update_user_role_group(
     group_id: int,
     user_id: int,

tests/test_unit/test_groups/test_update_member_role.py

@@ -14,7 +14,7 @@ async def test_owner_of_group_can_update_user_role(
 ):
     user = group.get_member_of_role(role_maintainer_or_below)
     group_owner = group.get_member_of_role(UserTestRoles.Owner)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/{user.user.id}",
         headers={"Authorization": f"Bearer {group_owner.token}"},
         json={
@@ -34,7 +34,7 @@ async def test_superuser_can_update_user_role(
     role_guest_plus_without_owner: UserTestRoles,
 ):
     user = group.get_member_of_role(role_maintainer_or_below)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/{user.user.id}",
         headers={"Authorization": f"Bearer {superuser.token}"},
         json={
@@ -52,7 +52,7 @@ async def test_owner_of_group_can_not_update_user_role_with_wrong_role(
     role_maintainer_or_below: UserTestRoles,
 ):
     user = group.get_member_of_role(role_maintainer_or_below)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/{user.user.id}",
         headers={"Authorization": f"Bearer {group.get_member_of_role(UserTestRoles.Owner).token}"},
         json={
@@ -87,7 +87,7 @@ async def test_maintainer_below_can_not_update_user_role(
 ):
     updating_user = group.get_member_of_role(role_maintainer_or_below)
     user_to_update = group.get_member_of_role(role_guest_plus)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/{user_to_update.user.id}",
         headers={"Authorization": f"Bearer {updating_user.token}"},
         json={
@@ -114,7 +114,7 @@ async def test_other_group_member_can_not_update_user_role(
 ):
     user = group_connection.owner_group.get_member_of_role(role_guest_plus)
     group_member = group.get_member_of_role(role_guest_plus_without_owner)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/{group_member.user.id}",
         headers={"Authorization": f"Bearer {user.token}"},
         json={
@@ -140,7 +140,7 @@ async def test_superuser_update_unknown_group_error(
     role_guest_plus_without_owner: UserTestRoles,
 ):
     user = group.get_member_of_role(role_maintainer_or_below)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/-1/users/{user.user.id}",
         headers={"Authorization": f"Bearer {superuser.token}"},
         json={
@@ -163,7 +163,7 @@ async def test_superuser_update_unknown_user_error(
     superuser: MockUser,
     role_guest_plus_without_owner: UserTestRoles,
 ):
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/-1",
         headers={"Authorization": f"Bearer {superuser.token}"},
         json={
@@ -187,7 +187,7 @@ async def test_owner_of_group_update_unknown_user_error(
     role_guest_plus_without_owner: UserTestRoles,
 ):
     group.get_member_of_role(role_maintainer_or_below)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/{group.id}/users/-1",
         headers={"Authorization": f"Bearer {group.get_member_of_role(UserTestRoles.Owner).token}"},
         json={
@@ -211,7 +211,7 @@ async def test_owner_of_group_update_unknown_group_error(
     role_guest_plus_without_owner: UserTestRoles,
 ):
     user = group.get_member_of_role(role_maintainer_or_below)
-    result = await client.patch(
+    result = await client.put(
         f"v1/groups/-1/users/{user.user.id}",
         headers={"Authorization": f"Bearer {group.get_member_of_role(UserTestRoles.Owner).token}"},
         json={