Skip Tests done step on workflow cancel

dolfinus · dolfinus · commit c89861b55a4d · 2025-12-28T21:15:17.000+03:00
diff --git a/.github/workflows/clickhouse-tests.yml b/.github/workflows/clickhouse-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-clickhouse
diff --git a/.github/workflows/ftp-tests.yml b/.github/workflows/ftp-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-ftp
diff --git a/.github/workflows/ftps-tests.yml b/.github/workflows/ftps-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-ftps
diff --git a/.github/workflows/hdfs-tests.yml b/.github/workflows/hdfs-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-hdfs
diff --git a/.github/workflows/hive-tests.yml b/.github/workflows/hive-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-hive
diff --git a/.github/workflows/iceberg-tests.yml b/.github/workflows/iceberg-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-iceberg
diff --git a/.github/workflows/mssql-tests.yml b/.github/workflows/mssql-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-mssql
diff --git a/.github/workflows/mysql-tests.yml b/.github/workflows/mysql-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-mysql
diff --git a/.github/workflows/oracle-tests.yml b/.github/workflows/oracle-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-oracle
diff --git a/.github/workflows/s3-tests.yml b/.github/workflows/s3-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-s3
diff --git a/.github/workflows/samba-tests.yml b/.github/workflows/samba-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-samba
diff --git a/.github/workflows/scheduler-tests.yml b/.github/workflows/scheduler-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-scheduler
diff --git a/.github/workflows/sftp-tests.yml b/.github/workflows/sftp-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-sftp
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -85,8 +85,13 @@ jobs:
   all_done:
     name: Tests done
     runs-on: ubuntu-latest
-    if: always()
 
+    permissions:
+      contents: write
+      checks: write
+      pull-requests: write
+
+    if: success() || failure()
     needs:
       - unit_tests
       - scheduler_tests
@@ -117,7 +122,6 @@ jobs:
 
       - name: Show test results
         uses: mikepenz/action-junit-report@v5
-        if: success() || failure() # always run even if the previous step fails
         with:
           report_paths: reports/junit/*.xml
 
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -89,7 +89,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-unit
diff --git a/.github/workflows/webdav-tests.yml b/.github/workflows/webdav-tests.yml
@@ -75,7 +75,7 @@ jobs:
           path: logs/*
 
       - name: Upload coverage results
-        if: always()
+        if: success() || failure()
         uses: actions/upload-artifact@v6
         with:
           name: coverage-webdav
