Skip to content

Commit defcaaa

Browse files
committed
Fix S3 and IcebergRestS3 tests
1 parent 9b50078 commit defcaaa

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

tests/test_integration/test_run_transfer/connection_fixtures/s3_fixtures.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def s3_for_conftest(test_settings: TestSettings) -> S3ConnectionDTO:
2626
host=test_settings.TEST_S3_HOST_FOR_CONFTEST,
2727
port=test_settings.TEST_S3_PORT_FOR_CONFTEST,
2828
bucket=test_settings.TEST_S3_BUCKET,
29+
bucket_style=test_settings.TEST_S3_BUCKET_STYLE,
2930
access_key=test_settings.TEST_S3_ACCESS_KEY,
3031
secret_key=test_settings.TEST_S3_SECRET_KEY,
3132
protocol=test_settings.TEST_S3_PROTOCOL,
@@ -42,6 +43,7 @@ def s3_for_worker(test_settings: TestSettings) -> S3ConnectionDTO:
4243
host=test_settings.TEST_S3_HOST_FOR_WORKER,
4344
port=test_settings.TEST_S3_PORT_FOR_WORKER,
4445
bucket=test_settings.TEST_S3_BUCKET,
46+
bucket_style=test_settings.TEST_S3_BUCKET_STYLE,
4547
access_key=test_settings.TEST_S3_ACCESS_KEY,
4648
secret_key=test_settings.TEST_S3_SECRET_KEY,
4749
protocol=test_settings.TEST_S3_PROTOCOL,

tests/test_unit/test_connections/test_db_connection/test_create_iceberg_connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ async def test_developer_plus_can_create_iceberg_rest_s3_connection(
3636
"s3_port": 9010,
3737
"s3_bucket": "some_bucket",
3838
"s3_region": "us-east-1",
39-
"s3_bucket_style": True,
39+
"s3_bucket_style": "path",
4040
},
4141
"auth_data": {
4242
"type": "iceberg_rest_basic_s3_basic",

tests/test_unit/test_connections/test_db_connection/test_update_iceberg_connection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"s3_port": 9010,
2121
"s3_bucket": "some_bucket",
2222
"s3_region": "us-east-1",
23-
"s3_bucket_style": True,
23+
"s3_bucket_style": "path",
2424
},
2525
{
2626
"type": "iceberg_rest_basic_s3_basic",
@@ -79,7 +79,7 @@ async def test_developer_plus_can_update_iceberg_rest_s3_connection(
7979
"s3_port": None,
8080
"s3_bucket": "new_bucket",
8181
"s3_region": "us-east-2",
82-
"s3_bucket_style": False,
82+
"s3_bucket_style": "domain",
8383
},
8484
"auth_data": {
8585
"type": group_connection.credentials.value["type"],

0 commit comments

Comments
 (0)