Small format fixes

Author: dolfinus

syncmaster/db/repositories/credentials_repository.py

@@ -39,7 +39,8 @@ async def read(
             result: ScalarResult[AuthData] = await self._session.scalars(query)
             return decrypt_auth_data(result.one().value, settings=self._settings)
         except NoResultFound as e:
-            raise AuthDataNotFoundError(f"Connection id = {connection_id}") from e
+            msg = f"Connection id = {connection_id}"
+            raise AuthDataNotFoundError(msg) from e
 
     async def read_bulk(
         self,

syncmaster/db/repositories/run.py

@@ -63,9 +63,10 @@ async def create(
         try:
             self._session.add(run)
             await self._session.flush()
-            return run
         except IntegrityError as e:
             self._raise_error(e)
+        else:
+            return run
 
     async def update(self, run_id: int, **kwargs: Any) -> Run:
         try:

syncmaster/schemas/v1/groups.py

@@ -32,9 +32,7 @@ def validate_role(cls, values):
 
         if role and not GroupMemberRole.is_public_role(role):
             msg = f"Input should be one of: {GroupMemberRole.public_roles_str()}"
-            raise ValueError(
-                msg,
-            )
+            raise ValueError(msg)
         return values
 
 

tests/settings.py

@@ -123,6 +123,7 @@ class TestSettings(BaseSettings):
     TEST_WEBDAV_PASSWORD: str
 
     @model_validator(mode="before")
+    @classmethod
     def check_sid_and_service_name(cls, values):
         sid = values.get("TEST_ORACLE_SID")
         service_name = values.get("TEST_ORACLE_SERVICE_NAME")

tests/utils.py

@@ -1,9 +1,8 @@
 import asyncio
 import logging
 from datetime import UTC, datetime
-from pathlib import Path, PurePath, PurePosixPath
+from pathlib import Path
 from typing import Any
-from collections.abc import Sequence
 
 from alembic.autogenerate import compare_metadata
 from alembic.config import Config