Make S3 region mandatory

Author: dolfinus

tests/test_integration/test_run_transfer/connection_fixtures/s3_fixtures.py

@@ -57,14 +57,15 @@ def s3_for_worker(test_settings: TestSettings) -> S3ConnectionDTO:
 def s3_server(s3_for_conftest):
     S3Server = namedtuple(
         "S3Server",
-        ["host", "port", "bucket", "bucket_style", "access_key", "secret_key", "protocol"],
+        ["host", "port", "bucket", "bucket_style", "region", "access_key", "secret_key", "protocol"],
     )
 
     return S3Server(
         host=s3_for_conftest.host,
         port=s3_for_conftest.port,
         bucket=s3_for_conftest.bucket,
         bucket_style=s3_for_conftest.bucket_style,
+        region=s3_for_conftest.region,
         access_key=s3_for_conftest.access_key,
         secret_key=s3_for_conftest.secret_key,
         protocol=s3_for_conftest.protocol,
@@ -79,6 +80,7 @@ def s3_file_connection(s3_server):
         host=s3_server.host,
         port=s3_server.port,
         bucket=s3_server.bucket,
+        region=s3_server.region,
         access_key=s3_server.access_key,
         secret_key=s3_server.secret_key,
         protocol=s3_server.protocol,
@@ -121,10 +123,11 @@ def s3_file_df_connection(s3_file_connection, spark, s3_server):
         host=s3_server.host,
         port=s3_server.port,
         bucket=s3_server.bucket,
-        access_key=s3_server.access_key,
-        secret_key=s3_server.secret_key,
         protocol=s3_server.protocol,
         path_style_access=s3_server.bucket_style == "path",
+        region=s3_server.region,
+        access_key=s3_server.access_key,
+        secret_key=s3_server.secret_key,
         spark=spark,
     )
 

tests/test_unit/test_connections/test_update_connection.py

@@ -360,6 +360,7 @@ async def test_superuser_cannot_update_connection_auth_data_type_without_secret(
                 "host": "localhost",
                 "port": 9000,
                 "bucket": "new_bucket",
+                "region": "new_region",
             },
             "type": "s3",
             "auth_data": {"type": "s3", "access_key": "s3_key"},